From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D3EE170 for ; Fri, 26 Mar 2021 09:09:48 +0000 (UTC) Received: by mail-wm1-f46.google.com with SMTP id u5-20020a7bcb050000b029010e9316b9d5so2586999wmj.2 for ; Fri, 26 Mar 2021 02:09:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=T70nnYT1S74ukfHVQnDEfFZYXw40llpY2tBON0+87cQ=; b=ThIaQdTN0n4UBBJHBnv/3yTyrAUrvOuxJ0TPzN1GreVZtclPIesu1jbKm7RVp9/ASm yKWRTcyQkUybH0tLmjzL/T0y17NN+YZB4blVV3/Gh6HgMI/4beYdE2O6P3sxM9R9eAd5 9w/8A2KnTy1V4goMi62EYdmfT7Gkh0JQng1EBi9dYiLVek8s3R7oC+lnVhzSD7N4S490 P9Xw33Pcf+wYmMnQkeO8xoAHHk6PFPjdggCKv8tQKgz/aHK6jH5SWcL/weLfEJupJNd7 JoHs7oOqPwzkffWwx4qyaUztbiwsjOuEx/9rbXLjOcojBYivN5aLt7K7YNpLtocfGT+v pbzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=T70nnYT1S74ukfHVQnDEfFZYXw40llpY2tBON0+87cQ=; b=n0AK8tXVPqRq+ufGdLai2qWokZQNYBQlreK6/CIpTxRn3hcmFMLXXRYWxdPeJphsu8 kEkZM814siE/dzlHBr5X9RNpIyN+yqXltIZ46qfivZOQK8CrqTlHXjsvTxjSCA0L+lvC XmAICNvWL6B20goAnW72KMIABz85fHMoGlJ8sfaa8vaDyBo37RXnwyaZVg+PpPWq+SkA 5tOkukQ5E7pB/beQoVJZluFc3bjmhcCZD869cM2l1adJ/RZ4js+waxxSYQWEaQN1clUY gCyah1RT5kdENmTtMXtUJ5c19e7oQhf+AfWVaYv+QEvEyB6mt0rSnWB6dzRabsgyjPQJ 3W1Q== X-Gm-Message-State: AOAM533T+htO2vRczwYb0ZreNDXB9qdNGSvAGMXZ7glFjE+0uZc4eGoo Qg9ild+tsWbBM364K/amCd8= X-Google-Smtp-Source: ABdhPJzq1Ods0QzbRAKBqZHoB/pb5hjMdTQH+r4TAIQfSaP03IeyX2nhSNl1k0nNCuzAYkiFVIwqLw== X-Received: by 2002:a1c:ddc6:: with SMTP id u189mr12297032wmg.171.1616749787435; Fri, 26 Mar 2021 02:09:47 -0700 (PDT) Received: from agape ([5.171.81.75]) by smtp.gmail.com with ESMTPSA id i8sm11309269wrx.43.2021.03.26.02.09.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Mar 2021 02:09:47 -0700 (PDT) From: Fabio Aiuto To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Fabio Aiuto Subject: [PATCH 04/15] staging: rtl8723bs: put parentheses on macros with complex values in include/basic_types.h Date: Fri, 26 Mar 2021 10:09:11 +0100 Message-Id: <2c7c198ccef194b06921bc476eda7d5102ab70dc.1616748885.git.fabioaiuto83@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: References: X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit fix the following checkpatch warnings: ERROR: Macros with complex values should be enclosed in parentheses 154: FILE: drivers/staging/rtl8723bs/include/basic_types.h:154: +#define SET_BITS_TO_LE_4BYTE(__pstart, __bitoffset, __bitlen, __val) \ -- ERROR: Macros with multiple statements should be enclosed in a do - while loop 161: FILE: drivers/staging/rtl8723bs/include/basic_types.h:161: +#define SET_BITS_TO_LE_2BYTE(__pstart, __bitoffset, __bitlen, __val) \ -- ERROR: Macros with complex values should be enclosed in parentheses 168: FILE: drivers/staging/rtl8723bs/include/basic_types.h:168: +#define SET_BITS_TO_LE_1BYTE(__pstart, __bitoffset, __bitlen, __val) \ parentheses solution preferred for all fixes and made macros more readables Signed-off-by: Fabio Aiuto --- .../staging/rtl8723bs/include/basic_types.h | 30 +++++++++++-------- 1 file changed, 18 insertions(+), 12 deletions(-) diff --git a/drivers/staging/rtl8723bs/include/basic_types.h b/drivers/staging/rtl8723bs/include/basic_types.h index 76304086107a..5054c2e3384c 100644 --- a/drivers/staging/rtl8723bs/include/basic_types.h +++ b/drivers/staging/rtl8723bs/include/basic_types.h @@ -152,24 +152,30 @@ /* Set subfield of little-endian 4-byte value to specified value. */ /* */ #define SET_BITS_TO_LE_4BYTE(__pstart, __bitoffset, __bitlen, __val) \ - *((u32 *)(__pstart)) = \ - ( \ - LE_BITS_CLEARED_TO_4BYTE(__pstart, __bitoffset, __bitlen) | \ - ((((u32)__val) & BIT_LEN_MASK_32(__bitlen)) << (__bitoffset)) \ + (\ + *((u32 *)(__pstart)) = \ + ( \ + LE_BITS_CLEARED_TO_4BYTE(__pstart, __bitoffset, __bitlen) | \ + ((((u32)__val) & BIT_LEN_MASK_32(__bitlen)) << (__bitoffset)) \ + )\ ) #define SET_BITS_TO_LE_2BYTE(__pstart, __bitoffset, __bitlen, __val) \ - *((u16 *)(__pstart)) = \ - ( \ - LE_BITS_CLEARED_TO_2BYTE(__pstart, __bitoffset, __bitlen) | \ - ((((u16)__val) & BIT_LEN_MASK_16(__bitlen)) << (__bitoffset)) \ + (\ + *((u16 *)(__pstart)) = \ + ( \ + LE_BITS_CLEARED_TO_2BYTE(__pstart, __bitoffset, __bitlen) | \ + ((((u16)__val) & BIT_LEN_MASK_16(__bitlen)) << (__bitoffset)) \ + )\ ); #define SET_BITS_TO_LE_1BYTE(__pstart, __bitoffset, __bitlen, __val) \ - *((u8 *)(__pstart)) = EF1BYTE \ - ( \ - LE_BITS_CLEARED_TO_1BYTE(__pstart, __bitoffset, __bitlen) | \ - ((((u8)__val) & BIT_LEN_MASK_8(__bitlen)) << (__bitoffset)) \ + (\ + *((u8 *)(__pstart)) = EF1BYTE \ + ( \ + LE_BITS_CLEARED_TO_1BYTE(__pstart, __bitoffset, __bitlen) | \ + ((((u8)__val) & BIT_LEN_MASK_8(__bitlen)) << (__bitoffset)) \ + )\ ) #define LE_BITS_CLEARED_TO_1BYTE_8BIT(__pStart, __BitOffset, __BitLen) \ -- 2.20.1