From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6F29DEE14A5 for ; Wed, 6 Sep 2023 15:23:02 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.596668.930643 (Exim 4.92) (envelope-from ) id 1qduMY-0005Gz-Pw; Wed, 06 Sep 2023 15:22:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 596668.930643; Wed, 06 Sep 2023 15:22:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qduMY-0005Gs-MX; Wed, 06 Sep 2023 15:22:38 +0000 Received: by outflank-mailman (input) for mailman id 596668; Wed, 06 Sep 2023 15:22:37 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qduMX-0005Gm-SC for xen-devel@lists.xenproject.org; Wed, 06 Sep 2023 15:22:37 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 34b46d37-4cc9-11ee-9b0d-b553b5be7939; Wed, 06 Sep 2023 17:22:35 +0200 (CEST) Received: from support.bugseng.com (support.bugseng.com [162.55.131.47]) by support.bugseng.com (Postfix) with ESMTPA id C8AE64EE0737; Wed, 6 Sep 2023 17:22:34 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 34b46d37-4cc9-11ee-9b0d-b553b5be7939 MIME-Version: 1.0 Date: Wed, 06 Sep 2023 17:22:34 +0200 From: Nicola Vetrini To: Jan Beulich Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Andrew Cooper , George Dunlap , Julien Grall , Wei Liu , Bertrand Marquis , Volodymyr Babchuk , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , xen-devel@lists.xenproject.org Subject: Re: [XEN PATCH 1/2] xen: apply deviation for Rule 8.4 (asm-only definitions) In-Reply-To: References: User-Agent: Roundcube Webmail/1.4.3 Message-ID: <2c89b9977fbdc6539f121f5866e22977@bugseng.com> X-Sender: nicola.vetrini@bugseng.com Organization: BUGSENG s.r.l. Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit On 04/09/2023 10:09, Jan Beulich wrote: > On 04.09.2023 09:19, Nicola Vetrini wrote: >> On 04/09/2023 09:02, Jan Beulich wrote: >>> Further in the cover letter you say "Deviating variables needs more >>> care, and >>> is therefore postponed to another patch", yet then here you annotate >>> a >>> couple >>> of variables as well. Could you clarify what the criteria are for >>> "needs more >>> care"? >> >> I see. I did not intend for those changes to end up in this patch, >> although those two are >> clearly only used by asm code and therefore are excepted. >> Most of the variables I left out are also used by C code, therefore >> they >> may be eligible for >> a declaration, but where to put this declaration requires a careful >> examination in my opinion. >> They are not too many, tough. > > Anything also used by C code (and not in the same CU) clearly wants a > declaration. > > Jan I think that a declaration (in an header) is a good idea also when a symbol is defined in a translation unit and it used both by C code in that TU and asm modules. This also allows C code that uses that symbol to be moved around freely without other changes. -- Nicola Vetrini, BSc Software Engineer, BUGSENG srl (https://bugseng.com)