From: Florian Fainelli <florian.fainelli@broadcom.com>
To: Nicolai Buchwitz <nb@tipi-net.de>, netdev@vger.kernel.org
Cc: opendmb@gmail.com, justin.chen@broadcom.com,
bcm-kernel-feedback-list@broadcom.com, andrew+netdev@lunn.ch,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] net: bcmgenet: restore the hardware filters on open
Date: Mon, 14 Sep 2026 12:30:28 -0700 [thread overview]
Message-ID: <2c901027-93d4-4db2-8cac-8b61aaa6e28d@broadcom.com> (raw)
In-Reply-To: <20260913190052.939955-1-nb@tipi-net.de>
On 9/13/26 12:00, Nicolai Buchwitz wrote:
> bcmgenet_hfb_init() runs INIT_LIST_HEAD() on priv->rxnfc_list, which drops
> every rule off the list, and bcmgenet_open() calls it on each ifup. Every
> rule the user configured is silently lost:
>
> # ethtool -N eth0 flow-type ether dst $MAC action 0
> Added rule with ID 0
> # ethtool -n eth0 | grep -c Filter:
> 1
> # ip link set eth0 down && ip link set eth0 up
> # ethtool -n eth0 | grep -c Filter:
> 0
>
> Initialise the lists once at probe and restore the rules on open, as
> bcmgenet_resume() already does.
>
> Fixes: 3e370952287c ("net: bcmgenet: add support for ethtool rxnfc flows")
> Signed-off-by: Nicolai Buchwitz <nb@tipi-net.de>
With the sashiko feedback addressed:
Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
--
Florian
next prev parent reply other threads:[~2026-09-14 19:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-13 19:00 [PATCH net] net: bcmgenet: restore the hardware filters on open Nicolai Buchwitz
2026-09-14 19:02 ` netdev-bot+sashiko
2026-09-14 19:28 ` Justin Chen
2026-09-14 19:30 ` Florian Fainelli [this message]
2026-09-15 2:30 ` patchwork-bot+netdevbpf
-- strict thread matches above, loose matches on Subject: below --
2026-09-15 8:24 Xiang Mei
2026-09-15 8:26 ` Xiang Mei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2c901027-93d4-4db2-8cac-8b61aaa6e28d@broadcom.com \
--to=florian.fainelli@broadcom.com \
--cc=andrew+netdev@lunn.ch \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=justin.chen@broadcom.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nb@tipi-net.de \
--cc=netdev@vger.kernel.org \
--cc=opendmb@gmail.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.