Re: [PATCH mptcp-next] selftests: mptcp: use max_time instead of time

[Mat Martineau <mathew.j.martineau@linux.intel.com>]

On Sat, 22 Oct 2022, Geliang Tang wrote:

> 'time' is the local variable of run_test() function, while 'max_time' is
> the local variable of do_transfer() function. So in do_transfer(),
> $max_time should be used, not $time.
>
> Signed-off-by: Geliang Tang <geliang.tang@suse.com>

Looks good to me, thanks Geliang:

Reviewed-by: Mat Martineau <mathew.j.martineau@linux.intel.com>


> ---
> tools/testing/selftests/net/mptcp/simult_flows.sh | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/testing/selftests/net/mptcp/simult_flows.sh b/tools/testing/selftests/net/mptcp/simult_flows.sh
> index ffa13a957a36..af70c14e0bf9 100755
> --- a/tools/testing/selftests/net/mptcp/simult_flows.sh
> +++ b/tools/testing/selftests/net/mptcp/simult_flows.sh
> @@ -173,7 +173,7 @@ do_transfer()
>
> 	timeout ${timeout_test} \
> 		ip netns exec ${ns3} \
> -			./mptcp_connect -jt ${timeout_poll} -l -p $port -T $time \
> +			./mptcp_connect -jt ${timeout_poll} -l -p $port -T $max_time \
> 				0.0.0.0 < "$sin" > "$sout" &
> 	local spid=$!
>
> @@ -181,7 +181,7 @@ do_transfer()
>
> 	timeout ${timeout_test} \
> 		ip netns exec ${ns1} \
> -			./mptcp_connect -jt ${timeout_poll} -p $port -T $time \
> +			./mptcp_connect -jt ${timeout_poll} -p $port -T $max_time \
> 				10.0.3.3 < "$cin" > "$cout" &
> 	local cpid=$!
>
> -- 
> 2.35.3
>
>
>

--
Mat Martineau
Intel