From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B18F5EB64DD for ; Mon, 7 Aug 2023 10:40:48 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.578007.905180 (Exim 4.92) (envelope-from ) id 1qSxf7-0006q0-Ke; Mon, 07 Aug 2023 10:40:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 578007.905180; Mon, 07 Aug 2023 10:40:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSxf7-0006pt-Hq; Mon, 07 Aug 2023 10:40:33 +0000 Received: by outflank-mailman (input) for mailman id 578007; Mon, 07 Aug 2023 10:40:32 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSxf6-0006pn-Ug for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 10:40:32 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d4cfb23c-350e-11ee-b27d-6b7b168915f2; Mon, 07 Aug 2023 12:40:31 +0200 (CEST) Received: from support.bugseng.com (support.bugseng.com [162.55.131.47]) by support.bugseng.com (Postfix) with ESMTPA id CCA1C4EE0737; Mon, 7 Aug 2023 12:40:30 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d4cfb23c-350e-11ee-b27d-6b7b168915f2 MIME-Version: 1.0 Date: Mon, 07 Aug 2023 12:40:30 +0200 From: Nicola Vetrini To: Jan Beulich Cc: Xen-devel , Stefano Stabellini , Michal Orzel , xenia.ragiadakou@amd.com, Ayan Kumar Halder , consulting@bugseng.com, Andrew Cooper , Julien Grall , George Dunlap , Wei Liu , Stefano Stabellini Subject: Re: Address MISRA C:2012 Rule 8.4 In-Reply-To: References: <786d24b044bfa503a73a36d2a01eae8c@bugseng.com> <00fb1a58849ec08534465df2f8ca2284@bugseng.com> User-Agent: Roundcube Webmail/1.4.3 Message-ID: <2c9becb505cc0ebc528ad02ab8ebbe6e@bugseng.com> X-Sender: nicola.vetrini@bugseng.com Organization: BUGSENG s.r.l. Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit >> One further question is whether functions under >> 'xen/common/coverage/gcov_base.c' should gain >> a declaration in 'gcov.h' or not, as they exist just for the purpose >> of >> being referenced >> by autogenerated profiling code. I see no reason why they shouldn't, >> but >> they can also be safely deviated, >> since they are not called by Xen code. > > Imo it should be the compiler to provide a prototype for these (much > like it does for builtins), thus ensuring that an implementation > actually matches the compiler's expectations. Yet afaics it doesn't. > > Jan Then it's perhaps best to deviate them. -- Nicola Vetrini, BSc Software Engineer, BUGSENG srl (https://bugseng.com)