From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Luca Fancellu <Luca.Fancellu@arm.com>,
Ayan Kumar Halder <ayan.kumar.halder@amd.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
Stefano Stabellini <sstabellini@kernel.org>,
Julien Grall <julien@xen.org>,
Bertrand Marquis <Bertrand.Marquis@arm.com>,
Michal Orzel <michal.orzel@amd.com>,
Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: Re: [PATCH v3] xen/arm: gic-v3: Introduce CONFIG_GICV3_NR_LRS
Date: Mon, 6 Jul 2026 16:25:34 +0100 [thread overview]
Message-ID: <2c9f8d2b-ef36-4d70-aa3f-bb394b48ee3f@citrix.com> (raw)
In-Reply-To: <DAB048A7-AE4F-4E28-A613-8FFE4F0AC359@arm.com>
On 06/07/2026 4:20 pm, Luca Fancellu wrote:
>> On 6 Jul 2026, at 14:35, Ayan Kumar Halder <ayan.kumar.halder@amd.com> wrote:
>>
>> gicv3_ich_read_lr()/gicv3_ich_write_lr() now reject out-of-range
>> indices with an error message, ASSERT_UNREACHABLE() and WARN() instead
>> of silently returning RAZ/WI; reaching this path indicates a bug.
>>
> I was thinking that it was better to have a panic or a bug_on for a bug, since
> ASSERT_UNREACHABLE and WARN will go away for release build,
> however if it’s been agreed with Julien I’m ok.
Only ASSERT()'s go away in release builds. WARN()'s remain in release
builds.
~Andrew
prev parent reply other threads:[~2026-07-06 15:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-06 13:35 [PATCH v3] xen/arm: gic-v3: Introduce CONFIG_GICV3_NR_LRS Ayan Kumar Halder
2026-07-06 15:20 ` Luca Fancellu
2026-07-06 15:23 ` Luca Fancellu
2026-07-06 15:25 ` Andrew Cooper [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2c9f8d2b-ef36-4d70-aa3f-bb394b48ee3f@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=Bertrand.Marquis@arm.com \
--cc=Luca.Fancellu@arm.com \
--cc=Volodymyr_Babchuk@epam.com \
--cc=ayan.kumar.halder@amd.com \
--cc=julien@xen.org \
--cc=michal.orzel@amd.com \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.