All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bart Van Assche <bvanassche@acm.org>
To: linan666@huaweicloud.com, axboe@kernel.dk, song@kernel.org,
	yukuai3@huawei.com, hare@suse.de, martin.petersen@oracle.com
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-raid@vger.kernel.org, yangerkun@huawei.com,
	zhangxiaoxu5@huawei.com, wanghai38@huawei.com
Subject: Re: [PATCH 1/4] block: factor out a helper to set logical/physical block size
Date: Tue, 4 Mar 2025 06:32:27 -0800	[thread overview]
Message-ID: <2ca75746-c630-4a15-bf5d-e9cb10b6e83c@acm.org> (raw)
In-Reply-To: <20250304121918.3159388-2-linan666@huaweicloud.com>

On 3/4/25 4:19 AM, linan666@huaweicloud.com wrote:
> +EXPORT_SYMBOL(blk_set_block_size);

This function is exported without documenting what the requirements are
for calling this function? Yikes.

Is my understanding correct that it is only safe to apply changes made 
with blk_set_block_size() by calling
queue_limits_commit_update_frozen()?

Thanks,

Bart.

  reply	other threads:[~2025-03-04 16:53 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-04 12:19 [PATCH 0/4] bugfix of logical_block_size and make it configurable linan666
2025-03-04 12:19 ` [PATCH 1/4] block: factor out a helper to set logical/physical block size linan666
2025-03-04 14:32   ` Bart Van Assche [this message]
2025-04-07 11:25     ` Li Nan
2025-04-07 14:52   ` Christoph Hellwig
2025-03-04 12:19 ` [PATCH 2/4] md: make raid logical_block_size configurable linan666
2025-03-04 12:19 ` [PATCH 3/4] md: prevent adding disks with larger logical_block_size to active arrays linan666
2025-03-04 12:19 ` [PATCH 4/4] md: Fix the return value of mddev_stack_new_rdev linan666

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2ca75746-c630-4a15-bf5d-e9cb10b6e83c@acm.org \
    --to=bvanassche@acm.org \
    --cc=axboe@kernel.dk \
    --cc=hare@suse.de \
    --cc=linan666@huaweicloud.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-raid@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=song@kernel.org \
    --cc=wanghai38@huawei.com \
    --cc=yangerkun@huawei.com \
    --cc=yukuai3@huawei.com \
    --cc=zhangxiaoxu5@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.