Re: [XEN PATCH][for-4.19 v6 1/8] xen: modify or add declarations for variables where needed

[Jan Beulich <jbeulich@suse.com>]

On 01.11.2023 10:30, Nicola Vetrini wrote:
> Some variables with external linkage used in C code do not have
> a visible declaration where they are defined. Other variables
> can be made static, thereby eliminating the need for a declaration.
> Doing so also resolves violations of MISRA C:2012 Rule 8.4.
> 
> Fix typo s/mcinfo_dumpped/mcinfo_dumped/ while making
> the variable static.
> 
> Signed-off-by: Nicola Vetrini <nicola.vetrini@bugseng.com>
> Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
> Acked-by: Jan Beulich <jbeulich@suse.com>
> ---
> Jan's ack is for the x86 part, but no other concerns have been
> raised for the arm files.

Actually, there is one:

> --- a/xen/include/xen/symbols.h
> +++ b/xen/include/xen/symbols.h
> @@ -33,4 +33,5 @@ struct symbol_offset {
>      uint32_t stream; /* .. in the compressed stream.*/
>      uint32_t addr;   /* .. and in the fixed size address array. */
>  };
> +
>  #endif /*_XEN_SYMBOLS_H*/

This is a stray change, and wants dropping here no matter that there indeed
wants to be a blank line there. I'll take the liberty of doing so while
committing.

Jan