From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maarten Lankhorst Subject: Re: [PATCH v3] drm/bridge: Refactor out the panel wrapper from the lvds-encoder bridge. Date: Tue, 6 Jun 2017 16:24:44 +0200 Message-ID: <2cbcbf54-debf-10a1-390d-128171d81f91@linux.intel.com> References: <20170602202514.11900-1-eric@anholt.net> <2ab4e84f-9834-1dce-d16a-14f9cc4083e9@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1910A6E114 for ; Tue, 6 Jun 2017 14:24:48 +0000 (UTC) In-Reply-To: <2ab4e84f-9834-1dce-d16a-14f9cc4083e9@codeaurora.org> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Archit Taneja , Eric Anholt , Andrzej Hajda , Laurent Pinchart , Thierry Reding Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T3AgMDUtMDYtMTcgb20gMTI6MDggc2NocmVlZiBBcmNoaXQgVGFuZWphOgo+Cj4KPiBPbiAwNi8w My8yMDE3IDAxOjU1IEFNLCBFcmljIEFuaG9sdCB3cm90ZToKPj4gTWFueSBEUk0gZHJpdmVycyBo YXZlIGNvbW1vbiBjb2RlIHRvIG1ha2UgYSBzdHViIGNvbm5lY3Rvcgo+PiBpbXBsZW1lbnRhdGlv biB0aGF0IHdyYXBzIGEgZHJtX3BhbmVsLiAgQnkgd3JhcHBpbmcgdGhlIHBhbmVsIGluIGEgRFJN Cj4+IGJyaWRnZSwgYWxsIG9mIHRoZSBjb25uZWN0b3IgY29kZSAoaW5jbHVkaW5nIGNhbGxzIGR1 cmluZyBlbmNvZGVyCj4+IGVuYWJsZS9kaXNhYmxlKSBnb2VzIGF3YXkuCj4+Cj4+IHYyOiBGaXgg YnVpbGQgd2l0aCBDT05GSUdfRFJNPW0sIGRyb3AgImRldiIgYXJndW1lbnQgdGhhdCBzaG91bGQg anVzdAo+PiAgICAgYmUgdGhlIHBhbmVsJ3MgZGV2LCBtb3ZlIGtlcm5lbGRvYyB1cCBhIGxldmVs IGFuZCBkb2N1bWVudAo+PiAgICAgX3JlbW92ZSgpLgo+PiB2MzogRml4IGFub3RoZXIgYnJlYWth Z2Ugd2l0aCBDT05GSUdfRFJNPW0sIGZpeCBicmVha2FnZSB3aXRoCj4+ICAgICBDT05GSUdfT0Y9 biwgbW92ZSBwcm90b3MgdW5kZXIgQ09ORklHX0RSTV9QQU5FTF9CUklER0UsIHdyYXAgYQo+PiAg ICAgbGluZS4KPj4KPj4gU2lnbmVkLW9mZi1ieTogRXJpYyBBbmhvbHQgPGVyaWNAYW5ob2x0Lm5l dD4KPj4gQWNrZWQtYnk6IERhbmllbCBWZXR0ZXIgPGRhbmllbC52ZXR0ZXJAZmZ3bGwuY2g+ICh2 MSkKPj4gUmV2aWV3ZWQtYnk6IEJvcmlzIEJyZXppbGxvbiA8Ym9yaXMuYnJlemlsbG9uQGZyZWUt ZWxlY3Ryb25zLmNvbT4gKHYyKQo+PiBBY2tlZC1ieTogQXJjaGl0IFRhbmVqYSA8YXJjaGl0dEBj b2RlYXVyb3JhLm9yZz4gKHYyKQo+PiAtLS0KPj4KPj4gTmV3IHZlcnNpb24gb2YgdGhlIGZpcnN0 IHBhdGNoIHdpdGggYnVpbGQgZml4ZXMuICBJJ3ZlIHJlLXB1c2hlZCB0bwo+PiBnZXQgYW5vdGhl ciByb3VuZCBvZiBrYnVpbGQgdGVzdCwgYnV0IGlmIGl0IGNvbWVzIGJhY2sgY2xlYW4sIEknZCBs aWtlCj4+IHRvIG1lcmdlIHRoaXMgb25lLCB0aGUgdmM0IHBhdGNoZXMgKHVuY2hhbmdlZCksIGFu ZCBhdG1lbC1obGNkYyAoYWNrZWQKPj4gYnkgdGhlIG1haW50YWluZXIpLiAgSSdkIGJlIGRyb3Bw aW5nIG15IFNUTSBwYXRjaCAocmVwbGFjZWQgYnkgdGhlaXIKPj4gRFNJIHNlcmllcyksIGFuZCBt ZWRpYXRlayAoSSdkIGxpa2UgYW4gYWNrIGZyb20gdGhlIG1haW50YWluZXIgZmlyc3QpLgo+Cj4g VGhhbmtzLCBJJ3ZlIGxvY2FsbHkgcGlja2VkIHVwIHRoaXMgcGF0Y2ggYW5kIHRoZSBmb2xsb3dp bmcgcGF0Y2hlcyBmcm9tCj4gdGhlIHYyIHNlcmllczoKPgo+IFtQQVRDSCB2MiAyLzddIGRybS92 YzQ6IFN3aXRjaCBEU0kgdG8gdGhlIHBhbmVsLWJyaWRnZSBsYXllciwgYW5kIHN1cHBvcnQgYnJp ZGdlcy4KPiBbUEFUQ0ggdjIgMy83XSBkcm0vdmM0OiBTd2l0Y2ggRFBJIHRvIHVzaW5nIHRoZSBw YW5lbC1icmlkZ2UgaGVscGVyLgo+IFtQQVRDSCB2MiA2LzddIGRybS9hdG1lbC1obGNkYzogRHJv cCBjdXN0b20gZW5jb2RlciBjbGVhbnVwIGZ1bmMuCj4gW1BBVENIIHYyIDcvN10gZHJtL2F0bWVs LWhsY2RjOiBSZXBsYWNlIHRoZSBwYW5lbCB1c2FnZSB3aXRoIGRybV9wYW5lbF9icmlkZ2UuIAoK VGhpcyBwYXRjaCBicmVha3Mgc3VwcG9ydCBmb3IgYnVpbGRpbmcgZHJtIGFzIG1vZHVsZSwgYmVj YXVzZSBpdCBpbXBvcnRzIHNvbWUgb2YgdGhlIGRybV9rbXNfaGVscGVyIHN0dWZmLgoKX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxp bmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJl ZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751619AbdFFOYv (ORCPT ); Tue, 6 Jun 2017 10:24:51 -0400 Received: from mga11.intel.com ([192.55.52.93]:46436 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751593AbdFFOYs (ORCPT ); Tue, 6 Jun 2017 10:24:48 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.39,306,1493708400"; d="scan'208";a="95208806" Subject: Re: [PATCH v3] drm/bridge: Refactor out the panel wrapper from the lvds-encoder bridge. To: Archit Taneja , Eric Anholt , Andrzej Hajda , Laurent Pinchart , Thierry Reding Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org References: <20170602202514.11900-1-eric@anholt.net> <2ab4e84f-9834-1dce-d16a-14f9cc4083e9@codeaurora.org> From: Maarten Lankhorst Message-ID: <2cbcbf54-debf-10a1-390d-128171d81f91@linux.intel.com> Date: Tue, 6 Jun 2017 16:24:44 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <2ab4e84f-9834-1dce-d16a-14f9cc4083e9@codeaurora.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Op 05-06-17 om 12:08 schreef Archit Taneja: > > > On 06/03/2017 01:55 AM, Eric Anholt wrote: >> Many DRM drivers have common code to make a stub connector >> implementation that wraps a drm_panel. By wrapping the panel in a DRM >> bridge, all of the connector code (including calls during encoder >> enable/disable) goes away. >> >> v2: Fix build with CONFIG_DRM=m, drop "dev" argument that should just >> be the panel's dev, move kerneldoc up a level and document >> _remove(). >> v3: Fix another breakage with CONFIG_DRM=m, fix breakage with >> CONFIG_OF=n, move protos under CONFIG_DRM_PANEL_BRIDGE, wrap a >> line. >> >> Signed-off-by: Eric Anholt >> Acked-by: Daniel Vetter (v1) >> Reviewed-by: Boris Brezillon (v2) >> Acked-by: Archit Taneja (v2) >> --- >> >> New version of the first patch with build fixes. I've re-pushed to >> get another round of kbuild test, but if it comes back clean, I'd like >> to merge this one, the vc4 patches (unchanged), and atmel-hlcdc (acked >> by the maintainer). I'd be dropping my STM patch (replaced by their >> DSI series), and mediatek (I'd like an ack from the maintainer first). > > Thanks, I've locally picked up this patch and the following patches from > the v2 series: > > [PATCH v2 2/7] drm/vc4: Switch DSI to the panel-bridge layer, and support bridges. > [PATCH v2 3/7] drm/vc4: Switch DPI to using the panel-bridge helper. > [PATCH v2 6/7] drm/atmel-hlcdc: Drop custom encoder cleanup func. > [PATCH v2 7/7] drm/atmel-hlcdc: Replace the panel usage with drm_panel_bridge. This patch breaks support for building drm as module, because it imports some of the drm_kms_helper stuff.