From: Martin KaFai Lau <martin.lau@linux.dev>
To: Jordan Rife <jordan@jrife.io>
Cc: Aditi Ghag <aditi.ghag@isovalent.com>,
Daniel Borkmann <daniel@iogearbox.net>,
Willem de Bruijn <willemdebruijn.kernel@gmail.com>,
Kuniyuki Iwashima <kuniyu@amazon.com>,
Alexei Starovoitov <alexei.starovoitov@gmail.com>,
netdev@vger.kernel.org, bpf@vger.kernel.org
Subject: Re: [PATCH v6 bpf-next 4/7] bpf: udp: Use bpf_udp_iter_batch_item for bpf_udp_iter_state batch items
Date: Thu, 1 May 2025 11:54:55 -0700 [thread overview]
Message-ID: <2ccb3470-0218-4bca-af17-4f9bd1e758a3@linux.dev> (raw)
In-Reply-To: <20250428180036.369192-5-jordan@jrife.io>
On 4/28/25 11:00 AM, Jordan Rife wrote:
> diff --git a/net/ipv4/udp.c b/net/ipv4/udp.c
> index 57ac84a77e3d..866ad29e15bb 100644
> --- a/net/ipv4/udp.c
> +++ b/net/ipv4/udp.c
> @@ -3390,13 +3390,17 @@ struct bpf_iter__udp {
> int bucket __aligned(8);
> };
>
> +union bpf_udp_iter_batch_item {
> + struct sock *sock;
A nit. just noticed this.
Since it needs a respin, rename the pointer from "sock" to "sk". It should be
more consistent with most other places on the "struct socket *sock" / "struct
sock *sk" naming.
next prev parent reply other threads:[~2025-05-01 18:55 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-28 18:00 [PATCH v6 bpf-next 0/7] bpf: udp: Exactly-once socket iteration Jordan Rife
2025-04-28 18:00 ` [PATCH v6 bpf-next 1/7] bpf: udp: Make mem flags configurable through bpf_iter_udp_realloc_batch Jordan Rife
2025-04-28 18:00 ` [PATCH v6 bpf-next 2/7] bpf: udp: Make sure iter->batch always contains a full bucket snapshot Jordan Rife
2025-04-28 18:00 ` [PATCH v6 bpf-next 3/7] bpf: udp: Get rid of st_bucket_done Jordan Rife
2025-05-01 18:28 ` Martin KaFai Lau
2025-04-28 18:00 ` [PATCH v6 bpf-next 4/7] bpf: udp: Use bpf_udp_iter_batch_item for bpf_udp_iter_state batch items Jordan Rife
2025-05-01 18:54 ` Martin KaFai Lau [this message]
2025-05-02 16:08 ` Jordan Rife
2025-04-28 18:00 ` [PATCH v6 bpf-next 5/7] bpf: udp: Avoid socket skips and repeats during iteration Jordan Rife
2025-05-01 18:51 ` Martin KaFai Lau
2025-05-02 16:10 ` Jordan Rife
2025-04-28 18:00 ` [PATCH v6 bpf-next 6/7] selftests/bpf: Return socket cookies from sock_iter_batch progs Jordan Rife
2025-04-28 18:00 ` [PATCH v6 bpf-next 7/7] selftests/bpf: Add tests for bucket resume logic in UDP socket iterators Jordan Rife
2025-05-01 19:00 ` Martin KaFai Lau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2ccb3470-0218-4bca-af17-4f9bd1e758a3@linux.dev \
--to=martin.lau@linux.dev \
--cc=aditi.ghag@isovalent.com \
--cc=alexei.starovoitov@gmail.com \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=jordan@jrife.io \
--cc=kuniyu@amazon.com \
--cc=netdev@vger.kernel.org \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.