From: Stephen Boyd <sboyd@kernel.org>
To: Li Qiang <liqiang01@kylinos.cn>,
inochiama@outlook.com, mturquette@baylibre.com,
unicorn_wang@outlook.com
Cc: linux-clk@vger.kernel.org, Li Qiang <liqiang01@kylinos.cn>
Subject: Re: [PATCH v2 1/1] clk/sophgo: Using BUG() instead of unreachable() in mmux_get_parent_id()
Date: Wed, 10 Jul 2024 14:16:28 -0700 [thread overview]
Message-ID: <2ccd17608ac2a21496a5e05fc2ca93ce.sboyd@kernel.org> (raw)
In-Reply-To: <c8e66d51f880127549e2a3e623be6787f62b310d.1720506143.git.liqiang01@kylinos.cn>
Quoting Li Qiang (2024-07-08 23:36:38)
> In general it's a good idea to avoid using bare unreachable() because it
> introduces undefined behavior in compiled code. but it caused a compilation warning,
> Using BUG() instead of unreachable() to resolve compilation warnings.
>
> Fixes the following warnings:
> drivers/clk/sophgo/clk-cv18xx-ip.o: warning: objtool: mmux_round_rate() falls through to next function bypass_div_round_rate()
>
> Fixes: 80fd61ec46124 ("clk: sophgo: Add clock support for CV1800 SoC")
> Signed-off-by: Li Qiang <liqiang01@kylinos.cn>
> ---
Applied to clk-next
prev parent reply other threads:[~2024-07-10 21:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1720506143.git.liqiang01@kylinos.cn>
2024-07-09 6:36 ` [PATCH v2 1/1] clk/sophgo: Using BUG() instead of unreachable() in mmux_get_parent_id() Li Qiang
2024-07-09 7:28 ` Chen Wang
2024-07-10 21:16 ` Stephen Boyd [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2ccd17608ac2a21496a5e05fc2ca93ce.sboyd@kernel.org \
--to=sboyd@kernel.org \
--cc=inochiama@outlook.com \
--cc=linux-clk@vger.kernel.org \
--cc=liqiang01@kylinos.cn \
--cc=mturquette@baylibre.com \
--cc=unicorn_wang@outlook.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.