From: Coywolf Qi Hunt <coywolf@gmail.com>
To: akpm@osdl.org
Cc: linux-kernel@vger.kernel.org
Subject: [patch] remove barrier() in software_resume()
Date: Wed, 9 Mar 2005 01:56:27 +0800 [thread overview]
Message-ID: <2cd57c9005030809564ee1d487@mail.gmail.com> (raw)
Hello,
This patch removes the redundant compiler barrier. As Linus ever said
"The mb() should make sure that gcc cannot move things around...".
--coywolf
Signed-off-by: Coywolf Qi Hunt <coywolf@gmail.com>
diff -Nrup 2.6.11/kernel/power/disk.c 2.6.11-cy/kernel/power/disk.c
--- 2.6.11/kernel/power/disk.c 2005-03-03 17:12:17.000000000 +0800
+++ 2.6.11-cy/kernel/power/disk.c 2005-03-09 01:47:10.000000000 +0800
@@ -233,7 +233,6 @@ static int software_resume(void)
if ((error = prepare()))
goto Free;
- barrier();
mb();
pr_debug("PM: Restoring saved image.\n");
--
Coywolf Qi Hunt
Homepage http://sosdg.org/~coywolf/
reply other threads:[~2005-03-08 17:56 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2cd57c9005030809564ee1d487@mail.gmail.com \
--to=coywolf@gmail.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.