Re: [patch] updated inotify.

[Coywolf Qi Hunt <coywolf@gmail.com>]

On 5/10/05, Robert Love <rml@novell.com> wrote:
> On Tue, 2005-05-10 at 01:43 +0800, Coywolf Qi Hunt wrote:
> 
> > Here's another compile warning, also in the current -mm tree.
> >
> > > diff -urN linux-2.6.12-rc4/fs/namei.c linux/fs/namei.c
> > > --- linux-2.6.12-rc4/fs/namei.c 2005-05-09 11:52:48.000000000 -0400
> > > +++ linux/fs/namei.c    2005-05-09 11:58:52.000000000 -0400
> >
> > ..
> >
> > > @@ -2172,18 +2174,18 @@
> > >         DQUOT_INIT(old_dir);
> > >         DQUOT_INIT(new_dir);
> > >
> > > +       old_name = fsnotify_oldname_init(old_dentry->d_name.name);
> > > +
> >
> > prodigy:/home/coywolf/2.6.12-rc3-mm3-cy# make fs/namei.o
> >   CC      fs/namei.o
> > /home/coywolf/2.6.12-rc3-mm3-cy/fs/namei.c: In function `vfs_rename':
> > /home/coywolf/2.6.12-rc3-mm3-cy/fs/namei.c:2177: warning: passing arg
> > 1 of `fsnotify_oldname_init' from incompatible pointer type

I didn't understand the warning correctly. unsighned char* and char*
are compatible.
gcc has no problem in casting char* to unsighned char*.

In 2.6.12-rc3-mm3, the placeholder version,
static inline char *fsnotify_oldname_init(struct dentry *old_dentry)
is incompatible to char*, thus the warning.

This warning is fixed in the previous patch.  It''s not necessary for
this update. Better change it back to keep the placeholder one and the
real.one of the same declaration.

-- 
Coywolf Qi Hunt
http://sosdg.org/~coywolf/