From: Coywolf Qi Hunt <coywolf@gmail.com>
To: Paul Jackson <pj@sgi.com>
Cc: akpm@osdl.org, mel@csn.ul.ie, linux-kernel@vger.kernel.org,
dino@in.ibm.com, jschopp@austin.ibm.com, Simon.Derr@bull.net,
torvalds@osdl.org, haveblue@us.ibm.com
Subject: Re: [PATCH 1/4] cpusets oom_kill tweaks
Date: Thu, 1 Sep 2005 18:49:11 +0800 [thread overview]
Message-ID: <2cd57c900509010349d2477b1@mail.gmail.com> (raw)
In-Reply-To: <20050901025827.0e620dd9.pj@sgi.com>
On 9/1/05, Paul Jackson <pj@sgi.com> wrote:
> Coywolf wrote:
> > Why bother ...
>
> The line length in characters was getting too long, the logic was
Yeah. That long line bugged me too when I was writing my lca oom-killer patch.
> getting too convoluted, and the comment only applied to an unobvious
> portion of the line.
>
> Providing a name for the logical condition that a complicated
> expression computes is one of the ways I find useful to make
> code easier to read, and to resolve problems such as those above.
Maybe.
>
> My primary goal in writing code is to minimize the time and effort
> it will take a typical reader to properly understand the code.
> I write first and foremost for humans.
Hmm, I really wish xfs guys follow that too.
--
Coywolf Qi Hunt
http://sosdg.org/~coywolf/
next prev parent reply other threads:[~2005-09-01 10:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-01 9:08 [PATCH 0/4] cpusets mems_allowed constrain GFP_KERNEL, oom killer Paul Jackson
2005-09-01 9:08 ` [PATCH 1/4] cpusets oom_kill tweaks Paul Jackson
2005-09-01 9:39 ` Coywolf Qi Hunt
2005-09-01 9:58 ` Paul Jackson
2005-09-01 10:49 ` Coywolf Qi Hunt [this message]
2005-09-01 9:09 ` [PATCH 2/4] cpusets new __GFP_HARDWALL flag Paul Jackson
2005-09-01 9:09 ` [PATCH 3/4] cpusets formalize intermediate GFP_KERNEL containment Paul Jackson
2005-09-01 9:09 ` [PATCH 4/4] cpusets confine oom_killer to mem_exclusive cpuset Paul Jackson
2005-09-06 8:08 ` [PATCH 0/4] cpusets mems_allowed constrain GFP_KERNEL, oom killer Paul Jackson
2005-09-06 22:29 ` Paul Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2cd57c900509010349d2477b1@mail.gmail.com \
--to=coywolf@gmail.com \
--cc=Simon.Derr@bull.net \
--cc=akpm@osdl.org \
--cc=dino@in.ibm.com \
--cc=haveblue@us.ibm.com \
--cc=jschopp@austin.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mel@csn.ul.ie \
--cc=pj@sgi.com \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.