Re: [PATCH v1 14/21] ieee1275: Platform Keystore (PKS) Support

[sudhakar <sudhakar@linux.ibm.com>]

On 2024-12-31 03:44, Stefan Berger wrote:
> On 12/18/24 9:56 AM, Sudhakar Kuppusamy wrote:
>> enhancing the infrastructure to enable the Platform Keystore (PKS) 
>> feature,
>> which provides access to the SB VERSION, DB, and DBX secure boot 
>> variables
>> from PKS.
>> 
>> Signed-off-by: Sudhakar Kuppusamy <sudhakar@linux.ibm.com>
>> ---
>>   grub-core/kern/ieee1275/ieee1275.c | 117 
>> +++++++++++++++++++++++++++++
> 
> Since this is pSeries-specific stuff I wonder whether this should not
> rather go into include/grub/powerpc/ieee1275/ieee1275.h and
> grub-core/kern/powerpc/ieee1275/ieee1275.c ?

Thank you Stefan.
yes. This should go into pSeries-specific. moved it to pSeries-specific.


> 
>>   include/grub/ieee1275/ieee1275.h   |  14 ++++
>>   2 files changed, 131 insertions(+)
>> 
>> diff --git a/grub-core/kern/ieee1275/ieee1275.c 
>> b/grub-core/kern/ieee1275/ieee1275.c
>> index 36ca2dbfc..8d0048844 100644
>> --- a/grub-core/kern/ieee1275/ieee1275.c
>> +++ b/grub-core/kern/ieee1275/ieee1275.c
>> @@ -807,3 +807,120 @@ grub_ieee1275_get_block_size 
>> (grub_ieee1275_ihandle_t ihandle)
>>       return args.size;
>>   }
>> +
>> +int
>> +grub_ieee1275_test (const char *name, grub_ieee1275_cell_t *missing)
>> +{
>> +  struct test_args
>> +  {
>> +    struct grub_ieee1275_common_hdr common;
>> +    grub_ieee1275_cell_t name;
>> +    grub_ieee1275_cell_t missing;
>> +  } args;
>> +
>> +  INIT_IEEE1275_COMMON (&args.common, "test", 1, 1);
>> +  args.name = (grub_ieee1275_cell_t) name;
>> +
>> +  if (IEEE1275_CALL_ENTRY_FN (&args) == -1)
>> +    return -1;
>> +
>> +  if (args.missing == IEEE1275_CELL_INVALID)
>> +    return -1;
>> +
>> +  *missing = args.missing;
>> +
>> +  return 0;
>> +}
>> +
>> +int
>> +grub_ieee1275_pks_max_object_size (grub_size_t *result)
>> +{
>> +  struct mos_args
>> +  {
>> +    struct grub_ieee1275_common_hdr common;
>> +    grub_ieee1275_cell_t size;
>> +  } args;
>> +
>> +  INIT_IEEE1275_COMMON (&args.common, "pks-max-object-size", 0, 1);
>> +
>> +  if (IEEE1275_CALL_ENTRY_FN (&args) == -1)
>> +    return -1;
>> +
>> +  if (args.size == IEEE1275_CELL_INVALID)
>> +    return -1;
>> +
>> +  *result = args.size;
>> +
>> +  return 0;
>> +}
>> +
>> +int
>> +grub_ieee1275_pks_read_object (grub_uint8_t consumer, grub_uint8_t 
>> *label,
>> +                               grub_size_t label_len, grub_uint8_t 
>> *buffer,
>> +                               grub_size_t buffer_len, grub_size_t 
>> *data_len,
>> +                               grub_uint32_t *policies)
>> +{
>> +  struct pks_read_args
>> +  {
>> +    struct grub_ieee1275_common_hdr common;
>> +    grub_ieee1275_cell_t consumer;
>> +    grub_ieee1275_cell_t label;
>> +    grub_ieee1275_cell_t label_len;
>> +    grub_ieee1275_cell_t buffer;
>> +    grub_ieee1275_cell_t buffer_len;
>> +    grub_ieee1275_cell_t data_len;
>> +    grub_ieee1275_cell_t policies;
>> +    grub_ieee1275_cell_t rc;
>> +  } args;
>> +
>> +  INIT_IEEE1275_COMMON (&args.common, "pks-read-object", 5, 3);
>> +  args.consumer = (grub_ieee1275_cell_t) consumer;
>> +  args.label = (grub_ieee1275_cell_t) label;
>> +  args.label_len = (grub_ieee1275_cell_t) label_len;
>> +  args.buffer = (grub_ieee1275_cell_t) buffer;
>> +  args.buffer_len = (grub_ieee1275_cell_t) buffer_len;
>> +
>> +  if (IEEE1275_CALL_ENTRY_FN (&args) == -1)
>> +    return -1;
>> +
>> +  if (args.data_len == IEEE1275_CELL_INVALID)
>> +    return -1;
>> +
>> +  *data_len = args.data_len;
>> +  *policies = args.policies;
>> +
>> +  return (int) args.rc;
>> +}
>> +
>> +int
>> +grub_ieee1275_pks_read_sbvar (grub_uint8_t sbvarflags, grub_uint8_t 
>> sbvartype,
>> +                              grub_uint8_t *buffer, grub_size_t 
>> buffer_len,
>> +                              grub_size_t *data_len)
>> +{
>> +  struct pks_read_sbvar_args
>> +  {
>> +    struct grub_ieee1275_common_hdr common;
>> +    grub_ieee1275_cell_t sbvarflags;
>> +    grub_ieee1275_cell_t sbvartype;
>> +    grub_ieee1275_cell_t buffer;
>> +    grub_ieee1275_cell_t buffer_len;
>> +    grub_ieee1275_cell_t data_len;
>> +    grub_ieee1275_cell_t rc;
>> +  } args;
>> +
>> +  INIT_IEEE1275_COMMON (&args.common, "pks-read-sbvar", 4, 2);
>> +  args.sbvarflags = (grub_ieee1275_cell_t) sbvarflags;
>> +  args.sbvartype = (grub_ieee1275_cell_t) sbvartype;
>> +  args.buffer = (grub_ieee1275_cell_t) buffer;
>> +  args.buffer_len = (grub_ieee1275_cell_t) buffer_len;
>> +
>> +  if (IEEE1275_CALL_ENTRY_FN (&args) == -1)
>> +    return -1;
>> +
>> +  if (args.data_len == IEEE1275_CELL_INVALID)
>> +    return -1;
>> +
>> +  *data_len = args.data_len;
>> +
>> +  return (int) args.rc;
>> +}
>> diff --git a/include/grub/ieee1275/ieee1275.h 
>> b/include/grub/ieee1275/ieee1275.h
>> index c445d0499..edd8cd0eb 100644
>> --- a/include/grub/ieee1275/ieee1275.h
>> +++ b/include/grub/ieee1275/ieee1275.h
>> @@ -230,6 +230,20 @@ char *EXPORT_FUNC(grub_ieee1275_encode_uint4) 
>> (grub_ieee1275_ihandle_t ihandle,
>>                                                grub_size_t *size);
>>   int EXPORT_FUNC(grub_ieee1275_get_block_size) 
>> (grub_ieee1275_ihandle_t ihandle);
>>   +int EXPORT_FUNC (grub_ieee1275_test) (const char *name,
>> +                                      grub_ieee1275_cell_t *missing);
>> +
>> +int grub_ieee1275_pks_max_object_size (grub_size_t *result);
>> +
>> +int grub_ieee1275_pks_read_object (grub_uint8_t consumer, 
>> grub_uint8_t *label,
>> +                                   grub_size_t label_len, 
>> grub_uint8_t *buffer,
>> +                                   grub_size_t buffer_len, 
>> grub_size_t *data_len,
>> +                                   grub_uint32_t *policies);
>> +
>> +int grub_ieee1275_pks_read_sbvar (grub_uint8_t sbvarflags, 
>> grub_uint8_t sbvartype,
>> +                                  grub_uint8_t *buffer, grub_size_t 
>> buffer_len,
>> +                                  grub_size_t *data_len);
>> +
>>   grub_err_t EXPORT_FUNC(grub_claimmap) (grub_addr_t addr, grub_size_t 
>> size);
>>     int


Thanks,
Sudhakar Kuppusamy

_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel