Re: [PATCH] src: configure systemd-resolved's MulticastDNS= setting

[Denis Kenzior <denkenz@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1455 bytes --]

Hi Daniel,

>> Is there a default?  If so, it should be in bold.  What happens if
>> this setting
>> is omitted?
> 
> If the setting is omitted, we don't touch the default value. Which

Ok, so there's no default that iwd should pick.

> appears to be false, but somebody could patch systemd-resolved to
> change that, so I wasn't sure if that should be documented here. I'll
> add that though.

So instead we may want to mention that if this setting is omitted, the 
systemd-networkd default is used.

>>> +	mdns = l_settings_get_string(active_settings, "Network",
>>> "MulticastDNS");
>>
>> This can return NULL if no MulticastDNS setting is found.  What
>> happens then?
> 
> Nothing happens, there's a null check in resolve_set_mdns().
> 

k, makes sense.   I somehow missed that originally.

>>> @@ -40,6 +40,7 @@
>>>    struct resolve_ops {
>>>    	void (*set_dns)(struct resolve *resolve, char **dns_list);
>>>    	void (*set_domains)(struct resolve *resolve, char
>>> **domain_list);
>>> +	void (*set_mdns)(struct resolve *resolve, char *mdns);
>>
>> should probably be const char *mdns
> 
> OK. Shouldn't the nearby `char **` parameters be `const char *const *`
> too, then?
> 

Possibly.  I think we resisted using the const variation since not many old C 
hacks like to use such syntax.  So we kept using 'char **'.

For passing simple C-strings we like to be const-correct though.

Regards,
-Denis