From: Keir Fraser <Keir.Fraser@cl.cam.ac.uk>
To: Jimi Xenidis <jimix@watson.ibm.com>
Cc: xen-devel@lists.xensource.com
Subject: Re: [RFC][patch] console_flush()
Date: Sat, 1 Apr 2006 10:32:34 +0100 [thread overview]
Message-ID: <2cfa5b0081210c3dafd1d8f6a5865ca7@cl.cam.ac.uk> (raw)
In-Reply-To: <0224EBCD-1722-4ECE-8CFF-16086F62A3A3@watson.ibm.com>
On 31 Mar 2006, at 20:24, Jimi Xenidis wrote:
> It occurs to me that since console_sync_start/stop use ++ and --
> respectively, that it was designed to be "nested" and bracket code
> segments. If this is indeed desirable than perhaps we need another
> interface that simply flushed the console.
> The only real use I can see for it is to flush after the panic message
> rather than using console_sync_start() before it.
It's designed to be nestable, but it doesn't have to be used that way.
The only argument for a new interface function is if we thought its
name and use were significantly less confusing or weird, which I don't
think is the case here. I also like the current strategy of switching
to synchronous console mode *before* writing the critical info you care
about, rather than flushing it after, although I suppose it doesn't
really matter much either way.
-- Keir
next prev parent reply other threads:[~2006-04-01 9:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-31 19:24 [RFC][patch] console_flush() Jimi Xenidis
2006-04-01 9:32 ` Keir Fraser [this message]
2006-04-01 19:38 ` Jimi Xenidis
2006-04-02 8:16 ` Keir Fraser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2cfa5b0081210c3dafd1d8f6a5865ca7@cl.cam.ac.uk \
--to=keir.fraser@cl.cam.ac.uk \
--cc=jimix@watson.ibm.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.