From: Jiri Slaby <jirislaby@kernel.org>
To: Timothy Pearson <tpearson@raptorengineering.com>
Cc: linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-pci <linux-pci@vger.kernel.org>,
Madhavan Srinivasan <maddy@linux.ibm.com>,
Michael Ellerman <mpe@ellerman.id.au>,
christophe leroy <christophe.leroy@csgroup.eu>,
Naveen N Rao <naveen@kernel.org>,
Bjorn Helgaas <bhelgaas@google.com>,
Shawn Anastasio <sanastasio@raptorengineering.com>
Subject: Re: [PATCH] PCI: pnv_php: Fix potential NULL dereference in slot allocator
Date: Thu, 9 Oct 2025 07:54:19 +0200 [thread overview]
Message-ID: <2d00ed57-3c74-492e-83ae-88ca1ce98311@kernel.org> (raw)
In-Reply-To: <97746540.1782404.1759973048120.JavaMail.zimbra@raptorengineeringinc.com>
On 09. 10. 25, 3:24, Timothy Pearson wrote:
> A highly unlikely NULL dereference in the allocation error handling path was
> introduced in 466861909255. Avoid dereferencing php_slot->bus by using
> dev_warn() instead of SLOT_WARN() in the error path.
>
> Fixes: 466861909255 ("PCI: pnv_php: Clean up allocated IRQs on unplug")
> Signed-off-by: Timothy Pearson <tpearson@raptorengineering.com>
LGTM, perhaps also a lnk to the report:
Link:
https://lore.kernel.org/all/304758063.1694752.1757427687463.JavaMail.zimbra@raptorengineeringinc.com/
Reviewed-by: Jiri Slaby <jirislaby@kernel.org>
thanks,
--
js
suse labs
next prev parent reply other threads:[~2025-10-09 5:54 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-15 21:31 [PATCH v3 0/6] PowerNV PCIe Hotplug Driver Fixes Timothy Pearson
2025-07-15 21:36 ` [PATCH v3 1/6] PCI: pnv_php: Properly clean up allocated IRQs on unplug Timothy Pearson
2025-09-09 9:00 ` Jiri Slaby
2025-09-09 14:21 ` Timothy Pearson
2025-10-09 1:24 ` [PATCH] PCI: pnv_php: Fix potential NULL dereference in slot allocator Timothy Pearson
2025-10-09 5:54 ` Jiri Slaby [this message]
2025-11-07 16:07 ` Timothy Pearson
2025-07-15 21:36 ` [PATCH v3 2/6] PCI: pnv_php: Work around switches with broken presence detection Timothy Pearson
2025-07-15 21:37 ` [PATCH v3 3/6] powerpc/eeh: Export eeh_unfreeze_pe() Timothy Pearson
2025-07-15 21:38 ` [PATCH v3 4/6] powerpc/eeh: Make EEH driver device hotplug safe Timothy Pearson
2025-07-15 21:39 ` [PATCH v3 5/6] PCI: pnv_php: Fix surprise plug detection and recovery Timothy Pearson
2025-07-17 23:27 ` Bjorn Helgaas
2025-07-18 0:05 ` Timothy Pearson
2025-07-15 21:39 ` [PATCH v3 6/6] PCI: pnv_php: Enable third attention indicator state Timothy Pearson
2025-07-17 23:27 ` [PATCH v3 0/6] PowerNV PCIe Hotplug Driver Fixes Bjorn Helgaas
2025-07-22 20:47 ` Bjorn Helgaas
2025-07-23 11:00 ` Madhavan Srinivasan
2025-07-23 11:39 ` Bjorn Helgaas
2025-07-23 11:47 ` Ganesh G R
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2d00ed57-3c74-492e-83ae-88ca1ce98311@kernel.org \
--to=jirislaby@kernel.org \
--cc=bhelgaas@google.com \
--cc=christophe.leroy@csgroup.eu \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=maddy@linux.ibm.com \
--cc=mpe@ellerman.id.au \
--cc=naveen@kernel.org \
--cc=sanastasio@raptorengineering.com \
--cc=tpearson@raptorengineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.