From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=95.215.58.86 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1792518131; b=aTt5xGI5ujGjTDhqvkSYBiYmQwH2/fWklT5Zw5NYswj86ZOPz+ZxHrHGlXU/R/FtLO/t 10C82MYaY97SjF1jb8mm1ijTTGFGnrM0Tsdj2s0zw0M4D4o3zZoXlmWV9WlmJ67Epq83K lWnrnOEvTa0t1hxhbIrvYPrjk9p6aR1OrMvvE3s5CdmW52uDUd/Fo1BTHaCp8+7T7ZQT9 3EBRaoLVq5Pq9YKMXj2O4+AGVVCvZPwSTUKeHhZu4jiSM9IWaRqMlcRvvYYLXlhN+o5TE 1aMTOoVCxPn9h+/zc8+7zqCum7ZLIvkPifasN+xWqPFumgMJ6PTYVA28aFarFtYENig== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1792518131; h=DMARC-Filter:X-Envelope-To:DKIM-Signature:X-Envelope-To:Received: X-Mizu-Trace-ID:X-Migadu-Flow:Message-ID:Date:MIME-Version:User-Agent: Subject:To:Cc:References:Content-Language:From:In-Reply-To: Content-Type:Content-Transfer-Encoding; bh=KcuisqKcfY3dDkZrKVJFMzd0fcQSPtB9DKKrNu6xMDc=; b=piyEXnStcp4iAqmdE9AhHXV/coaBPd9Ul4yRpre1q5pz25uEIuHI4s+ZRjq4ESP2TEEI y/9vfm7DCNAbDbXvfEXRBLqbMfvT6mzJyoUHcOMLBfvGo6OWMRgc7U1LK2IaWnxyPFLE3 b8gM3UFCCGVHFUDJjq5C8sVMG3xQV8rT2gZZL6c4Lhl45xBUNO+mMcfBbGs0niu5kGhOY B+6T7huA7/OyJwchrgi3w9tw9bcbFrwH8Jr/8kZAuDedSLa38o2roUWcmb15tr7mbsChQ ZEs+NapifYtn9767gK96+MfL32/qfVsPE+BtSft+/ueqXGyLXJEXiUmJ4YcyZxw5dzQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b=lptfetT5; arc=none smtp.remote-ip=95.215.58.86 Received: from mta1.migadu.com (out-86.mta1.migadu.com [95.215.58.86]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A4862606A31C for ; Tue, 20 Oct 2026 17:42:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org A4862606A31C Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key, unprotected) header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b=lptfetT5 X-Envelope-To: linux-input@vger.kernel.org DKIM-Signature: a=rsa-sha256; bh=HYlZAjvPSvUg0EYki+B31cFwdxYGZdn+4RyzYF3vYvA=; c=simple/simple; d=linux.dev; h=from:to:subject:date:message-id:mime-version:content-type; s=key1; t=1792518128; v=1; x=1793122928; b=lptfetT5dOp/2iAjEqVDD7cYtmxdUNBZ+peHMyAKCJ7yL0nkjG/A3G/EWtl7QWmSv+d6sUaN OXSRpeYp1wxjeSok+Zu8xSgZ6WdIU9LPs8soKqG/wFT8o9zuthY6jAQaYy0VyfRTGEZXJzHibTD DXDkn/21wF1WWmEkjWy3LXc4= X-Envelope-To: linux-input@vger.kernel.org Received: by smtp.migadu.com with ESMTPS id 7f73adbe8e2cc93d; Tue, 20 Oct 2026 17:42:08 +0000 X-Mizu-Trace-ID: 7f73adbe8e2cc93d X-Migadu-Flow: FLOW_OUT Message-ID: <2d180813-48c1-4a39-bbfa-83b813dea60a@linux.dev> Date: Tue, 20 Oct 2026 19:42:06 +0200 X-Mailing-List: linux-input@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 7/7] HID: asus: Keep the Zenbook Duo input device names To: Paolo Pisati , Jiri Kosina , Benjamin Tissoires Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, =?UTF-8?Q?Rebecca_Mara_M=C3=BCller?= , Luke Jones , Joshua Leivenzon , Ivan Levchenko , Nathan Chancellor References: <20261020092423.36380-1-p.pisati@gmail.com> <20261020092423.36380-8-p.pisati@gmail.com> Content-Language: en-US From: Denis Benato In-Reply-To: <20261020092423.36380-8-p.pisati@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 10/20/26 11:24, Paolo Pisati wrote: > hid-asus renames the input devices of the keyboards it handles to > "Asus Keyboard", except for the ROG N-Key ones, which keep the names > the devices report. New devices are not renamed any more, so skip the > rename for the Zenbook Duo keyboards too: their input devices keep the > "ASUS Zenbook Duo Keyboard" names they get without this driver. Reviewed-by: Denis Benato > Suggested-by: Denis Benato > Signed-off-by: Paolo Pisati > --- > drivers/hid/hid-asus.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/hid/hid-asus.c b/drivers/hid/hid-asus.c > index 6ee2ecca864d..69894de8f6ce 100644 > --- a/drivers/hid/hid-asus.c > +++ b/drivers/hid/hid-asus.c > @@ -1712,10 +1712,10 @@ static int asus_probe(struct hid_device *hdev, const struct hid_device_id *id) > hid_warn(hdev, "Failed to initialize backlight.\n"); > > /* > - * For ROG keyboards, skip rename for consistency and ->input check as > - * some devices do not have inputs. > + * For ROG and Zenbook Duo keyboards, skip rename for consistency and > + * ->input check as some devices do not have inputs. > */ > - if (drvdata->quirks & QUIRK_ROG_NKEY_KEYBOARD) > + if (drvdata->quirks & (QUIRK_ROG_NKEY_KEYBOARD | QUIRK_ZENBOOK_DUO_KEYBOARD)) > return 0; > > /*