From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 454B4C25B75 for ; Tue, 14 May 2024 11:10:15 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.721407.1124792 (Exim 4.92) (envelope-from ) id 1s6q2Q-0001Bw-T6; Tue, 14 May 2024 11:09:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 721407.1124792; Tue, 14 May 2024 11:09:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1s6q2Q-0001Bp-PN; Tue, 14 May 2024 11:09:42 +0000 Received: by outflank-mailman (input) for mailman id 721407; Tue, 14 May 2024 11:09:42 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1s6q2Q-0001AG-3t for xen-devel@lists.xenproject.org; Tue, 14 May 2024 11:09:42 +0000 Received: from mail-lf1-x12f.google.com (mail-lf1-x12f.google.com [2a00:1450:4864:20::12f]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 73cbc523-11e2-11ef-b4bb-af5377834399; Tue, 14 May 2024 13:09:37 +0200 (CEST) Received: by mail-lf1-x12f.google.com with SMTP id 2adb3069b0e04-51f0f6b613dso6798065e87.1 for ; Tue, 14 May 2024 04:09:37 -0700 (PDT) Received: from [10.80.67.140] (default-46-102-197-194.interdsl.co.uk. [46.102.197.194]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-41fccbe8f9bsm192197055e9.6.2024.05.14.04.09.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 14 May 2024 04:09:35 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 73cbc523-11e2-11ef-b4bb-af5377834399 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.com; s=google; t=1715684977; x=1716289777; darn=lists.xenproject.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=t6e28PtWjPyOR6vJsno5O8bavbhaT20wT5u1Y1bDg/s=; b=ulkdQ2ERkYX6SHdLJ0682Nc2upQzvgIg76b5PSSXTpp0r6msBRiYtcW8Kp4imR1DFs FoMiy377ffXIn3z3raJSWX5coh142A94/qE784wm6dARQLut+VgCtsfv+beyoUrOcKnC tlak9VhzaZa7rmuL+8b38ydr9xnfvipnZsn+M= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715684977; x=1716289777; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=t6e28PtWjPyOR6vJsno5O8bavbhaT20wT5u1Y1bDg/s=; b=KJxyCpWzaBZFUpCKlg2t5Z8cdjfb145f6qcJk4NCN0+Yh92gcN+GmYGssgZDFoOma/ TTJx9Omcgvdu5oMFmlrykPbGRrUBqlTQmGFUTcLJO6rwF7SkRsTuDEiGba05I7qn60zK zM1itpm8GTgX5+xvQ2WbKe5FmKBpMIgv5nU6SZjXVZQnX4m/4yRxa/n++k4NtbCKi2NF UmYPb0MmRK2xIEm+A7AIPxdSKRBcIkduAymklAmqFzBRCPMwbFBdcb3hFH6mEGUqqLyM zSNQf96B2gOuCVPsvtU3MXNXE7F+joAjFwMOVri46lIXvi4k3gIjcQLIyI3mxf+JMH/f 846A== X-Forwarded-Encrypted: i=1; AJvYcCVK8otadumHDmceWiAIb3WQ54PZiDNLACBIASAOlsxE2MbPv90drZ5Ax+I69xU45Z6OFPHYIJ/NV3DtPlp8oydsrUkiAq5XagrT6YZsePs= X-Gm-Message-State: AOJu0Yy711qQaTy5/HlUnpBRVtaTzyFYKa1FMcDrgi9YKLwP60FRRhEb AnnGTJYtg0nHrGhwqsujg84nBRJFOn4jO1wGqQ19jvOjAOONAlD5iF8GUK0JO0k= X-Google-Smtp-Source: AGHT+IGmj9eLRnXuV9wapF6LmORCL/C4rRF6omSHYQQhIO6rdl0+ZodwRSrtb5Pk9L4/8+JfrEmcCA== X-Received: by 2002:a05:6512:3da2:b0:522:2fa0:c3f5 with SMTP id 2adb3069b0e04-5222fa0cd89mr8799894e87.62.1715684976947; Tue, 14 May 2024 04:09:36 -0700 (PDT) Message-ID: <2d245c04-3bf9-4b9d-ad02-e754dcbefa28@citrix.com> Date: Tue, 14 May 2024 12:09:35 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH for-4.19] x86/mtrr: avoid system wide rendezvous when setting AP MTRRs To: Roger Pau Monne , xen-devel@lists.xenproject.org Cc: Jan Beulich , Oleksii Kurochko References: <20240513085925.59324-1-roger.pau@citrix.com> Content-Language: en-GB From: Andrew Cooper Autocrypt: addr=andrew.cooper3@citrix.com; keydata= xsFNBFLhNn8BEADVhE+Hb8i0GV6mihnnr/uiQQdPF8kUoFzCOPXkf7jQ5sLYeJa0cQi6Penp VtiFYznTairnVsN5J+ujSTIb+OlMSJUWV4opS7WVNnxHbFTPYZVQ3erv7NKc2iVizCRZ2Kxn srM1oPXWRic8BIAdYOKOloF2300SL/bIpeD+x7h3w9B/qez7nOin5NzkxgFoaUeIal12pXSR Q354FKFoy6Vh96gc4VRqte3jw8mPuJQpfws+Pb+swvSf/i1q1+1I4jsRQQh2m6OTADHIqg2E ofTYAEh7R5HfPx0EXoEDMdRjOeKn8+vvkAwhviWXTHlG3R1QkbE5M/oywnZ83udJmi+lxjJ5 YhQ5IzomvJ16H0Bq+TLyVLO/VRksp1VR9HxCzItLNCS8PdpYYz5TC204ViycobYU65WMpzWe LFAGn8jSS25XIpqv0Y9k87dLbctKKA14Ifw2kq5OIVu2FuX+3i446JOa2vpCI9GcjCzi3oHV e00bzYiHMIl0FICrNJU0Kjho8pdo0m2uxkn6SYEpogAy9pnatUlO+erL4LqFUO7GXSdBRbw5 gNt25XTLdSFuZtMxkY3tq8MFss5QnjhehCVPEpE6y9ZjI4XB8ad1G4oBHVGK5LMsvg22PfMJ ISWFSHoF/B5+lHkCKWkFxZ0gZn33ju5n6/FOdEx4B8cMJt+cWwARAQABzSlBbmRyZXcgQ29v cGVyIDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29tPsLBegQTAQgAJAIbAwULCQgHAwUVCgkI CwUWAgMBAAIeAQIXgAUCWKD95wIZAQAKCRBlw/kGpdefoHbdD/9AIoR3k6fKl+RFiFpyAhvO 59ttDFI7nIAnlYngev2XUR3acFElJATHSDO0ju+hqWqAb8kVijXLops0gOfqt3VPZq9cuHlh IMDquatGLzAadfFx2eQYIYT+FYuMoPZy/aTUazmJIDVxP7L383grjIkn+7tAv+qeDfE+txL4 SAm1UHNvmdfgL2/lcmL3xRh7sub3nJilM93RWX1Pe5LBSDXO45uzCGEdst6uSlzYR/MEr+5Z JQQ32JV64zwvf/aKaagSQSQMYNX9JFgfZ3TKWC1KJQbX5ssoX/5hNLqxMcZV3TN7kU8I3kjK mPec9+1nECOjjJSO/h4P0sBZyIUGfguwzhEeGf4sMCuSEM4xjCnwiBwftR17sr0spYcOpqET ZGcAmyYcNjy6CYadNCnfR40vhhWuCfNCBzWnUW0lFoo12wb0YnzoOLjvfD6OL3JjIUJNOmJy RCsJ5IA/Iz33RhSVRmROu+TztwuThClw63g7+hoyewv7BemKyuU6FTVhjjW+XUWmS/FzknSi dAG+insr0746cTPpSkGl3KAXeWDGJzve7/SBBfyznWCMGaf8E2P1oOdIZRxHgWj0zNr1+ooF /PzgLPiCI4OMUttTlEKChgbUTQ+5o0P080JojqfXwbPAyumbaYcQNiH1/xYbJdOFSiBv9rpt TQTBLzDKXok86M7BTQRS4TZ/ARAAkgqudHsp+hd82UVkvgnlqZjzz2vyrYfz7bkPtXaGb9H4 Rfo7mQsEQavEBdWWjbga6eMnDqtu+FC+qeTGYebToxEyp2lKDSoAsvt8w82tIlP/EbmRbDVn 7bhjBlfRcFjVYw8uVDPptT0TV47vpoCVkTwcyb6OltJrvg/QzV9f07DJswuda1JH3/qvYu0p vjPnYvCq4NsqY2XSdAJ02HrdYPFtNyPEntu1n1KK+gJrstjtw7KsZ4ygXYrsm/oCBiVW/OgU g/XIlGErkrxe4vQvJyVwg6YH653YTX5hLLUEL1NS4TCo47RP+wi6y+TnuAL36UtK/uFyEuPy wwrDVcC4cIFhYSfsO0BumEI65yu7a8aHbGfq2lW251UcoU48Z27ZUUZd2Dr6O/n8poQHbaTd 6bJJSjzGGHZVbRP9UQ3lkmkmc0+XCHmj5WhwNNYjgbbmML7y0fsJT5RgvefAIFfHBg7fTY/i kBEimoUsTEQz+N4hbKwo1hULfVxDJStE4sbPhjbsPCrlXf6W9CxSyQ0qmZ2bXsLQYRj2xqd1 bpA+1o1j2N4/au1R/uSiUFjewJdT/LX1EklKDcQwpk06Af/N7VZtSfEJeRV04unbsKVXWZAk uAJyDDKN99ziC0Wz5kcPyVD1HNf8bgaqGDzrv3TfYjwqayRFcMf7xJaL9xXedMcAEQEAAcLB XwQYAQgACQUCUuE2fwIbDAAKCRBlw/kGpdefoG4XEACD1Qf/er8EA7g23HMxYWd3FXHThrVQ HgiGdk5Yh632vjOm9L4sd/GCEACVQKjsu98e8o3ysitFlznEns5EAAXEbITrgKWXDDUWGYxd pnjj2u+GkVdsOAGk0kxczX6s+VRBhpbBI2PWnOsRJgU2n10PZ3mZD4Xu9kU2IXYmuW+e5KCA vTArRUdCrAtIa1k01sPipPPw6dfxx2e5asy21YOytzxuWFfJTGnVxZZSCyLUO83sh6OZhJkk b9rxL9wPmpN/t2IPaEKoAc0FTQZS36wAMOXkBh24PQ9gaLJvfPKpNzGD8XWR5HHF0NLIJhgg 4ZlEXQ2fVp3XrtocHqhu4UZR4koCijgB8sB7Tb0GCpwK+C4UePdFLfhKyRdSXuvY3AHJd4CP 4JzW0Bzq/WXY3XMOzUTYApGQpnUpdOmuQSfpV9MQO+/jo7r6yPbxT7CwRS5dcQPzUiuHLK9i nvjREdh84qycnx0/6dDroYhp0DFv4udxuAvt1h4wGwTPRQZerSm4xaYegEFusyhbZrI0U9tJ B8WrhBLXDiYlyJT6zOV2yZFuW47VrLsjYnHwn27hmxTC/7tvG3euCklmkn9Sl9IAKFu29RSo d5bD8kMSCYsTqtTfT6W4A3qHGvIDta3ptLYpIAOD2sY3GYq2nf3Bbzx81wZK14JdDDHUX2Rs 6+ahAA== In-Reply-To: <20240513085925.59324-1-roger.pau@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 13/05/2024 9:59 am, Roger Pau Monne wrote: > There's no point in forcing a system wide update of the MTRRs on all processors > when there are no changes to be propagated. On AP startup it's only the AP > that needs to write the system wide MTRR values in order to match the rest of > the already online CPUs. > > We have occasionally seen the watchdog trigger during `xen-hptool cpu-online` > in one Intel Cascade Lake box with 448 CPUs due to the re-setting of the MTRRs > on all the CPUs in the system. > > While there adjust the comment to clarify why the system-wide resetting of the > MTRR registers is not needed for the purposes of mtrr_ap_init(). > > Signed-off-by: Roger Pau Monné > --- > For consideration for 4.19: it's a bugfix of a rare instance of the watchdog > triggering, but it's also a good performance improvement when performing > cpu-online. > > Hopefully runtime changes to MTRR will affect a single MSR at a time, lowering > the chance of the watchdog triggering due to the system-wide resetting of the > range. "Runtime" changes will only be during dom0 boot, if at all, but yes - it is restricted to a single MTRR at a time. It's XENPF_{add,del,read}_memtype, but it's only used by Classic Linux.  PVOps only issues read_memtype. Acked-by: Andrew Cooper