From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2EBCC433EF for ; Thu, 4 Nov 2021 06:51:16 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8FC0E60EB8 for ; Thu, 4 Nov 2021 06:51:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 8FC0E60EB8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=collabora.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Ag5iF2Yf+nrkCV24L7i4bGs4NASylN+OCiYxhnpEcaE=; b=yCzKLzU3IwbrxrdOQHx7zAzpiD ntjyKshi+byMbTHLIBqx5n9KYdm76RjZfwuHwWro7LlNE2u6RG9A+d/MqP0GSmRcDHytUKxk/TQpN Cw+v7p6P+7XRdAPuXMurrdTLyv9eKJ/e9JMzAm4vKInJnmMXDFqBT+6H7MfGnFgI8IgRFIWtLcrzV vs8P/Y8icTYce0rcs+ho1gCSpkQZK4GHJlcKQXyQ+kI4Sn7OpF6LM/gAQCNCYSn0DGuhg/KCrZFvQ cbuB78KMLjdyl4GgI/y986DEElq08S0fMs2nDSqnQpUBdg0lOWV1OCXIWJ6lvOQS2zlIgEb8DF/G2 WjNMp1wQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1miWaS-00843L-AB; Thu, 04 Nov 2021 06:51:00 +0000 Received: from bhuna.collabora.co.uk ([2a00:1098:0:82:1000:25:2eeb:e3e3]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1miWaO-008423-Bt for linux-mediatek@lists.infradead.org; Thu, 04 Nov 2021 06:50:59 +0000 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: dafna) with ESMTPSA id 666D81F45D8E Subject: =?UTF-8?B?UmU6IOetlOWkjTog562U5aSNOiBbUEFUQ0ggNC81XSBtZWRpYTogbXRr?= =?UTF-8?Q?-vcodec=3a_Add_two_error_cases_upon_vpu_irq_handling?= To: Irui Wang Cc: Linux Media Mailing List , "moderated list:ARM/Mediatek SoC support" , Collabora Kernel ML References: <20210804142729.7231-1-dafna.hirschfeld@collabora.com> <20210804142729.7231-5-dafna.hirschfeld@collabora.com> <81524c608e9ef640e71d969aa83d1a383e687b0a.camel@mediatek.com> <18e477a2-60c7-3e18-730d-ab0cb5e5821a@collabora.com> <0c9a80957eaf5e5b99436fb3b478838538340da8.camel@mediatek.com> From: Dafna Hirschfeld Message-ID: <2d251d3f-fe9b-9d09-dfd3-e229d335cf88@collabora.com> Date: Thu, 4 Nov 2021 08:50:34 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <0c9a80957eaf5e5b99436fb3b478838538340da8.camel@mediatek.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211103_235056_697194_AAE6AC55 X-CRM114-Status: GOOD ( 32.69 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org CgpPbiAwNC4xMS4yMSAwMzozOCwgSXJ1aSBXYW5nIHdyb3RlOgo+IEhpLAo+IAo+IE9uIFdlZCwg MjAyMS0xMS0wMyBhdCAyMjo1MCArMDIwMCwgRGFmbmEgSGlyc2NoZmVsZCB3cm90ZToKPj4KPj4g T24gMDkuMDguMjEgMTI6MTIsIElydWkgV2FuZyAo546L55GeKSB3cm90ZToKPj4+IEhpIERhZm5h LAo+Pj4KPj4+Pj4gMi4gQWx3YXlzIGhhcHBlbmVkICBpc3N1ZSA/ICB0aW1lb3V0IGF0IHRoZSBi ZWdpbm5pbmcgb3IgIGluCj4+Pj4+IHByb2Nlc3NpbmcgPwo+Pj4+IFRoZSBjb21tYW5kcyB0aGF0 IEkgcnVuIGlzOgo+Pj4+PiBzdWRvIC0tdXNlcj0jMTAwMCAvdXNyL2xvY2FsL2xpYmV4ZWMvY2hy b21lLWJpbmFyeS0KPj4+Pj4gdGVzdHMvdmlkZW9fZW5jb2RlX2FjY2VsZXJhdG9yX3Rlc3RzIC0t Z3Rlc3RfZmlsdGVyPS0KPj4+Pj4gKk5WMTJEbWFidWYqICAtLT4+Y29kZWM9dnA4Cj4+Pj4+PiAv dXNyL2xvY2FsL3NoYXJlL3Rhc3QvZGF0YS9jaHJvbWl1bW9zL3Rhc3QvbG9jYWwvYnVuZGxlcy9j cm9zLwo+Pj4+PiB2aWRlby9kYXRhL3R1bGlwMi0zMjB4MTgwLnl1diAtLWRpc2FibGVfdmFsaWRh dG9yCj4+Pj4+IFRoZSBjb21tYW5kIHNvbWV0aW1lIHN1Y2NlZWQgYnV0IHdoZW4gSSBydW4gaXQg c2VxdWVudGlhbGx5Cj4+Pj4+IHRoZW4gYXQgc29tZSBwb2ludCBhZnRlciBmZXcgYXR0ZW1wdHMg SSBzdGFydCB0byBnZXQgdGhvc2UKPj4+Pj4gdGltZW91dCBlcnJvcnMuCj4+Pgo+Pj4gSXQgc2Vl bXMgbWVhbiBWUDggZW5jb2RpbmcgZnVuY3Rpb24gT0ssIGJ1dCBmYWlsZWQgc29tZXRpbWVzLCBk aWQKPj4+IHlvdSBoYXZlIGNoZWNrIFZFTkMgY2xvY2sgaW5mbyBkdXJpbmcgZW5jb2Rpbmc6Cj4+ Pgo+Pj4gY2F0IC9zeXMva2VybmVsL2RlYnVnL2Nsay9jbGtfc3VtbWFyeSB8IGdyZXAgdmVuYzoK Pj4+Cj4+PiB2ZW5jX3NlbCAgID4gaXQncyBILjI2NCBjbG9jawo+Pj4gdmVuY2x0X3NlbCAgPiBp dCdzIFZQOCBjbG9jawo+Pj4KPj4+IHRoZSBlbmFibGUmcHJlcGFyZSBjb3VudCBpcyBub3QgMCBk dXJpbmcgZW5jb2RpbmcgcHJvY2Vzcy4KPj4+Cj4+PiBUaGFua3MKPj4+IEJlc3QgUmVnYXJkcwo+ Pj4KPj4+IC0tLS0t6YKu5Lu25Y6f5Lu2LS0tLS0KPj4+IOWPkeS7tuS6ujogRGFmbmEgSGlyc2No ZmVsZCBbbWFpbHRvOmRhZm5hLmhpcnNjaGZlbGRAY29sbGFib3JhLmNvbV0KPj4+IOWPkemAgeaX tumXtDogMjAyMeW5tDjmnIg55pelIDE2OjI3Cj4+PiDmlLbku7bkuro6IElydWkgV2FuZyAo546L 55GeKQo+Pj4g5oqE6YCBOiBMaW51eCBNZWRpYSBNYWlsaW5nIExpc3Q7IG1vZGVyYXRlZCBsaXN0 OkFSTS9NZWRpYXRlayBTb0MKPj4+IHN1cHBvcnQ7IEVucmljIEJhbGxldGJvIGkgU2VycmEKPj4+ IOS4u+mimDogUmU6IOetlOWkjTogW1BBVENIIDQvNV0gbWVkaWE6IG10ay12Y29kZWM6IEFkZCB0 d28gZXJyb3IgY2FzZXMgdXBvbgo+Pj4gdnB1IGlycSBoYW5kbGluZwo+Pj4KPj4+Cj4+Pgo+Pj4g T24gMDkuMDguMjEgMDk6MzcsIElydWkgV2FuZyAo546L55GeKSB3cm90ZToKPj4+PiBIaSBEYWZu YSwKPj4+Pgo+Pj4+Pj4gSSBhbSB0ZXN0aW5nIHRoZSB2cDggZW5jb2RlciBvbiBjaHJvbWVvcyBh bmQgYXQgc29tZSBwb2ludAo+Pj4+Pj4gdGhlIGVuY29kZXIgaW50ZXJydXB0cyBzdG9wIGFycml2 aW5nIHNvIEkgdHJ5IHRvIGZpZ3VyZSBvdXQKPj4+Pj4+IHdoeSBhbmQgcmVwb3J0IGFueSBwb3Nz aWJsZSBlcnJvci4KPj4+Pgo+Pj4+IDEuIExvZyBzaG93cyB3YWl0IElSUSB0aW1lb3V0ID8KPj4+ Cj4+PiBIaSwgeWVzLCBJIGdldCB0aW1lb3V0IHdoZW4gd2FpdGluZyB0byB0aGUgZW5jb2RlciBp bnRlcnJ1cHQuIFRoZQo+Pj4gdGltZW91dCBpcyBvbiB2cDhfZW5jX3dhaXRfdmVuY19kb25lCj4+ Pgo+Pj4KPj4+PiAyLiBBbHdheXMgaGFwcGVuZWQgIGlzc3VlID8gIHRpbWVvdXQgYXQgdGhlIGJl Z2lubmluZyBvciAgaW4KPj4+PiBwcm9jZXNzaW5nID8KPj4+Cj4+PiBUaGUgY29tbWFuZHMgdGhh dCBJIHJ1biBpczoKPj4+Cj4+PiBzdWRvIC0tdXNlcj0jMTAwMCAvdXNyL2xvY2FsL2xpYmV4ZWMv Y2hyb21lLWJpbmFyeS0KPj4+IHRlc3RzL3ZpZGVvX2VuY29kZV9hY2NlbGVyYXRvcl90ZXN0cyAt LWd0ZXN0X2ZpbHRlcj0tCj4+PiAqTlYxMkRtYWJ1ZiogIC0tY29kZWM9dnA4Cj4+PiAvdXNyL2xv Y2FsL3NoYXJlL3Rhc3QvZGF0YS9jaHJvbWl1bW9zL3Rhc3QvbG9jYWwvYnVuZGxlcy9jcm9zL3Zp ZGVvCj4+PiAvZGF0YS90dWxpcDItMzIweDE4MC55dXYgLS1kaXNhYmxlX3ZhbGlkYXRvcgo+Pj4K Pj4+IFRoZSBjb21tYW5kIHNvbWV0aW1lIHN1Y2NlZWQgYnV0IHdoZW4gSSBydW4gaXQgc2VxdWVu dGlhbGx5IHRoZW4gYXQKPj4+IHNvbWUgcG9pbnQgYWZ0ZXIgZmV3IGF0dGVtcHRzIEkgc3RhcnQg dG8gZ2V0IHRob3NlIHRpbWVvdXQgZXJyb3JzLgo+Pj4KPj4+PiAzLiBob3cgYWJvdXQgSVJRIGlu Zm9zPwo+Pj4+IGNhdCAvcHJvYy9pbnRlcnJ1cHRzIHwgZ3JlcCB2Y29kZWMKPj4+PiAxODAwMjAw MC52Y29kZWMgICA+PiBpdCdzIEguMjY0IGVuY29kZXIKPj4+PiAxOTAwMjAwMC52Y29kZWMgID4+ IGl0J3MgIFZQOCBlbmNvZGVyCj4+Pj4KPj4+PiBJIHdhcyB0b2xkIHlvdSBoYXZlICBtZXQgYW5v dGhlciBILjI2NCBlbmNvZGluZyBmYWlsZWQgYmVmb3JlLAo+Pj4+IGRpZCB5b3UgZmluZCByZWFz b25zIGFib3V0IHRoYXQgPwo+Pj4KPj4+IE5vLAo+Pj4gQnV0IHNpbmNlIEkgc2VlIHRoYXQgdGhl IGdvb2dsZSBtZWV0dXAgdXNlcyB0aGUgdnA4IGVuY29kZXIgSQo+Pj4gZGVjaWRlZCB0byB0ZXN0 IHRoZSB2cDggZmlyc3QuCj4+Pgo+Pj4+PiBbICAgODEuOTE4NzQ3XSBbTVRLX1Y0TDJdW0VSUk9S XQo+Pj4+PiBtdGtfdmNvZGVjX3dhaXRfZm9yX2RvbmVfY3R4OjMyOiBbM10gY3R4LT50eXBlPTEs IGNtZD0xLAo+Pj4+PiB3YWl0X2V2ZW50X2ludGVycnVwdGlibGVfdGltZW91dCB0aW1lPTEwMDBt cyBvdXQgMCAwIQo+Pj4+PiBbICAgODEuOTMxMzkyXSBbTVRLX1ZDT0RFQ11bRVJST1JdWzNdOiBo MjY0X2VuY29kZV9mcmFtZSgpCj4+Pj4+IGlycV9zdGF0dXM9MCBmYWlsZWQKPj4+Pj4gWyAgIDgx LjkzODQ3MF0gW01US19WNEwyXVtFUlJPUl0gbXRrX3ZlbmNfd29ya2VyOjEyMTk6Cj4+Pj4+IHZl bmNfaWZfZW5jb2RlIGZhaWxlZD0tNQo+Pgo+PiBIaSwKPj4gSSB0ZXN0IHRoZSBkcml2ZXIgb24g ZGViaWFuIG5vdywgSSBzdHJlYW0gc2V2ZXJhbCBpbnN0YW5jZXMgb2YgdnA4Cj4+IGFuZCBoMjY0 IGluIHBhcmFsbGVsLgo+PiBJIHNlZSB0aGF0IHRob3NlIGVycm9ycyBhbHdheXMgb2NjdXIgYWZ0 ZXIgYW4gaW9tbXUgcGFnZSBmYXVsdDoKPj4KPj4gW2dzdC1tYXN0ZXJdIHJvb3RAZGViaWFuOn4v Z3N0LWJ1aWxkIyBbIDU3NDMuMjA2MDE0XSBtdGstaW9tbXUKPj4gMTAyMDUwMDAuaW9tbXU6IGZh dWx0IHR5cGU9MHg1IGlvdmE9MHhhYzJmZjAwMyBwYT0weDAgbGFyYj0zIHBvcnQ9MAo+PiBsYXll cj0xIHdyaXRlCj4+IFsgNTc0NC4yMDQ5NjRdIFtNVEtfVjRMMl1bRVJST1JdIG10a192Y29kZWNf d2FpdF9mb3JfZG9uZV9jdHg6MzI6Cj4+IFsyNzA2XSBjdHgtPnR5cGU9MSwgY21kPTEsIHdhaXRf ZXZlbnRfaW50ZXJydXB0aWJsZV90aW1lb3V0Cj4+IHRpbWU9MTAwMG1zIG91dCAwIDAhCj4+IFsg NTc0NC4yMTc4NDldIFtNVEtfVkNPREVDXVtFUlJPUl1bMjcwNl06IHZwOF9lbmNfZW5jb2RlX2Zy YW1lKCkKPj4gaXJxX3N0YXR1cz0wIGZhaWxlZAo+PiBbIDU3NDQuMjI1MzU5XSBbTVRLX1Y0TDJd W0VSUk9SXSBtdGtfdmVuY193b3JrZXI6MTI0MzogdmVuY19pZl9lbmNvZGUKPj4gZmFpbGVkPS01 Cj4+Cj4+IEkgc3VzcGVjdCB0aGF0IG1heWJlIHRoaXMgaXMgYmVjYXVzZSB0aGUgaW92YSBvZiB0 aGUgd29ya2luZ19idWZmZXJzCj4+IGlzIGhhbmRlZCB0byB0aGUgdnB1IGluIHRoZSBmdW5jdGlv biB2cDhfZW5jX2FsbG9jX3dvcmtfYnVmOgo+PiB3YltpXS5pb3ZhID0gaW5zdC0+d29ya19idWZz W2ldLmRtYV9hZGRyOwo+Pgo+PiBNYXliZSB0aGUgdnB1IGtlZXAgd3JpdGluZyB0byB0aG9zZSBh ZGRyZXNzZXMgYWZ0ZXIgdGhleSBhcmUgYWxyZWFkeQo+PiB1bm1hcHBlZD8KPj4KPj4gVGhhbmtz LAo+PiBEYWZuYQo+IAo+IGZhaWxlZCBsYXJiPTMsIGl0J3MgZm9yIGgyNjQgZW5jb2RlciwgIHZw OCBlbmNvZGVyIGlzIGxhcmI1LCBpcyB0aGVyZQo+IGFueSBoMjY0IGVuY29kaW5nIGZhaWxlZCBh dCB0aGF0IHRpbWU/IEkgaGF2ZSBubyBpZGVhcyB3aHkgdGhlc2UgZXJyb3JzCj4gaGFwcGVuZWQg b24geW91ciBwbGF0Zm9ybSwgYnV0IHdoZW4gd2UgZ290IHRoZSAiaW9tbXU6IGZhdWx0IiwgdGhl Cj4gcG9zc2libGUgcmVhc29uIGlzIHJlbGF0ZWQgdG8gcG93ZXIgb3IgY2xvY2suCgpPbmNlIHRo ZSBpb21tdSBmYXVsdCBmaXJlcywgYm90aCBlbmNvZGVycyBjb25zdGFudGx5IGZhaWwgYW5kIG5l dmVyIHJlY292ZXIKKGFsc28gbm90IHdoZW4gc3RhcnRpbmcgbmV3IGluc3RhbmNlKS4KCldpdGgg dGhlIGZhbHV0OgptdGtfaW9tbXVfaXNyOiBmYXVsdCB0eXBlPTB4NSBpb3ZhPTB4ZWJlZGUwMDMg cGE9MHgwIGxhcmI9MyBwb3J0PTAgbGF5ZXI9MSB3cml0ZQoKSSBsb29rZWQgYXQgdGhlIGlvbW11 IHRyYWNpbmcgbG9nOgoKICAgZ3N0LWxhdW5jaC0xLjAtNjA2ICAgICBbMDAwXSAuLi4uLiAgIDcx NC42MzQzOTg6IHVubWFwOiBJT01NVTogaW92YT0weDAwMDAwMDAwZWJlZGUwMDAgLSAweDAwMDAw MDAwZWJlZGYwMDAgc2l6ZT00MDk2IHVubWFwcGVkX3NpemU9NDA5NgogICBnc3QtbGF1bmNoLTEu MC02MDYgICAgIFswMDBdIC4uLi4uICAgNzE0LjYzNDQxNzogdW5tYXA6IElPTU1VOiBpb3ZhPTB4 MDAwMDAwMDBlYmVkMDAwMCAtIDB4MDAwMDAwMDBlYmVkNTAwMCBzaXplPTIwNDgwIHVubWFwcGVk X3NpemU9MjA0ODAKICAgZ3N0LWxhdW5jaC0xLjAtNjA2ICAgICBbMDAwXSAuLi4uLiAgIDcxNC42 MzQ0MzU6IHVubWFwOiBJT01NVTogaW92YT0weDAwMDAwMDAwZWI4MDAwMDAgLSAweDAwMDAwMDAw ZWJiMGEwMDAgc2l6ZT0zMTg2Njg4IHVubWFwcGVkX3NpemU9MzE4NjY4OAogICBnc3QtbGF1bmNo LTEuMC02MDYgICAgIFswMDBdIC5OLi4uICAgNzE0LjYzNDg5MTogdW5tYXA6IElPTU1VOiBpb3Zh PTB4MDAwMDAwMDBlYjcwMDAwMCAtIDB4MDAwMDAwMDBlYjdmZjAwMCBzaXplPTEwNDQ0ODAgdW5t YXBwZWRfc2l6ZT0xMDQ0NDgwCiAgIGdzdC1sYXVuY2gtMS4wLTYwNiAgICAgWzAwMF0gLk4uLi4g ICA3MTQuNjM1NDgxOiB1bm1hcDogSU9NTVU6IGlvdmE9MHgwMDAwMDAwMGViMDAwMDAwIC0gMHgw MDAwMDAwMGViMzBhMDAwIHNpemU9MzE4NjY4OCB1bm1hcHBlZF9zaXplPTMxODY2ODgKICAgZ3N0 LWxhdW5jaC0xLjAtNjA2ICAgICBbMDAwXSAuLi4uLiAgIDcxNC42MzU5MzQ6IHVubWFwOiBJT01N VTogaW92YT0weDAwMDAwMDAwZWFmMDAwMDAgLSAweDAwMDAwMDAwZWFmZmYwMDAgc2l6ZT0xMDQ0 NDgwIHVubWFwcGVkX3NpemU9MTA0NDQ4MAogICBnc3QtbGF1bmNoLTEuMC02MDYgICAgIFswMDBd IC4uLi4uICAgNzE0LjYzNjA0MTogdW5tYXA6IElPTU1VOiBpb3ZhPTB4MDAwMDAwMDBlYWVmMDAw MCAtIDB4MDAwMDAwMDBlYWYwMDAwMCBzaXplPTY1NTM2IHVubWFwcGVkX3NpemU9NjU1MzYKICAg Z3N0LWxhdW5jaC0xLjAtNjA2ICAgICBbMDAwXSAuLi4uLiAgIDcxNC42MzYwNTY6IHVubWFwOiBJ T01NVTogaW92YT0weDAwMDAwMDAwZWFlZTAwMDAgLSAweDAwMDAwMDAwZWFlZjAwMDAgc2l6ZT02 NTUzNiB1bm1hcHBlZF9zaXplPTY1NTM2CiAgIGdzdC1sYXVuY2gtMS4wLTYwNiAgICAgWzAwMF0g Li4uLi4gICA3MTQuNjM2MDY5OiB1bm1hcDogSU9NTVU6IGlvdmE9MHgwMDAwMDAwMGVhZWRmMDAw IC0gMHgwMDAwMDAwMGVhZWUwMDAwIHNpemU9NDA5NiB1bm1hcHBlZF9zaXplPTQwOTYKICAgICAg a3dvcmtlci8wOjAtNTM3ICAgICBbMDAwXSBkLmguLiAgIDcxNC42MzYxOTE6IGlvX3BhZ2VfZmF1 bHQ6IElPTU1VOm10ay1pb21tdSAxMDIwNTAwMC5pb21tdSBpb3ZhPTB4MDAwMDAwMDBlYmVkZTAw MyBmbGFncz0weDAwMDEKCihJIGNoYW5nZWQgdGhlIGlvbW11IG1hcC91bm1hcCB0cmFjZSBldmVu dHMgdG8gcHJpbnQgdGhlIGlvdmEgcmFuZ2UpCnlvdSBjYW4gc2VlIHRoZSBmaXJzdCBsaW5lIHVu bWFwcGluZyAwMDAwMDAwMGViZWRlMDAwIHdoaWNoIGlzIHRoZSBmYXVsdGluZyBpb3ZhLgpTbyBp dCBzZWVtcyB0aGF0IHRoZSBwcm9ibGVtIGlzIGR1ZSB0byBhIGRldmljZSB0cnlpbmcgdG8gYWNj ZXNzIGFuIGFkZHJlc3MgdGhhdCBpcyBhbHJlYWR5IHVubWFwcGVkLgpUaGlzIG1pZ2h0IGJlIGVp dGhlciB0aGUgZW5jb2RlciBvciB0aGUgdnB1LgpTaW5jZSB0aGUgd2JbaV0uaW92YSBpcyBub3Qg cmVzZXQgd2hlbiBmcmVlaW5nIHRoZSB3b3JraW5nIGJ1ZmZlcnMgSSBzdXNwZWN0IGl0IG1pZ2h0 IGJlIHRoZSB2cHUgZGV2aWNlLCB3aGF0IGRvIHlvdSB0aGluaz8KClRoYW5rcywKRGFmbmEKCj4g Cj4+Cj4+Cj4+Pgo+Pj4KPj4+Pgo+Pj4+IE1UODE3MyBsYXRlc3QgVlBVRCBmaXJtd2FyZToKPj4+ Pgo+IGh0dHBzOi8vZ2l0Lmtlcm5lbC5vcmcvcHViL3NjbS9saW51eC9rZXJuZWwvZ2l0L2Zpcm13 YXJlL2xpbnV4LWZpcm13YXIKPj4+PiBlLmdpdC9jb21taXQvP2lkPWFhZWQ0YThiZjlhNzdlYzY4 Mzc2ZThkOTJmYjIxOGQ1ZmRkODhiNTkKPj4+Pgo+Pj4KPj4+IEkgdXNlcyB0aGUgbGF0ZXN0IGZp cm13YXJlLgo+Pj4KPj4+IFRoYW5rcywKPj4+IERhZm5hCj4+Pgo+Pj4+IFRoYW5rcwo+Pj4+IEJl c3QgUmVnYXJkcwo+Pj4+Cj4+Pj4gLS0tLS3pgq7ku7bljp/ku7YtLS0tLQo+Pj4+IOWPkeS7tuS6 ujogRGFmbmEgSGlyc2NoZmVsZCBbbWFpbHRvOmRhZm5hLmhpcnNjaGZlbGRAY29sbGFib3JhLmNv bV0KPj4+PiDlj5HpgIHml7bpl7Q6IDIwMjHlubQ45pyINuaXpSAxNTo0OQo+Pj4+IOaUtuS7tuS6 ujogSXJ1aSBXYW5nICjnjovnkZ4pOyBsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnOwo+Pj4+ IGxpbnV4LW1lZGlhQHZnZXIua2VybmVsLm9yZzsgbGludXgtbWVkaWF0ZWtAbGlzdHMuaW5mcmFk ZWFkLm9yZwo+Pj4+IOaKhOmAgTogZGFmbmEzQGdtYWlsLmNvbTsgdGZpZ2FAY2hyb21pdW0ub3Jn OyBUaWZmYW55IExpbiAo5p6X5oWn54+KKTsKPj4+PiBlaXphbkBjaHJvbWl1bS5vcmc7IE1hb2d1 YW5nIE1lbmcgKOWtn+avm+W5vyk7IGtlcm5lbEBjb2xsYWJvcmEuY29tOwo+Pj4+IG1jaGVoYWJA a2VybmVsLm9yZzsgaHZlcmt1aWxAeHM0YWxsLm5sOyBZdW5mZWkgRG9uZyAo6JGj5LqR6aOeKTsg WW9uZwo+Pj4+IFd1Cj4+Pj4gKOWQtOWLhyk7IGhzaW55aUBjaHJvbWl1bS5vcmc7IG1hdHRoaWFz LmJnZ0BnbWFpbC5jb207IEFuZHJldy1DVCBDaGVuCj4+Pj4gKOmZs+aZuui/qik7IGFjb3VyYm90 QGNocm9taXVtLm9yZwo+Pj4+IOS4u+mimDogUmU6IFtQQVRDSCA0LzVdIG1lZGlhOiBtdGstdmNv ZGVjOiBBZGQgdHdvIGVycm9yIGNhc2VzIHVwb24KPj4+PiB2cHUKPj4+PiBpcnEgaGFuZGxpbmcK Pj4+Pgo+Pj4+Cj4+Pj4KPj4+PiBPbiAwNi4wOC4yMSAwODo1OCwgSXJ1aSBXYW5nICjnjovnkZ4p IHdyb3RlOgo+Pj4+PiBPbiBXZWQsIDIwMjEtMDgtMDQgYXQgMTY6MjcgKzAyMDAsIERhZm5hIEhp cnNjaGZlbGQgd3JvdGU6Cj4+Pj4+PiAxLiBGYWlsIGlmIHRoZSBmdW5jdGlvbiBtdGtfdmNvZGVj X2Z3X21hcF9kbV9hZGRyIHJldHVybnMgRVJSCj4+Pj4+PiBwb2ludGVyLgo+Pj4+Pj4gMi4gRmFp bCBpZiB0aGUgc3RhdGUgZnJvbSB0aGUgdnB1IG1zZyBpcyBlaXRoZXIKPj4+Pj4+IFZFTl9JUElf TVNHX0VOQ19TVEFURV9FUlJPUiBvciBWRU5fSVBJX01TR19FTkNfU1RBVEVfUEFSVAo+Pj4+Pj4K Pj4+Pj4+IFNpZ25lZC1vZmYtYnk6IERhZm5hIEhpcnNjaGZlbGQgPAo+Pj4+Pj4gZGFmbmEuaGly c2NoZmVsZEBjb2xsYWJvcmEuY29tPgo+Pj4+Pj4gLS0tCj4+Pj4+PiAgICAgZHJpdmVycy9tZWRp YS9wbGF0Zm9ybS9tdGstdmNvZGVjL3ZlbmNfdnB1X2lmLmMgfCA4Cj4+Pj4+PiArKysrKysrKwo+ Pj4+Pj4gICAgIDEgZmlsZSBjaGFuZ2VkLCA4IGluc2VydGlvbnMoKykKPj4+Pj4+Cj4+Pj4+PiBk aWZmIC0tZ2l0IGEvZHJpdmVycy9tZWRpYS9wbGF0Zm9ybS9tdGstdmNvZGVjL3ZlbmNfdnB1X2lm LmMKPj4+Pj4+IGIvZHJpdmVycy9tZWRpYS9wbGF0Zm9ybS9tdGstdmNvZGVjL3ZlbmNfdnB1X2lm LmMKPj4+Pj4+IGluZGV4IDMyZGM4NDRkMTZmOS4uMjM0NzA1YmE3Y2Q2IDEwMDY0NAo+Pj4+Pj4g LS0tIGEvZHJpdmVycy9tZWRpYS9wbGF0Zm9ybS9tdGstdmNvZGVjL3ZlbmNfdnB1X2lmLmMKPj4+ Pj4+ICsrKyBiL2RyaXZlcnMvbWVkaWEvcGxhdGZvcm0vbXRrLXZjb2RlYy92ZW5jX3ZwdV9pZi5j Cj4+Pj4+PiBAQCAtMTcsNiArMTcsOCBAQCBzdGF0aWMgaW50IGhhbmRsZV9lbmNfaW5pdF9tc2co c3RydWN0Cj4+Pj4+PiB2ZW5jX3ZwdV9pbnN0ICp2cHUsIGNvbnN0IHZvaWQgKmRhdGEpCj4+Pj4+ PiAgICAgdnB1LT52c2kgPSBtdGtfdmNvZGVjX2Z3X21hcF9kbV9hZGRyKHZwdS0+Y3R4LT5kZXYt Cj4+Pj4+Pj4gZndfaGFuZGxlciwKPj4+Pj4+ICAgICAgICAgIG1zZy0+dnB1X2luc3RfYWRkcik7 Cj4+Pj4+PiAgICAgCj4+Pj4+PiAraWYgKElTX0VSUih2cHUtPnZzaSkpCj4+Pj4+PiArcmV0dXJu IFBUUl9FUlIodnB1LT52c2kpOwo+Pj4+Pj4gICAgIC8qIEZpcm13YXJlIHZlcnNpb24gZmllbGQg dmFsdWUgaXMgdW5zcGVjaWZpZWQgb24gTVQ4MTczLgo+Pj4+Pj4gKi8KPj4+Pj4+ICAgICBpZiAo dnB1LT5jdHgtPmRldi0+dmVuY19wZGF0YS0+Y2hpcCA9PSBNVEtfTVQ4MTczKQo+Pj4+Pj4gICAg IHJldHVybiAwOwo+Pj4+Pj4gQEAgLTQyLDYgKzQ0LDEyIEBAIHN0YXRpYyBpbnQgaGFuZGxlX2Vu Y19lbmNvZGVfbXNnKHN0cnVjdAo+Pj4+Pj4gdmVuY192cHVfaW5zdCAqdnB1LCBjb25zdCB2b2lk ICpkYXRhKQo+Pj4+Pj4gICAgIHZwdS0+c3RhdGUgPSBtc2ctPnN0YXRlOwo+Pj4+Pj4gICAgIHZw dS0+YnNfc2l6ZSA9IG1zZy0+YnNfc2l6ZTsKPj4+Pj4+ICAgICB2cHUtPmlzX2tleV9mcm0gPSBt c2ctPmlzX2tleV9mcm07Cj4+Pj4+PiAraWYgKHZwdS0+c3RhdGUgPT0gVkVOX0lQSV9NU0dfRU5D X1NUQVRFX0VSUk9SIHx8Cj4+Pj4+PiArICAgIHZwdS0+c3RhdGUgPT0gVkVOX0lQSV9NU0dfRU5D X1NUQVRFX1BBUlQpIHsKPj4+Pj4+IG10a192Y29kZWNfZXJyKHZwdSwKPj4+Pj4+ICsiYmFkIGlw aS1lbmMtc3RhdGU6ICVzIiwKPj4+Pj4+ICsgICAgICAgdnB1LT5zdGF0ZSA9PQo+Pj4+Pj4gVkVO X0lQSV9NU0dfRU5DX1NUQVRFX0VSUk9SID8gIkVSUiIgOiAiUEFSVCIpOwo+Pj4+Pj4gK3JldHVy biAtRUlOVkFMOwo+Pj4+Pj4gK30KPj4+Pj4KPj4+Pj4gSGkgRGFmbmEsCj4+Pj4+Cj4+Pj4+IFRo aXMgc3RhdGUgY2hlY2sgaXMgdXNlbGVzcywgdGhlIGVuYyByZXN1bHQgd2lsbCBjaGVjayBpbgo+ Pj4+PiAidnB1X2VuY19pcGlfaGFuZGxlciIuCj4+Pj4+Cj4+Pj4KPj4+PiBIaSwgdGhhbmtzIGZv ciByZXZpZXdpbmcuIEkgc2VlIHRoYXQgdGhlIHZwdV9lbmNfaXBpX2hhbmRsZXIgb25seQo+Pj4+ IHRlc3QgdGhlIG1zZy0+c3RhdHVzIGFuZCBJIHNlZSB0aGF0IHRoZSBzdGF0ZXMgYXJlIG5vdCB0 ZXN0ZWQKPj4+PiBhbnl3aGVyZSBleGNlcHQgb2YgInNraXAiIHN0YXRlIGluIHRoZSBoMjY0IGVu Yy4KPj4+Pgo+Pj4+IENhbid0IHRoZXJlIGJlIGEgc2NlbmFyaW8gd2hlcmUgbXNnLT5zdGF0dXMg aXMgb2sgYnV0IHRoZSBzdGF0ZQo+Pj4+IGlzIGVycm9yPwo+Pj4+IEkgYW0gdGVzdGluZyB0aGUg dnA4IGVuY29kZXIgb24gY2hyb21lb3MgYW5kIGF0IHNvbWUgcG9pbnQgdGhlCj4+Pj4gZW5jb2Rl ciBpbnRlcnJ1cHRzIHN0b3AgYXJyaXZpbmcgc28gSSB0cnkgdG8gZmlndXJlIG91dCB3aHkgYW5k Cj4+Pj4gcmVwb3J0IGFueSBwb3NzaWJsZSBlcnJvci4KPj4+Pgo+Pj4+IFRoYW5rcywKPj4+PiBE YWZuYQo+Pj4+Cj4+Pj4+IFRoYW5rcwo+Pj4+Pgo+Pj4+Pj4gICAgIHJldHVybiAwOwo+Pj4+Pj4g ICAgIH0KPj4+Pj4+ICAgICAKPj4+Pgo+Pj4+ICoqKioqKioqKioqKiogTUVESUFURUsgQ29uZmlk ZW50aWFsaXR5IE5vdGljZQo+Pj4+ICoqKioqKioqKioqKioqKioqKioqIFRoZQo+Pj4+IGluZm9y bWF0aW9uIGNvbnRhaW5lZCBpbiB0aGlzIGUtbWFpbCBtZXNzYWdlIChpbmNsdWRpbmcgYW55Cj4+ Pj4gYXR0YWNobWVudHMpIG1heSBiZSBjb25maWRlbnRpYWwsIHByb3ByaWV0YXJ5LCBwcml2aWxl Z2VkLCBvcgo+Pj4+IG90aGVyd2lzZSBleGVtcHQgZnJvbSBkaXNjbG9zdXJlIHVuZGVyIGFwcGxp Y2FibGUgbGF3cy4gSXQgaXMKPj4+PiBpbnRlbmRlZAo+Pj4+IHRvIGJlIGNvbnZleWVkIG9ubHkg dG8gdGhlIGRlc2lnbmF0ZWQgcmVjaXBpZW50KHMpLiBBbnkgdXNlLAo+Pj4+IGRpc3NlbWluYXRp b24sIGRpc3RyaWJ1dGlvbiwgcHJpbnRpbmcsIHJldGFpbmluZyBvciBjb3B5aW5nIG9mCj4+Pj4g dGhpcwo+Pj4+IGUtbWFpbCAoaW5jbHVkaW5nIGl0cwo+Pj4+IGF0dGFjaG1lbnRzKSBieSB1bmlu dGVuZGVkIHJlY2lwaWVudChzKSBpcyBzdHJpY3RseSBwcm9oaWJpdGVkCj4+Pj4gYW5kIG1heQo+ Pj4+IGJlIHVubGF3ZnVsLiBJZiB5b3UgYXJlIG5vdCBhbiBpbnRlbmRlZCByZWNpcGllbnQgb2Yg dGhpcyBlLW1haWwsCj4+Pj4gb3IKPj4+PiBiZWxpZXZlIHRoYXQgeW91IGhhdmUgcmVjZWl2ZWQg dGhpcyBlLW1haWwgaW4gZXJyb3IsIHBsZWFzZQo+Pj4+IG5vdGlmeSB0aGUKPj4+PiBzZW5kZXIg aW1tZWRpYXRlbHkgKGJ5IHJlcGx5aW5nIHRvIHRoaXMgZS1tYWlsKSwgZGVsZXRlIGFueSBhbmQK Pj4+PiBhbGwKPj4+PiBjb3BpZXMgb2YgdGhpcyBlLW1haWwgKGluY2x1ZGluZyBhbnkgYXR0YWNo bWVudHMpIGZyb20geW91cgo+Pj4+IHN5c3RlbSwKPj4+PiBhbmQgZG8gbm90IGRpc2Nsb3NlIHRo ZSBjb250ZW50IG9mIHRoaXMgZS1tYWlsIHRvIGFueSBvdGhlcgo+Pj4+IHBlcnNvbi4gVGhhbmsg eW91IQo+Pj4+Cj4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X18KPiBMaW51eC1tZWRpYXRlayBtYWlsaW5nIGxpc3QKPiBMaW51eC1tZWRpYXRla0BsaXN0cy5p bmZyYWRlYWQub3JnCj4gaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5m by9saW51eC1tZWRpYXRlawo+IAoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18KTGludXgtbWVkaWF0ZWsgbWFpbGluZyBsaXN0CkxpbnV4LW1lZGlhdGVrQGxp c3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0 aW5mby9saW51eC1tZWRpYXRlawo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25DC9C433EF for ; Thu, 4 Nov 2021 06:50:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0838B60232 for ; Thu, 4 Nov 2021 06:50:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230119AbhKDGxe (ORCPT ); Thu, 4 Nov 2021 02:53:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52854 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229994AbhKDGxd (ORCPT ); Thu, 4 Nov 2021 02:53:33 -0400 Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e3e3]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D21A6C061714 for ; Wed, 3 Nov 2021 23:50:55 -0700 (PDT) Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: dafna) with ESMTPSA id 666D81F45D8E Subject: =?UTF-8?B?UmU6IOetlOWkjTog562U5aSNOiBbUEFUQ0ggNC81XSBtZWRpYTogbXRr?= =?UTF-8?Q?-vcodec=3a_Add_two_error_cases_upon_vpu_irq_handling?= To: Irui Wang Cc: Linux Media Mailing List , "moderated list:ARM/Mediatek SoC support" , Collabora Kernel ML References: <20210804142729.7231-1-dafna.hirschfeld@collabora.com> <20210804142729.7231-5-dafna.hirschfeld@collabora.com> <81524c608e9ef640e71d969aa83d1a383e687b0a.camel@mediatek.com> <18e477a2-60c7-3e18-730d-ab0cb5e5821a@collabora.com> <0c9a80957eaf5e5b99436fb3b478838538340da8.camel@mediatek.com> From: Dafna Hirschfeld Message-ID: <2d251d3f-fe9b-9d09-dfd3-e229d335cf88@collabora.com> Date: Thu, 4 Nov 2021 08:50:34 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <0c9a80957eaf5e5b99436fb3b478838538340da8.camel@mediatek.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org On 04.11.21 03:38, Irui Wang wrote: > Hi, > > On Wed, 2021-11-03 at 22:50 +0200, Dafna Hirschfeld wrote: >> >> On 09.08.21 12:12, Irui Wang (王瑞) wrote: >>> Hi Dafna, >>> >>>>> 2. Always happened issue ? timeout at the beginning or in >>>>> processing ? >>>> The commands that I run is: >>>>> sudo --user=#1000 /usr/local/libexec/chrome-binary- >>>>> tests/video_encode_accelerator_tests --gtest_filter=- >>>>> *NV12Dmabuf* -->>codec=vp8 >>>>>> /usr/local/share/tast/data/chromiumos/tast/local/bundles/cros/ >>>>> video/data/tulip2-320x180.yuv --disable_validator >>>>> The command sometime succeed but when I run it sequentially >>>>> then at some point after few attempts I start to get those >>>>> timeout errors. >>> >>> It seems mean VP8 encoding function OK, but failed sometimes, did >>> you have check VENC clock info during encoding: >>> >>> cat /sys/kernel/debug/clk/clk_summary | grep venc: >>> >>> venc_sel > it's H.264 clock >>> venclt_sel > it's VP8 clock >>> >>> the enable&prepare count is not 0 during encoding process. >>> >>> Thanks >>> Best Regards >>> >>> -----邮件原件----- >>> 发件人: Dafna Hirschfeld [mailto:dafna.hirschfeld@collabora.com] >>> 发送时间: 2021年8月9日 16:27 >>> 收件人: Irui Wang (王瑞) >>> 抄送: Linux Media Mailing List; moderated list:ARM/Mediatek SoC >>> support; Enric Balletbo i Serra >>> 主题: Re: 答复: [PATCH 4/5] media: mtk-vcodec: Add two error cases upon >>> vpu irq handling >>> >>> >>> >>> On 09.08.21 09:37, Irui Wang (王瑞) wrote: >>>> Hi Dafna, >>>> >>>>>> I am testing the vp8 encoder on chromeos and at some point >>>>>> the encoder interrupts stop arriving so I try to figure out >>>>>> why and report any possible error. >>>> >>>> 1. Log shows wait IRQ timeout ? >>> >>> Hi, yes, I get timeout when waiting to the encoder interrupt. The >>> timeout is on vp8_enc_wait_venc_done >>> >>> >>>> 2. Always happened issue ? timeout at the beginning or in >>>> processing ? >>> >>> The commands that I run is: >>> >>> sudo --user=#1000 /usr/local/libexec/chrome-binary- >>> tests/video_encode_accelerator_tests --gtest_filter=- >>> *NV12Dmabuf* --codec=vp8 >>> /usr/local/share/tast/data/chromiumos/tast/local/bundles/cros/video >>> /data/tulip2-320x180.yuv --disable_validator >>> >>> The command sometime succeed but when I run it sequentially then at >>> some point after few attempts I start to get those timeout errors. >>> >>>> 3. how about IRQ infos? >>>> cat /proc/interrupts | grep vcodec >>>> 18002000.vcodec >> it's H.264 encoder >>>> 19002000.vcodec >> it's VP8 encoder >>>> >>>> I was told you have met another H.264 encoding failed before, >>>> did you find reasons about that ? >>> >>> No, >>> But since I see that the google meetup uses the vp8 encoder I >>> decided to test the vp8 first. >>> >>>>> [ 81.918747] [MTK_V4L2][ERROR] >>>>> mtk_vcodec_wait_for_done_ctx:32: [3] ctx->type=1, cmd=1, >>>>> wait_event_interruptible_timeout time=1000ms out 0 0! >>>>> [ 81.931392] [MTK_VCODEC][ERROR][3]: h264_encode_frame() >>>>> irq_status=0 failed >>>>> [ 81.938470] [MTK_V4L2][ERROR] mtk_venc_worker:1219: >>>>> venc_if_encode failed=-5 >> >> Hi, >> I test the driver on debian now, I stream several instances of vp8 >> and h264 in parallel. >> I see that those errors always occur after an iommu page fault: >> >> [gst-master] root@debian:~/gst-build# [ 5743.206014] mtk-iommu >> 10205000.iommu: fault type=0x5 iova=0xac2ff003 pa=0x0 larb=3 port=0 >> layer=1 write >> [ 5744.204964] [MTK_V4L2][ERROR] mtk_vcodec_wait_for_done_ctx:32: >> [2706] ctx->type=1, cmd=1, wait_event_interruptible_timeout >> time=1000ms out 0 0! >> [ 5744.217849] [MTK_VCODEC][ERROR][2706]: vp8_enc_encode_frame() >> irq_status=0 failed >> [ 5744.225359] [MTK_V4L2][ERROR] mtk_venc_worker:1243: venc_if_encode >> failed=-5 >> >> I suspect that maybe this is because the iova of the working_buffers >> is handed to the vpu in the function vp8_enc_alloc_work_buf: >> wb[i].iova = inst->work_bufs[i].dma_addr; >> >> Maybe the vpu keep writing to those addresses after they are already >> unmapped? >> >> Thanks, >> Dafna > > failed larb=3, it's for h264 encoder, vp8 encoder is larb5, is there > any h264 encoding failed at that time? I have no ideas why these errors > happened on your platform, but when we got the "iommu: fault", the > possible reason is related to power or clock. Once the iommu fault fires, both encoders constantly fail and never recover (also not when starting new instance). With the falut: mtk_iommu_isr: fault type=0x5 iova=0xebede003 pa=0x0 larb=3 port=0 layer=1 write I looked at the iommu tracing log: gst-launch-1.0-606 [000] ..... 714.634398: unmap: IOMMU: iova=0x00000000ebede000 - 0x00000000ebedf000 size=4096 unmapped_size=4096 gst-launch-1.0-606 [000] ..... 714.634417: unmap: IOMMU: iova=0x00000000ebed0000 - 0x00000000ebed5000 size=20480 unmapped_size=20480 gst-launch-1.0-606 [000] ..... 714.634435: unmap: IOMMU: iova=0x00000000eb800000 - 0x00000000ebb0a000 size=3186688 unmapped_size=3186688 gst-launch-1.0-606 [000] .N... 714.634891: unmap: IOMMU: iova=0x00000000eb700000 - 0x00000000eb7ff000 size=1044480 unmapped_size=1044480 gst-launch-1.0-606 [000] .N... 714.635481: unmap: IOMMU: iova=0x00000000eb000000 - 0x00000000eb30a000 size=3186688 unmapped_size=3186688 gst-launch-1.0-606 [000] ..... 714.635934: unmap: IOMMU: iova=0x00000000eaf00000 - 0x00000000eafff000 size=1044480 unmapped_size=1044480 gst-launch-1.0-606 [000] ..... 714.636041: unmap: IOMMU: iova=0x00000000eaef0000 - 0x00000000eaf00000 size=65536 unmapped_size=65536 gst-launch-1.0-606 [000] ..... 714.636056: unmap: IOMMU: iova=0x00000000eaee0000 - 0x00000000eaef0000 size=65536 unmapped_size=65536 gst-launch-1.0-606 [000] ..... 714.636069: unmap: IOMMU: iova=0x00000000eaedf000 - 0x00000000eaee0000 size=4096 unmapped_size=4096 kworker/0:0-537 [000] d.h.. 714.636191: io_page_fault: IOMMU:mtk-iommu 10205000.iommu iova=0x00000000ebede003 flags=0x0001 (I changed the iommu map/unmap trace events to print the iova range) you can see the first line unmapping 00000000ebede000 which is the faulting iova. So it seems that the problem is due to a device trying to access an address that is already unmapped. This might be either the encoder or the vpu. Since the wb[i].iova is not reset when freeing the working buffers I suspect it might be the vpu device, what do you think? Thanks, Dafna > >> >> >>> >>> >>>> >>>> MT8173 latest VPUD firmware: >>>> > https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmwar >>>> e.git/commit/?id=aaed4a8bf9a77ec68376e8d92fb218d5fdd88b59 >>>> >>> >>> I uses the latest firmware. >>> >>> Thanks, >>> Dafna >>> >>>> Thanks >>>> Best Regards >>>> >>>> -----邮件原件----- >>>> 发件人: Dafna Hirschfeld [mailto:dafna.hirschfeld@collabora.com] >>>> 发送时间: 2021年8月6日 15:49 >>>> 收件人: Irui Wang (王瑞); linux-kernel@vger.kernel.org; >>>> linux-media@vger.kernel.org; linux-mediatek@lists.infradead.org >>>> 抄送: dafna3@gmail.com; tfiga@chromium.org; Tiffany Lin (林慧珊); >>>> eizan@chromium.org; Maoguang Meng (孟毛广); kernel@collabora.com; >>>> mchehab@kernel.org; hverkuil@xs4all.nl; Yunfei Dong (董云飞); Yong >>>> Wu >>>> (吴勇); hsinyi@chromium.org; matthias.bgg@gmail.com; Andrew-CT Chen >>>> (陳智迪); acourbot@chromium.org >>>> 主题: Re: [PATCH 4/5] media: mtk-vcodec: Add two error cases upon >>>> vpu >>>> irq handling >>>> >>>> >>>> >>>> On 06.08.21 08:58, Irui Wang (王瑞) wrote: >>>>> On Wed, 2021-08-04 at 16:27 +0200, Dafna Hirschfeld wrote: >>>>>> 1. Fail if the function mtk_vcodec_fw_map_dm_addr returns ERR >>>>>> pointer. >>>>>> 2. Fail if the state from the vpu msg is either >>>>>> VEN_IPI_MSG_ENC_STATE_ERROR or VEN_IPI_MSG_ENC_STATE_PART >>>>>> >>>>>> Signed-off-by: Dafna Hirschfeld < >>>>>> dafna.hirschfeld@collabora.com> >>>>>> --- >>>>>> drivers/media/platform/mtk-vcodec/venc_vpu_if.c | 8 >>>>>> ++++++++ >>>>>> 1 file changed, 8 insertions(+) >>>>>> >>>>>> diff --git a/drivers/media/platform/mtk-vcodec/venc_vpu_if.c >>>>>> b/drivers/media/platform/mtk-vcodec/venc_vpu_if.c >>>>>> index 32dc844d16f9..234705ba7cd6 100644 >>>>>> --- a/drivers/media/platform/mtk-vcodec/venc_vpu_if.c >>>>>> +++ b/drivers/media/platform/mtk-vcodec/venc_vpu_if.c >>>>>> @@ -17,6 +17,8 @@ static int handle_enc_init_msg(struct >>>>>> venc_vpu_inst *vpu, const void *data) >>>>>> vpu->vsi = mtk_vcodec_fw_map_dm_addr(vpu->ctx->dev- >>>>>>> fw_handler, >>>>>> msg->vpu_inst_addr); >>>>>> >>>>>> +if (IS_ERR(vpu->vsi)) >>>>>> +return PTR_ERR(vpu->vsi); >>>>>> /* Firmware version field value is unspecified on MT8173. >>>>>> */ >>>>>> if (vpu->ctx->dev->venc_pdata->chip == MTK_MT8173) >>>>>> return 0; >>>>>> @@ -42,6 +44,12 @@ static int handle_enc_encode_msg(struct >>>>>> venc_vpu_inst *vpu, const void *data) >>>>>> vpu->state = msg->state; >>>>>> vpu->bs_size = msg->bs_size; >>>>>> vpu->is_key_frm = msg->is_key_frm; >>>>>> +if (vpu->state == VEN_IPI_MSG_ENC_STATE_ERROR || >>>>>> + vpu->state == VEN_IPI_MSG_ENC_STATE_PART) { >>>>>> mtk_vcodec_err(vpu, >>>>>> +"bad ipi-enc-state: %s", >>>>>> + vpu->state == >>>>>> VEN_IPI_MSG_ENC_STATE_ERROR ? "ERR" : "PART"); >>>>>> +return -EINVAL; >>>>>> +} >>>>> >>>>> Hi Dafna, >>>>> >>>>> This state check is useless, the enc result will check in >>>>> "vpu_enc_ipi_handler". >>>>> >>>> >>>> Hi, thanks for reviewing. I see that the vpu_enc_ipi_handler only >>>> test the msg->status and I see that the states are not tested >>>> anywhere except of "skip" state in the h264 enc. >>>> >>>> Can't there be a scenario where msg->status is ok but the state >>>> is error? >>>> I am testing the vp8 encoder on chromeos and at some point the >>>> encoder interrupts stop arriving so I try to figure out why and >>>> report any possible error. >>>> >>>> Thanks, >>>> Dafna >>>> >>>>> Thanks >>>>> >>>>>> return 0; >>>>>> } >>>>>> >>>> >>>> ************* MEDIATEK Confidentiality Notice >>>> ******************** The >>>> information contained in this e-mail message (including any >>>> attachments) may be confidential, proprietary, privileged, or >>>> otherwise exempt from disclosure under applicable laws. It is >>>> intended >>>> to be conveyed only to the designated recipient(s). Any use, >>>> dissemination, distribution, printing, retaining or copying of >>>> this >>>> e-mail (including its >>>> attachments) by unintended recipient(s) is strictly prohibited >>>> and may >>>> be unlawful. If you are not an intended recipient of this e-mail, >>>> or >>>> believe that you have received this e-mail in error, please >>>> notify the >>>> sender immediately (by replying to this e-mail), delete any and >>>> all >>>> copies of this e-mail (including any attachments) from your >>>> system, >>>> and do not disclose the content of this e-mail to any other >>>> person. Thank you! >>>> > _______________________________________________ > Linux-mediatek mailing list > Linux-mediatek@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-mediatek >