From: "Li,Rongqing" <lirongqing@baidu.com>
To: Pranjal Shrivastava <praan@google.com>
Cc: "joro@8bytes.org" <joro@8bytes.org>,
"will@kernel.org" <will@kernel.org>,
"robin.murphy@arm.com" <robin.murphy@arm.com>,
"iommu@lists.linux.dev" <iommu@lists.linux.dev>
Subject: 答复: [????] Re: [PATCH] iommu: Downgrade print level for iommu group information
Date: Tue, 26 Nov 2024 10:47:17 +0000 [thread overview]
Message-ID: <2d41f35db0794b1fbe20a51ccd35e2a9@baidu.com> (raw)
In-Reply-To: <Z0WiC4lWxFdY-_JO@google.com>
> > trace_add_device_to_group(group->id, dev);
> >
> > - dev_info(dev, "Adding to iommu group %d\n", group->id);
> > + dev_dbg(dev, "Adding to iommu group %d\n", group->id);
>
> I'm not sure the original reason behind this `dev_info` but of late I've seen
> people/scripts use this log to find the iommu_group for a device to later set the
> default domain via /sys/kernel/iommu_groups/<grp_id>/type
>
> That said with this change, those scripts should still be able to find the
> iommu_group via /sys/bus/<bus_type>/devices/<device>/iommu_group
> Maybe adding this info to the commit message will help them?
>
Thanks, I will send v2
-Li
> >
> > return device;
> >
> > --
> > 2.9.4
> >
> >
>
> Thanks,
> Praan
next prev parent reply other threads:[~2024-11-26 11:23 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-26 7:23 [PATCH] iommu: Downgrade print level for iommu group information Li RongQing
2024-11-26 10:25 ` Pranjal Shrivastava
2024-11-26 10:47 ` Li,Rongqing [this message]
2024-11-26 11:49 ` Robin Murphy
2024-11-26 12:09 ` 答复: [外部邮件] " Li,Rongqing
2024-11-27 10:16 ` Pranjal Shrivastava
2024-11-27 11:32 ` 答复: " Li,Rongqing
2024-11-29 8:21 ` Li,Rongqing
2024-11-27 12:37 ` Robin Murphy
2024-11-27 20:56 ` Pranjal Shrivastava
2024-11-27 12:12 ` Robin Murphy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2d41f35db0794b1fbe20a51ccd35e2a9@baidu.com \
--to=lirongqing@baidu.com \
--cc=iommu@lists.linux.dev \
--cc=joro@8bytes.org \
--cc=praan@google.com \
--cc=robin.murphy@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.