From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Price Date: Fri, 19 Jan 2018 22:23:27 +0000 Subject: [Cluster-devel] [PATCH v5 2/3] GFS2: Introduce new gfs2_log_header_v2 In-Reply-To: <849d5940-dd06-b528-4195-e7d1eeeb1b76@redhat.com> References: <20180118160445.12732-1-agruenba@redhat.com> <20180118160445.12732-3-agruenba@redhat.com> <849d5940-dd06-b528-4195-e7d1eeeb1b76@redhat.com> Message-ID: <2d855469-7b88-059f-1938-4e1496ca2f32@redhat.com> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On 19/01/18 20:06, Andrew Price wrote: > On 19/01/18 14:31, Andrew Price wrote:> I've pushed a gfs2-utils patch > with basic support for the new log header >> format to the andyp-lhv2 branch. I need to test it some more but it >> should be useful for testing these patches already. I'll finalise it >> once the v2 patches are in for-next. > > So the gfs2-utils patch is completely broken in that it isn't using > crc32c for lh_crc. I'm looking into finding a userspace crc32c > implementation now. I have pushed a new version of the patch to the andyp-lhv2 branch of gfs2-utils. It includes a crc32c implementation that originated in the kernel and was brought to user-space in btrfs-progs. It uses hardware support if it can. The patch also uses fiemap in gfs2_jadd to set lh_addr, as Andreas suggested. Cheers, Andy