All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Niedermaier <cniedermaier@dh-electronics.com>
To: "Tobias Jakobi (Compleo)" <tobias.jakobi.compleo@gmail.com>
Cc: "Rickard.Andersson@axis.com" <Rickard.Andersson@axis.com>,
	"festevam@denx.de" <festevam@denx.de>,
	"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
	"ilpo.jarvinen@linux.intel.com" <ilpo.jarvinen@linux.intel.com>,
	"jirislaby@kernel.org" <jirislaby@kernel.org>,
	"kernel@pengutronix.de" <kernel@pengutronix.de>,
	"linux-imx@nxp.com" <linux-imx@nxp.com>,
	"linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>,
	"lukas@wunner.de" <lukas@wunner.de>,
	"marex@denx.de" <marex@denx.de>,
	"rickard314.andersson@gmail.com" <rickard314.andersson@gmail.com>,
	"robh@kernel.org" <robh@kernel.org>,
	"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
	"shawnguo@kernel.org" <shawnguo@kernel.org>,
	"sorganov@gmail.com" <sorganov@gmail.com>,
	"tglx@linutronix.de" <tglx@linutronix.de>,
	"trix@redhat.com" <trix@redhat.com>,
	"u.kleine-koenig@pengutronix.de" <u.kleine-koenig@pengutronix.de>
Subject: RE: [RFC][PATCH] serial: imx: Fix RS485 behaviour on disabled RX_DURING_TX
Date: Thu, 7 Mar 2024 12:38:03 +0000	[thread overview]
Message-ID: <2d92d69369054578baacccf23ae2eff1@dh-electronics.com> (raw)
In-Reply-To: <3a2987d4-ca89-4f4b-9f01-ee19a01c1b6b@gmail.com>

From: Tobias Jakobi (Compleo) <tobias.jakobi.compleo@gmail.com>
Sent: Thursday, March 7, 2024 12:07 PM
> 
> Hello,
> 
> I also noticed last year that RS485 was problematic on i.MX hardware. We
> use a i.MX7 SoC located on a SoM by manufacturer Toradex. The SoM itself
> is plugged into a proprietary board that features a Renesas ISL8xxx
> RS485 transceiver. We talk ModBus RTU over the RS485 link. The SoC is
> the ModBus master, the slave is a insulation monitoring device.
> 
> Since we source the i.MX through Toradex, I opened a thread on their
> community forum last year:
> https://community.toradex.com/t/fixing-native-rs485-de-toggling-on-uart6/20573
> 
> I also realized very quickly that the newly introduced loopback logic
> was the culprit. My solution currently consists of a new DT property
> that effectively disables the toggling of the loopback mode:
> https://gitlab.freedesktop.org/tobiasjakobi.compleo/linux-toradex/-
> /commit/98397c9436f48a149e2da0b2969a2d1d2d88c611
> 
> Anyway, I have tested Christoph's patch and can confirm that the patch
> (also) fixes the problems we are seeing. Test was done by applying the
> patch to 6.1.80. I haven't tested Rickard's patch so far.
> 
> Would be nice if this could later be backported to the 6.1.x kernel
> (this is the kernel we currently use on our hardware).

Rickard's patch in version 3 solved the same problem, so it should also
fix the problem on your side. It has already been accepted and is already
available in the next Kernel. It has a Fixes tag on it, so it should normally
be backported to the 6.1.x Kernel soon.

Regards
Christo1ph

  reply	other threads:[~2024-03-07 12:49 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-20  6:12 [PATCH v2] tty: serial: imx: Fix broken RS485 Rickard Andersson
2024-02-20  6:53 ` Marek Vasut
2024-02-20  6:53 ` Greg KH
2024-02-20  6:53 ` Greg KH
2024-02-20  9:55 ` [RFC][PATCH] serial: imx: Fix RS485 behaviour on disabled RX_DURING_TX Christoph Niedermaier
2024-02-20 10:57   ` Christoph Niedermaier
2024-03-07 11:07     ` Tobias Jakobi (Compleo)
2024-03-07 12:38       ` Christoph Niedermaier [this message]
2024-03-07 14:10         ` Tobias Jakobi (Compleo)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2d92d69369054578baacccf23ae2eff1@dh-electronics.com \
    --to=cniedermaier@dh-electronics.com \
    --cc=Rickard.Andersson@axis.com \
    --cc=festevam@denx.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=jirislaby@kernel.org \
    --cc=kernel@pengutronix.de \
    --cc=linux-imx@nxp.com \
    --cc=linux-serial@vger.kernel.org \
    --cc=lukas@wunner.de \
    --cc=marex@denx.de \
    --cc=rickard314.andersson@gmail.com \
    --cc=robh@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    --cc=sorganov@gmail.com \
    --cc=tglx@linutronix.de \
    --cc=tobias.jakobi.compleo@gmail.com \
    --cc=trix@redhat.com \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.