Re: [PATCH v4 0/1] environment: move protect_hfs and protect_ntfs into repo_config_values

[Tian Yuchen <cat@malon.dev>]

On 6/20/26 01:25, Junio C Hamano wrote:
> Junio C Hamano <gitster@pobox.com> writes:
> 
>> diff --git c/environment.h w/environment.h
>> index fdd9775900..b1ae4a70de 100644
>> --- c/environment.h
>> +++ w/environment.h
>> @@ -127,8 +127,8 @@ int git_default_core_config(const char *var, const char *value,
>>   
>>   /*
>>    * Getters for the `protect_hfs` and `protect_ntfs` fields of `struct repo_config_values`.
>> - * They check `repo->gitdir` to prevent calling repo_config_values()
>> - * before the configuration is loaded or in bare environments.
>> + * They check `repo->initialized` to prevent calling `repo_config_values()`
>> + * before the repository setup is fully complete or in non-git environments.
>>    */
>>   int repo_protect_hfs(struct repository *repo);
>>   int repo_protect_ntfs(struct repository *repo);
> 
> Another thing we should remember (but should *NOT* do while these
> topics are still in flight) to do is to consolidate these comments
> into one.  The hfs and htfs getters are covered by the same single
> comment, but ignorecase and trustexecutable bit getters have their
> own comments, only because they came in different topics.  We should
> conslidate them into a single comment block once all of these have
> landed in 'master', which may happen soon after 2.55 final gets
> tagged.
> 

I understand. I’ll send the hfs/ntfs fix patch right away, and will 
clean up the comments once all of the associated patches (there will be 
more in the next few weeks) have been merged into master. ;)

Thanks, yuchen