From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7BCB7C433E2 for ; Wed, 9 Sep 2020 00:17:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 14F132145D for ; Wed, 9 Sep 2020 00:17:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="VM718ikC" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728347AbgIIARA (ORCPT ); Tue, 8 Sep 2020 20:17:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47816 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726560AbgIIAQ6 (ORCPT ); Tue, 8 Sep 2020 20:16:58 -0400 Received: from mail-lj1-x243.google.com (mail-lj1-x243.google.com [IPv6:2a00:1450:4864:20::243]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D0E66C061573 for ; Tue, 8 Sep 2020 17:16:57 -0700 (PDT) Received: by mail-lj1-x243.google.com with SMTP id a22so1145732ljp.13 for ; Tue, 08 Sep 2020 17:16:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=aHaTSi7fSnGjwBOLQtAuiJEEe/fNGCKc8u+ZcHPxdgQ=; b=VM718ikC74EnEAa0HMMO5cWelvhb7XMsshvb+ff2pAt3J9JVEfx0E0CMgTDj5XKe8b q90oJr8RNeXDEm4sDX8LORWCSmbKOpQq1vKlVAmWUg7AAUJcSZ79fSddpkakPhU5HZzl PSeSbEo0rcY++RKYh1MSTyu3mjPeckkvLf4p0a0r8dgwrpN4qY8SqjUqCQazOaLqPfrr GwxgEKmbAQ/pkYid6l9VWOuNUjqhkxS+DZbjJV65tvgnROR+CKlsUw/J4H2no3wYiieh TlRTKeElG0wd1LICaDEBAoVbx6MxSrVdGV+lQhcWWZCAtkAgw2mCyZkDqsyvjGPmVegZ jE7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=aHaTSi7fSnGjwBOLQtAuiJEEe/fNGCKc8u+ZcHPxdgQ=; b=SSsjDJpyY33DsEgSeh7e+6GP4WY9c3kyEX8ZNdhCyhl1ZYgz6ISlUjpsSd2YhTSDZ3 7Mipu7nzFSC7grX7y4ochere3D5WHqW0SbB4mFZYBzZp2FhlIAAAXn0pnzqXIeE2UouQ SJUjuNaq3uudDi7bMH7J9MTPoG7lADsDI8QzjeNB4zgnGqnG0ehaaxt01X+PSJyxAoKK ltONDovmYefgbFSV67ioXBQZeVXKZhRCP9fTzWFIo9fr4HQPkPjj3qe220t8slZKD6qe uEmw7ksnSS6YlFz8SCGAnC3RKGgk8KafeOdCID8WzmWHeM+9R2zgTdne4ONHUj3YBPxS Errw== X-Gm-Message-State: AOAM5312MIO18Y8MYme8LkwjGh3PNYA816eMuPrJ08uXGjcqGC0ADF4I 4YfYrFAseM5qFuTGScjb95s= X-Google-Smtp-Source: ABdhPJxMOArydBWMtC63OEwp6cR1nWEkqOX8GOpDv1Sq+yxTNcb+69met/SHeMsuzTx1FZ+aBWIYEg== X-Received: by 2002:a05:651c:1352:: with SMTP id j18mr459685ljb.343.1599610616363; Tue, 08 Sep 2020 17:16:56 -0700 (PDT) Received: from [192.168.2.145] (109-252-170-211.dynamic.spd-mgts.ru. [109.252.170.211]) by smtp.googlemail.com with ESMTPSA id e17sm303594ljg.85.2020.09.08.17.16.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 08 Sep 2020 17:16:55 -0700 (PDT) Subject: Re: [RFC PATCH v2 15/17] drm/tegra: Add power_on/power_off engine callbacks To: Mikko Perttunen , thierry.reding@gmail.com, jonathanh@nvidia.com, airlied@linux.ie, daniel@ffwll.ch Cc: linux-tegra@vger.kernel.org, dri-devel@lists.freedesktop.org, talho@nvidia.com, bhuntsman@nvidia.com References: <20200905103420.3021852-1-mperttunen@nvidia.com> <20200905103420.3021852-16-mperttunen@nvidia.com> From: Dmitry Osipenko Message-ID: <2ddaf2ef-e232-7d44-0b08-e190f20297b2@gmail.com> Date: Wed, 9 Sep 2020 03:16:55 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200905103420.3021852-16-mperttunen@nvidia.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-tegra-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-tegra@vger.kernel.org 05.09.2020 13:34, Mikko Perttunen пишет: ... > +static int vic_power_on(struct tegra_drm_client *client) > +{ > + struct vic *vic = to_vic(client); > + > + return pm_runtime_get_sync(vic->dev); Please keep in mind that RPM needs to be put in a case of error. Maybe it would be better if driver-core could take care of resuming/suspending client's RPM instead of putting that burden on each client individually? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10F0FC43461 for ; Wed, 9 Sep 2020 07:05:11 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BBF8C21741 for ; Wed, 9 Sep 2020 07:05:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="VM718ikC" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BBF8C21741 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 06E0B6E9E1; Wed, 9 Sep 2020 07:04:36 +0000 (UTC) Received: from mail-lj1-x243.google.com (mail-lj1-x243.google.com [IPv6:2a00:1450:4864:20::243]) by gabe.freedesktop.org (Postfix) with ESMTPS id DF5F76E8C3 for ; Wed, 9 Sep 2020 00:16:57 +0000 (UTC) Received: by mail-lj1-x243.google.com with SMTP id a15so1220153ljk.2 for ; Tue, 08 Sep 2020 17:16:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=aHaTSi7fSnGjwBOLQtAuiJEEe/fNGCKc8u+ZcHPxdgQ=; b=VM718ikC74EnEAa0HMMO5cWelvhb7XMsshvb+ff2pAt3J9JVEfx0E0CMgTDj5XKe8b q90oJr8RNeXDEm4sDX8LORWCSmbKOpQq1vKlVAmWUg7AAUJcSZ79fSddpkakPhU5HZzl PSeSbEo0rcY++RKYh1MSTyu3mjPeckkvLf4p0a0r8dgwrpN4qY8SqjUqCQazOaLqPfrr GwxgEKmbAQ/pkYid6l9VWOuNUjqhkxS+DZbjJV65tvgnROR+CKlsUw/J4H2no3wYiieh TlRTKeElG0wd1LICaDEBAoVbx6MxSrVdGV+lQhcWWZCAtkAgw2mCyZkDqsyvjGPmVegZ jE7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=aHaTSi7fSnGjwBOLQtAuiJEEe/fNGCKc8u+ZcHPxdgQ=; b=Rj0EzPBFojNcdddeu90oGB3ug27dXr3CE07Ht/xqFVArhmRbwf4kqze3ht6ZVV9zVr IeiSBtPHPH0rQnBqQTkUgtACNhH8kt/EsT2UmOAUtesPIJBSzx+8z6+vkognZUgU9MU0 GRKD1jrwhQ3PYMGCJvJucmN0Sb/AhSzQ++rihkDhtIrHfxeStjUwwJhtKdGA5HvfZ5fm OFaM6nh9pjgsXM6ISTYt3h7arfzmhZXnjRIiygEHzBMjls3S7spukhEvi4tHA4efHP2K 7DM2FuXYgQC6mRG2wnW9zgQvs5hRUgKRVsCDro8fGJOwpJq7m11hdII3SXFncX4GsY/b E1lg== X-Gm-Message-State: AOAM5326KeOzV9TxXr8eGKjEA3kteD76cHeqqDise/C9OwrXQwF+WQhJ 6TXLsJ8tYULdPYPJmSeFf7U= X-Google-Smtp-Source: ABdhPJxMOArydBWMtC63OEwp6cR1nWEkqOX8GOpDv1Sq+yxTNcb+69met/SHeMsuzTx1FZ+aBWIYEg== X-Received: by 2002:a05:651c:1352:: with SMTP id j18mr459685ljb.343.1599610616363; Tue, 08 Sep 2020 17:16:56 -0700 (PDT) Received: from [192.168.2.145] (109-252-170-211.dynamic.spd-mgts.ru. [109.252.170.211]) by smtp.googlemail.com with ESMTPSA id e17sm303594ljg.85.2020.09.08.17.16.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 08 Sep 2020 17:16:55 -0700 (PDT) Subject: Re: [RFC PATCH v2 15/17] drm/tegra: Add power_on/power_off engine callbacks To: Mikko Perttunen , thierry.reding@gmail.com, jonathanh@nvidia.com, airlied@linux.ie, daniel@ffwll.ch References: <20200905103420.3021852-1-mperttunen@nvidia.com> <20200905103420.3021852-16-mperttunen@nvidia.com> From: Dmitry Osipenko Message-ID: <2ddaf2ef-e232-7d44-0b08-e190f20297b2@gmail.com> Date: Wed, 9 Sep 2020 03:16:55 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200905103420.3021852-16-mperttunen@nvidia.com> Content-Language: en-US X-Mailman-Approved-At: Wed, 09 Sep 2020 07:04:23 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-tegra@vger.kernel.org, talho@nvidia.com, bhuntsman@nvidia.com, dri-devel@lists.freedesktop.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" MDUuMDkuMjAyMCAxMzozNCwgTWlra28gUGVydHR1bmVuINC/0LjRiNC10YI6Ci4uLgo+ICtzdGF0 aWMgaW50IHZpY19wb3dlcl9vbihzdHJ1Y3QgdGVncmFfZHJtX2NsaWVudCAqY2xpZW50KQo+ICt7 Cj4gKwlzdHJ1Y3QgdmljICp2aWMgPSB0b192aWMoY2xpZW50KTsKPiArCj4gKwlyZXR1cm4gcG1f cnVudGltZV9nZXRfc3luYyh2aWMtPmRldik7CgpQbGVhc2Uga2VlcCBpbiBtaW5kIHRoYXQgUlBN IG5lZWRzIHRvIGJlIHB1dCBpbiBhIGNhc2Ugb2YgZXJyb3IuCgpNYXliZSBpdCB3b3VsZCBiZSBi ZXR0ZXIgaWYgZHJpdmVyLWNvcmUgY291bGQgdGFrZSBjYXJlIG9mCnJlc3VtaW5nL3N1c3BlbmRp bmcgY2xpZW50J3MgUlBNIGluc3RlYWQgb2YgcHV0dGluZyB0aGF0IGJ1cmRlbiBvbiBlYWNoCmNs aWVudCBpbmRpdmlkdWFsbHk/Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNr dG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2Ry aS1kZXZlbAo=