Re: [PATCH mptcp-next 0/4] mptcp: pm: netlink: announce server-side flag

[Geliang Tang <geliang@kernel.org>]

Hi Matt,

Thanks for this new patchset. It looks good to me overall. I have two
comments in patch 1 and patch 4.

-Geliang

On Tue, 2025-09-09 at 18:30 +0200, Matthieu Baerts (NGI0) wrote:
> Now that the 'flags' attribute is used, it seems interesting to add
> one
> flag for 'server-side', a boolean value.
> 
> Here are a few patches related to the 'server-side' attribute:
> 
> - Patch 1: only announce this attribute on the server side.
> 
> - Patch 2: announce the 'server-side' flag when this is the case.
> 
> - Patch 3: deprecate the 'server-side' attribute.
> 
> - Patch 4: use the 'server-side' flag in the selftests.
> 
> Based-on:
> <20250909-mptcp-pm-user-c-flag-v2-0-a6f9542481c5@kernel.org>
> 
> Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
> ---
> Matthieu Baerts (NGI0) (4):
>       mptcp: pm: netlink: only add server-side attr when true
>       mptcp: pm: netlink: announce server-side flag
>       mptcp: pm: netlink: deprecate server-side attribute
>       selftests: mptcp: pm: get server-side flag
> 
>  Documentation/netlink/specs/mptcp_pm.yaml         | 5 +++--
>  include/uapi/linux/mptcp.h                        | 1 +
>  include/uapi/linux/mptcp_pm.h                     | 4 ++--
>  net/mptcp/pm_netlink.c                            | 9 +++++++--
>  tools/testing/selftests/net/mptcp/pm_nl_ctl.c     | 9 ++++++++-
>  tools/testing/selftests/net/mptcp/userspace_pm.sh | 2 +-
>  6 files changed, 22 insertions(+), 8 deletions(-)
> ---
> base-commit: 12e66f7051b4b535a990cd20c149d76a98ec68c3
> change-id: 20250909-mptcp-pm-user-server-side-flag-214c84b90b21
> prerequisite-change-id: 20250720-mptcp-pm-user-c-flag-a7d5d7a00c6f:v2
> prerequisite-patch-id: cc65204dc8620f1675f8b8cbdf6dc0fecf20379e
> prerequisite-patch-id: 88640c51fc66f4d630e2f99db72c18830273fc83
> prerequisite-patch-id: 5773e6ceede07a2c43550774eddad1c32cde67e0
> prerequisite-patch-id: f9196f35eff69835799db4312e82c795f1b15eb0
> prerequisite-patch-id: 8ec26f3fe4baa5128ac2f01f7284184bbb0e651b
> 
> Best regards,