All of lore.kernel.org
 help / color / mirror / Atom feed
From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Milosz Wasilewski <milosz.wasilewski@oss.qualcomm.com>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: qcom: monaco: add PMIC PON with power key
Date: Tue, 18 Aug 2026 15:02:38 +0200	[thread overview]
Message-ID: <2deee675-e82b-4822-a43d-4264ca8cd512@oss.qualcomm.com> (raw)
In-Reply-To: <20260814152610.2039318-1-milosz.wasilewski@oss.qualcomm.com>

On 8/14/26 5:26 PM, Milosz Wasilewski wrote:
> Monaco has no PMIC PON node, so the power key is not described at all
> and there is no pwrkey input device.  More importantly the board then
> has no power-key wakeup source: the only way out of s2idle is the RTC
> alarm or one of the PCIe/USB/remoteproc sources, and pressing the power
> button does nothing.
> 
> Add the PON node with the power key, modelled on the pmm8654au PON on
> lemans, which carries the same PMIC: the block lives at 0x1200 and its
> interrupts are on block 0x12.
> 
> qcom,pmk8350-pwrkey has wakeup_source_default set, so the driver arms
> the IRQ as a wakeup source without any additional DT property.
> 
> On an IQ-8275-EVK this gives a pmic_pwrkey input device under
> c440000.spmi:pmic@0:pon@1200, and:
> 
>   # grep pwrkey /sys/kernel/debug/wakeup_sources
>   c440000.spmi:pmic@0:pon@1200:pwrkey
> 
> "systemctl suspend" followed by a power-key press now resumes the board,
> where before it stayed in s2idle until an RTC alarm fired.
> 
> Assisted-by: Claude:claude-opus-5
> Signed-off-by: Milosz Wasilewski <milosz.wasilewski@oss.qualcomm.com>
> ---

There's a parallel effort:

https://lore.kernel.org/linux-arm-msm/20260724-b4-add_pwrkey_and_resin-v6-0-41acc214d93a@oss.qualcomm.com/

Konrad

  reply	other threads:[~2026-08-18 13:02 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-14 15:26 [PATCH] arm64: dts: qcom: monaco: add PMIC PON with power key Milosz Wasilewski
2026-08-18 13:02 ` Konrad Dybcio [this message]
2026-08-18 15:28   ` Milosz Wasilewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2deee675-e82b-4822-a43d-4264ca8cd512@oss.qualcomm.com \
    --to=konrad.dybcio@oss.qualcomm.com \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=milosz.wasilewski@oss.qualcomm.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.