All of lore.kernel.org
 help / color / mirror / Atom feed
From: corubba <corubba@gmx.de>
To: netfilter-devel@vger.kernel.org
Subject: [PATCH ulogd2 2/3] gprint: fix comma after ip addresses
Date: Sat, 8 Feb 2025 14:49:49 +0100	[thread overview]
Message-ID: <2e047e50-e689-4fbb-ae58-bc522a758e40@gmx.de> (raw)
In-Reply-To: <0a983b51-9a51-47a7-bbdc-9bf163a88bbd@gmx.de>

Gone missing in f04bf679.

Signed-off-by: Corubba Smith <corubba@gmx.de>
---
 output/ulogd_output_GPRINT.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/output/ulogd_output_GPRINT.c b/output/ulogd_output_GPRINT.c
index 37829fa..d95ca9d 100644
--- a/output/ulogd_output_GPRINT.c
+++ b/output/ulogd_output_GPRINT.c
@@ -179,9 +179,15 @@ static int gprint_interp(struct ulogd_pluginstance *upi)
 			if (!inet_ntop(family, addr, buf + size, rem))
 				break;
 			ret = strlen(buf + size);
+			rem -= ret;
+			size += ret;

+			ret = snprintf(buf+size, rem, ",");
+			if (ret < 0)
+				break;
 			rem -= ret;
 			size += ret;
+
 			break;
 		}
 		default:
--
2.48.1


  parent reply	other threads:[~2025-02-08 13:49 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-08 13:46 [PATCH ulogd2 0/3] Three small bugfixes corubba
2025-02-08 13:48 ` [PATCH ulogd2 1/3] nfct: add newline to reliable log message corubba
2025-02-08 13:49 ` corubba [this message]
2025-02-08 21:20   ` [PATCH ulogd2 2/3] gprint: fix comma after ip addresses Pablo Neira Ayuso
2025-02-08 21:30     ` corubba
2025-02-08 21:57       ` Pablo Neira Ayuso
2025-02-08 21:34     ` Jeremy Sowden
2025-02-08 21:48   ` Jeremy Sowden
2025-02-08 13:51 ` [PATCH ulogd2 3/3] ipfix: re-arm send timer corubba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2e047e50-e689-4fbb-ae58-bc522a758e40@gmx.de \
    --to=corubba@gmx.de \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.