Re: [PATCH next] drm/amdkfd: Fix kfd_smi_event_process()

[Eric Huang <jinhuieric.huang@amd.com>]

Thanks for the fix, I had the same patch submitted yesterday.

Regards,
Eric

On 2025-04-15 06:44, Dan Carpenter wrote:
> The "pdd->drm_priv" NULL check is reversed so it will lead to a NULL
> dereference on the next line.
>
> Fixes: 4172b556fd5b ("drm/amdkfd: add smi events for process start and end")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
> ---
>   drivers/gpu/drm/amd/amdkfd/kfd_smi_events.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_smi_events.c b/drivers/gpu/drm/amd/amdkfd/kfd_smi_events.c
> index 727a4ce29fe6..c27fd7aec1c3 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_smi_events.c
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_smi_events.c
> @@ -350,7 +350,7 @@ void kfd_smi_event_process(struct kfd_process_device *pdd, bool start)
>   	struct amdgpu_task_info *task_info;
>   	struct amdgpu_vm *avm;
>   
> -	if (pdd->drm_priv)
> +	if (!pdd->drm_priv)
>   		return;
>   
>   	avm = drm_priv_to_vm(pdd->drm_priv);