All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jiri Slaby <jirislaby@kernel.org>
To: Xin Chen <xin.chen2@oss.qualcomm.com>, gregkh@linuxfoundation.org
Cc: linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
	stable@vger.kernel.org, liulzhao@qti.qualcomm.com,
	cheng.jiang@oss.qualcomm.com, cxin@qti.qualcomm.com
Subject: Re: [PATCH v2] tty: n_tty: use kvzalloc/kvfree for line discipline data
Date: Tue, 18 Aug 2026 09:15:25 +0200	[thread overview]
Message-ID: <2e072c67-9d42-409a-8c24-82e88dd01418@kernel.org> (raw)
In-Reply-To: <20260818070324.136726-1-xin.chen2@oss.qualcomm.com>

On 18. 08. 26, 9:03, Xin Chen wrote:
> Replace vzalloc/vfree with kvzalloc_obj/kvfree.  kvzalloc_obj() tries
> kmalloc first and falls back to vmalloc only on failure.  The
> ~10 KB n_tty_data is served from the kmalloc-16384 slab (backed
> by an order-2 compound page), leaving the order-0 free list intact
> for the subsequent skb_clone() calls.

Switching from order-0 to order-2? If you ran out of vmspace on some 
32bit platform, perhaps. But you apparently did not. So all this feels odd.

NACK

thanks,
-- 
js
suse labs

  reply	other threads:[~2026-08-18  7:15 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-17 13:55 [PATCH v1] tty: n_tty: use kvzalloc/kvfree for line discipline data Xin Chen
2026-08-17 14:14 ` Greg KH
2026-08-18  3:09   ` Xin Chen
2026-08-18  6:05     ` Greg KH
2026-08-18  6:22       ` Xin Chen
2026-08-17 14:16 ` Greg KH
2026-08-17 14:49   ` Greg KH
2026-08-18  6:02     ` Xin Chen
2026-08-18  6:34       ` Greg KH
2026-08-18  6:58         ` Xin Chen
2026-08-18  7:34           ` Greg KH
2026-08-18  3:31   ` Xin Chen
2026-08-18  6:07     ` Greg KH
2026-08-18  6:39       ` Xin Chen
2026-08-18  7:03 ` [PATCH v2] " Xin Chen
2026-08-18  7:15   ` Jiri Slaby [this message]
2026-08-18  7:23     ` Xin Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2e072c67-9d42-409a-8c24-82e88dd01418@kernel.org \
    --to=jirislaby@kernel.org \
    --cc=cheng.jiang@oss.qualcomm.com \
    --cc=cxin@qti.qualcomm.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=liulzhao@qti.qualcomm.com \
    --cc=stable@vger.kernel.org \
    --cc=xin.chen2@oss.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.