From: Krzysztof Kozlowski <krzk@kernel.org>
To: Larisa Ileana Grigore <larisa.grigore@oss.nxp.com>, Frank.Li@nxp.com
Cc: dmaengine@vger.kernel.org, imx@lists.linux.dev,
linux-kernel@vger.kernel.org, s32@nxp.com,
Christophe Lizzi <clizzi@redhat.com>,
Alberto Ruiz <aruizrui@redhat.com>,
Enric Balletbo <eballetb@redhat.com>
Subject: Re: [PATCH 7/8] dmaengine: fsl-edma: wait until no hardware request is in progress
Date: Tue, 17 Dec 2024 16:27:09 +0100 [thread overview]
Message-ID: <2e0e1fe3-af5e-4416-8b34-3fecb923b481@kernel.org> (raw)
In-Reply-To: <d5badfcf-58d7-49d4-8a5a-d31de498f015@oss.nxp.com>
On 17/12/2024 15:19, Larisa Ileana Grigore wrote:
> On 12/17/2024 7:27 AM, Krzysztof Kozlowski wrote:
>> [You don't often get email from krzk@kernel.org. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
>>
>> On 16/12/2024 08:58, Larisa Grigore wrote:
>>> Wait DMA hardware complete cleanup work by checking HRS bit before
>>> disabling the channel to make sure trail data is already written to
>>> memory.
>>>
>>> Fixes: 72f5801a4e2b7 ("dmaengine: fsl-edma: integrate v3 support")
>>
>> Why Fixes are at the end of the patchset? They must be either separate
>> patchset or first patches.
>>
>> Best regards,
>> Krzysztof
>
> Thank you for you review Krzysztof! Indeed, this commit should be moved
> right after "dmaengine: fsl-edma: add eDMAv3 registers to edma_regs"
I don't understand this. Are you saying you introduce bug in one patch
and fix in other? Why this cannot be separate patchset?
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-12-17 15:27 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-16 7:58 [PATCH 0/8] Add eDMAv3 support for S32G2/S32G3 SoCs Larisa Grigore
2024-12-16 7:58 ` [PATCH 1/8] dmaengine: fsl-edma: select of_dma_xlate based on the dmamuxs presence Larisa Grigore
2024-12-16 16:16 ` Frank Li
2024-12-17 14:28 ` Larisa Ileana Grigore
2024-12-16 7:58 ` [PATCH 2/8] dmaengine: fsl-edma: remove FSL_EDMA_DRV_SPLIT_REG check when parsing muxbase Larisa Grigore
2024-12-16 16:17 ` Frank Li
2024-12-16 7:58 ` [PATCH 3/8] dmaengine: fsl-edma: move eDMAv2 related registers to a new structure ’edma2_regs’ Larisa Grigore
2024-12-16 16:17 ` Frank Li
2024-12-17 14:27 ` Larisa Ileana Grigore
2024-12-16 7:58 ` [PATCH 4/8] dmaengine: fsl-edma: add eDMAv3 registers to edma_regs Larisa Grigore
2024-12-16 16:18 ` Frank Li
2024-12-16 7:58 ` [PATCH 5/8] dt-bindings: dma: fsl-edma: add nxp,s32g2-edma compatible string Larisa Grigore
2024-12-16 16:18 ` Frank Li
2024-12-17 5:26 ` Krzysztof Kozlowski
2024-12-17 14:26 ` Larisa Ileana Grigore
2024-12-16 7:58 ` [PATCH 6/8] dmaengine: fsl-edma: add support for S32G based platforms Larisa Grigore
2024-12-16 16:20 ` Frank Li
2024-12-16 7:58 ` [PATCH 7/8] dmaengine: fsl-edma: wait until no hardware request is in progress Larisa Grigore
2024-12-17 5:27 ` Krzysztof Kozlowski
2024-12-17 14:19 ` Larisa Ileana Grigore
2024-12-17 15:27 ` Krzysztof Kozlowski [this message]
2024-12-18 13:24 ` Larisa Ileana Grigore
2024-12-18 13:32 ` Krzysztof Kozlowski
2024-12-18 13:38 ` Larisa Ileana Grigore
2024-12-18 14:10 ` Krzysztof Kozlowski
2024-12-18 15:39 ` Frank Li
2024-12-16 7:58 ` [PATCH 8/8] dmaengine: fsl-edma: read/write multiple registers in cyclic transactions Larisa Grigore
2024-12-16 16:09 ` [PATCH 0/8] Add eDMAv3 support for S32G2/S32G3 SoCs Frank Li
2024-12-16 16:22 ` Frank Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2e0e1fe3-af5e-4416-8b34-3fecb923b481@kernel.org \
--to=krzk@kernel.org \
--cc=Frank.Li@nxp.com \
--cc=aruizrui@redhat.com \
--cc=clizzi@redhat.com \
--cc=dmaengine@vger.kernel.org \
--cc=eballetb@redhat.com \
--cc=imx@lists.linux.dev \
--cc=larisa.grigore@oss.nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=s32@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.