From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.4 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3083BC4338F for ; Thu, 5 Aug 2021 09:20:01 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 004E861029 for ; Thu, 5 Aug 2021 09:20:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 004E861029 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=6EPOgJ8HlLs9vofR5ZfoGfXgrLSsEJmy6TBiI659Qrk=; b=QAyNHPTbTatZy8+I0Rg8hj2S6m KDbyNBuZJpzEu7FtBbu/AhVuxXlI29+Yerl1hlRK/2XhHfQRUzKRlNJn2zm0lVrOxzBrHLYxf7K36 lJwOrd0PTUNftJJOn4Ss48q/mR5Hpx/i9yudr9dc/TziqCFWavb9Gn5gFaolPsc9Xe8IFAFGOcYNK VQIK1IXcy/OPJzXD8GyGCz/D/aOdQ0TTorrSVa24Z6t6yuZ1X0EPSNpdm6p7f2mW8K5ft9XCVEU7Z fxahtwVnFECoDRZCc0ufGu3DwIBcqvkytDS9/QUsgHR5Xkxs5t0ELks7ovkgs64pNQj0xisZsld5s M/iBknCw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mBZWJ-008qOo-BA; Thu, 05 Aug 2021 09:18:31 +0000 Received: from mail-pj1-x1031.google.com ([2607:f8b0:4864:20::1031]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mBZWE-008qNI-3L for linux-arm-kernel@lists.infradead.org; Thu, 05 Aug 2021 09:18:27 +0000 Received: by mail-pj1-x1031.google.com with SMTP id mt6so7225557pjb.1 for ; Thu, 05 Aug 2021 02:18:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=ZwVoN/DI9XW1PFvWC8iFcWp68xBNJWcGRgCDQYYughw=; b=FR5RGyfUSND4F+gmoV9oK380dxTM7+ziCHumx4TBxTt6bi1b6SMISZ+Tgw5TKasDR0 bVjwAf9p6D1bugYEFB7+c1F17/uLJ25a1RTM9tUDO1JKDhadgjAP0sIiw5w31ADzrwFX ycqgZrXjPEJk4i1rqXDYq+1ZVheRFJ+c4PDGmiDmV5+AVUf4hO2ArjtScS/DCYovjUoH BZx/M5IPR1b2YvQoA+rRUJuMMzSresa7T8zDtc256V0ZjMJnJEaIhXoay7VDU8Hgjd5U CZJ2Z2aO/MOqErvpGLZKqJbaJj7ggskmjKe1QOOF631KNQsvpCrPbongWu0LYSKIRyor Y+Dg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ZwVoN/DI9XW1PFvWC8iFcWp68xBNJWcGRgCDQYYughw=; b=PWvOo0+LoFUQOWCFfqBJJbtteNZCqb6CrNWGes0PklpJDksp5lf4gsStvxyHf82Qj+ 0P5NCTTFpbjXROimGg5hfJzw+WDANL3xP59B5dTlSW0LcQ1eEafBfx/0IwcPr+48FwS7 mYp6Uoq/ab41ziAuYg38I+usLQrpwvscWitOowzGuUv80YHpiqE9imdO7ApqXEaYWIkc hcIHJ6T+6GdVBmEpTLdcvGw+XljlNjGMuYz4leA2rHd3TDXxMQ12dyMOcpnc6YPAIToV o8vCvja03JW1cxF32ZJHp0+uRg2cB69Q1egWqMWKEfJmfZTal9WCZqjimJOXS/5OjLv9 YYKg== X-Gm-Message-State: AOAM530Gh7UuGAUKiXYrn1yqwMtTaZPn6Ffxp3coNpd8jyGwzcVqe2PD 1x9JObbzPEUNr9hHKJYhXVs1ay4XBgJ9Yw== X-Google-Smtp-Source: ABdhPJw8fzKyJU1taP3hkSUjNczdllqZhha3EOq7EN43CuiVgY/sEQz0EF8oBb8Tq+7Uk3Cbu7LIHg== X-Received: by 2002:a63:a902:: with SMTP id u2mr754513pge.123.1628155104681; Thu, 05 Aug 2021 02:18:24 -0700 (PDT) Received: from [10.230.31.46] ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id b8sm5220826pjo.51.2021.08.05.02.18.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 05 Aug 2021 02:18:24 -0700 (PDT) Subject: Re: [PATCH net-next 1/3] dt-bindings: net: fsl, fec: add "fsl, wakeup-irq" property To: Joakim Zhang , davem@davemloft.net, kuba@kernel.org, robh+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, festevam@gmail.com, andrew@lunn.ch Cc: kernel@pengutronix.de, linux-imx@nxp.com, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20210805074615.29096-1-qiangqing.zhang@nxp.com> <20210805074615.29096-2-qiangqing.zhang@nxp.com> From: Florian Fainelli Message-ID: <2e1a14bf-2fa8-ed39-d133-807c4e14859c@gmail.com> Date: Thu, 5 Aug 2021 02:18:11 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <20210805074615.29096-2-qiangqing.zhang@nxp.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210805_021826_199029_8A8C6EBF X-CRM114-Status: UNSURE ( 8.97 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 8/5/2021 12:46 AM, Joakim Zhang wrote: > Add "fsl,wakeup-irq" property for FEC controller to select wakeup irq > source. > > Signed-off-by: Fugang Duan > Signed-off-by: Joakim Zhang Why are not you making use of the standard interrupts-extended property which allows different interrupt lines to be originating from different interrupt controllers, e.g.: interrupts-extended = <&gic GIC_SPI 112 4>, <&wakeup_intc 0>; -- Florian _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.4 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6B87C4338F for ; Thu, 5 Aug 2021 09:18:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C60F060E53 for ; Thu, 5 Aug 2021 09:18:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232818AbhHEJSn (ORCPT ); Thu, 5 Aug 2021 05:18:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55206 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232046AbhHEJSj (ORCPT ); Thu, 5 Aug 2021 05:18:39 -0400 Received: from mail-pj1-x1030.google.com (mail-pj1-x1030.google.com [IPv6:2607:f8b0:4864:20::1030]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2AB3CC061765; Thu, 5 Aug 2021 02:18:25 -0700 (PDT) Received: by mail-pj1-x1030.google.com with SMTP id mt6so7225525pjb.1; Thu, 05 Aug 2021 02:18:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=ZwVoN/DI9XW1PFvWC8iFcWp68xBNJWcGRgCDQYYughw=; b=FR5RGyfUSND4F+gmoV9oK380dxTM7+ziCHumx4TBxTt6bi1b6SMISZ+Tgw5TKasDR0 bVjwAf9p6D1bugYEFB7+c1F17/uLJ25a1RTM9tUDO1JKDhadgjAP0sIiw5w31ADzrwFX ycqgZrXjPEJk4i1rqXDYq+1ZVheRFJ+c4PDGmiDmV5+AVUf4hO2ArjtScS/DCYovjUoH BZx/M5IPR1b2YvQoA+rRUJuMMzSresa7T8zDtc256V0ZjMJnJEaIhXoay7VDU8Hgjd5U CZJ2Z2aO/MOqErvpGLZKqJbaJj7ggskmjKe1QOOF631KNQsvpCrPbongWu0LYSKIRyor Y+Dg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ZwVoN/DI9XW1PFvWC8iFcWp68xBNJWcGRgCDQYYughw=; b=BiYpfoFKM+W+lX3L37U3ctL7mrgs5JoYpov+edmUOlX9Ya5oq11oaBKyFhCwk4Ckk1 prdYgMmoMjUpmXTkJGglFufBqwPPSrky+ZSWQeDWe3UVUOGjDd/rlrWZk/HGhXonwlGa MkMz0MahQfITT68o2ravJc3kSbHIXmeV1q5516oiyPLw8fsPVPQymn3cwidzLpDIx7Uq 9rcr3qscOTcKbrlbYp/MQkD74CdRrDOXKqStc5em2TBW3s4c3i+DYWqwlz29quS1p4F+ /V3OJSOqNGkcdt8hUiVsvy8z8t55SYwEQqdWvQSnATSQ1VDaW7h8/H58lOBnymMS4J0y c8yQ== X-Gm-Message-State: AOAM531GlJSn7yEADNhO2W9a7u5VKrfGWE7b3ZXKoD5QATTcR5v8HOff hWLvNIGwiMMunXRY/116/7o= X-Google-Smtp-Source: ABdhPJw8fzKyJU1taP3hkSUjNczdllqZhha3EOq7EN43CuiVgY/sEQz0EF8oBb8Tq+7Uk3Cbu7LIHg== X-Received: by 2002:a63:a902:: with SMTP id u2mr754513pge.123.1628155104681; Thu, 05 Aug 2021 02:18:24 -0700 (PDT) Received: from [10.230.31.46] ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id b8sm5220826pjo.51.2021.08.05.02.18.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 05 Aug 2021 02:18:24 -0700 (PDT) Subject: Re: [PATCH net-next 1/3] dt-bindings: net: fsl, fec: add "fsl, wakeup-irq" property To: Joakim Zhang , davem@davemloft.net, kuba@kernel.org, robh+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, festevam@gmail.com, andrew@lunn.ch Cc: kernel@pengutronix.de, linux-imx@nxp.com, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20210805074615.29096-1-qiangqing.zhang@nxp.com> <20210805074615.29096-2-qiangqing.zhang@nxp.com> From: Florian Fainelli Message-ID: <2e1a14bf-2fa8-ed39-d133-807c4e14859c@gmail.com> Date: Thu, 5 Aug 2021 02:18:11 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <20210805074615.29096-2-qiangqing.zhang@nxp.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 8/5/2021 12:46 AM, Joakim Zhang wrote: > Add "fsl,wakeup-irq" property for FEC controller to select wakeup irq > source. > > Signed-off-by: Fugang Duan > Signed-off-by: Joakim Zhang Why are not you making use of the standard interrupts-extended property which allows different interrupt lines to be originating from different interrupt controllers, e.g.: interrupts-extended = <&gic GIC_SPI 112 4>, <&wakeup_intc 0>; -- Florian