From: Pierre-Louis Bossart <pierre-louis.bossart@linux.dev>
To: Charles Keepax <ckeepax@opensource.cirrus.com>,
Richard Fitzgerald <rf@opensource.cirrus.com>,
vkoul@kernel.org
Cc: broonie@kernel.org, yung-chuan.liao@linux.intel.com,
linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org,
patches@opensource.cirrus.com
Subject: Re: [PATCH 0/2] ASoC: Fix sdw_utils calling wrong codec init callbacks
Date: Tue, 13 Jan 2026 23:17:17 +0100 [thread overview]
Message-ID: <2e1b5ce3-94c8-4e74-9358-aeec57dc7a87@linux.dev> (raw)
In-Reply-To: <aWYoqQAYydHkrtQX@opensource.cirrus.com>
On 1/13/26 12:12, Charles Keepax wrote:
> On Mon, Jan 12, 2026 at 02:07:55PM +0000, Richard Fitzgerald wrote:
>> This series fixes a problem with soc_sdw_utils.c calling the wrong
>> codec init callbacks, because it assumed that the DAI name could be
>> used to uniquely identify the codec. This isn't the case, especially
>> on SDCA which is a generic driver for many parts.
>>
>> The second patch is the actual fix.
>> The first patch is needed to add a missing export to SoundWire core.
>>
>> Richard Fitzgerald (2):
>> soundwire: Add missing EXPORT for sdw_slave_type
>> ASoC: sdw_utils: Call init callbacks on the correct codec DAI
>>
>> drivers/soundwire/slave.c | 1 +
>> sound/soc/sdw_utils/soc_sdw_utils.c | 43 ++++++++++++++++++++++++++++-
>> 2 files changed, 43 insertions(+), 1 deletion(-)
>
> Reviewed-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.dev>
It's not obvious from the patchset title that the first patch probably needs Vinod's Acked-by tag
next prev parent reply other threads:[~2026-01-13 22:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-12 14:07 [PATCH 0/2] ASoC: Fix sdw_utils calling wrong codec init callbacks Richard Fitzgerald
2026-01-12 14:07 ` [PATCH 1/2] soundwire: Add missing EXPORT for sdw_slave_type Richard Fitzgerald
2026-01-14 5:26 ` Vinod Koul
2026-01-12 14:07 ` [PATCH 2/2] ASoC: sdw_utils: Call init callbacks on the correct codec DAI Richard Fitzgerald
2026-01-13 11:12 ` [PATCH 0/2] ASoC: Fix sdw_utils calling wrong codec init callbacks Charles Keepax
2026-01-13 22:17 ` Pierre-Louis Bossart [this message]
2026-01-14 21:36 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2e1b5ce3-94c8-4e74-9358-aeec57dc7a87@linux.dev \
--to=pierre-louis.bossart@linux.dev \
--cc=broonie@kernel.org \
--cc=ckeepax@opensource.cirrus.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
--cc=rf@opensource.cirrus.com \
--cc=vkoul@kernel.org \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.