From: David Ahern <dsahern@gmail.com>
To: Thayne McCombs <astrothayne@gmail.com>, netdev@vger.kernel.org
Subject: Re: [PATCH] ss: Make leading ":" always optional for sport and dport
Date: Sun, 14 Feb 2021 22:13:06 -0700 [thread overview]
Message-ID: <2e20fe26-baac-b1cf-e7b2-05dd6f26af27@gmail.com> (raw)
In-Reply-To: <20210214080913.8651-1-astrothayne@gmail.com>
On 2/14/21 1:09 AM, Thayne McCombs wrote:
> Doh! Sorry about that, here it is with the sign-off.
>
> -- >8 --
Don't put text here.
>
> The sport and dport conditions in expressions were inconsistent on
> whether there should be a ":" at the beginning of the port when only a
> port was provided depending on the family. The link and netlink
> families required a ":" to work. The vsock family required the ":"
> to be absent. The inet and inet6 families work with or without a leading
> ":".
>
> This makes the leading ":" optional in all cases, so if sport or dport
> are used, then it works with a leading ":" or without one, as inet and
> inet6 did.
>
> Signed-off-by: Thayne McCombs <astrothayne@gmail.com>
> ---
put extra comments here
> misc/ss.c | 46 ++++++++++++++++++++++++----------------------
> 1 file changed, 24 insertions(+), 22 deletions(-)
>
Also, put iproute2-next in the subject line along with a version number.
applied to iproute2-next.
next prev parent reply other threads:[~2021-02-15 5:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-06 6:36 [PATCH iproute2-next] ss: Make leading ":" always optional for sport and dport Thayne McCombs
2021-02-14 0:52 ` David Ahern
2021-02-14 8:09 ` [PATCH] " Thayne McCombs
2021-02-15 5:13 ` David Ahern [this message]
2021-02-15 5:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2e20fe26-baac-b1cf-e7b2-05dd6f26af27@gmail.com \
--to=dsahern@gmail.com \
--cc=astrothayne@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.