From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C56EC433F5 for ; Thu, 10 Feb 2022 21:36:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344015AbiBJVgi (ORCPT ); Thu, 10 Feb 2022 16:36:38 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:49612 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239266AbiBJVgi (ORCPT ); Thu, 10 Feb 2022 16:36:38 -0500 Received: from mail-io1-xd29.google.com (mail-io1-xd29.google.com [IPv6:2607:f8b0:4864:20::d29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 75F7326DA for ; Thu, 10 Feb 2022 13:36:38 -0800 (PST) Received: by mail-io1-xd29.google.com with SMTP id 9so9171746iou.2 for ; Thu, 10 Feb 2022 13:36:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=jISv2sd7M+VGGWYHc7AMvBHEJbhlhhpLfU1b+J7OE3Y=; b=S6tgd4/+f1shugVBQbimIlzTmJdvI5eGxO7+DNCwN8VGdq+Ha2GJzIi8pVTs+c5Wzk 6w9yMcwgebHlwWMiLmHqikiisn74QLoAis4KIifvJ1RCYO425QxGE89SXud3mIfljN5i XSVrshuGp8f0avBqbxCdf/DonSTSZbYQAU5JI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=jISv2sd7M+VGGWYHc7AMvBHEJbhlhhpLfU1b+J7OE3Y=; b=PJs4o4fdZvF87rnzL68tIYgLmx4xlJxzzqwqFxZkRe/beKrqTj9UFnHz4qG3+p3s3C SepXEsidId1XZRUwZSF3IDcrjzWJiE6SnNGoEnjknFcIl1foqxaK6rONqf7tegTW2o5Q aWcvffHQ82nDCFYPWRu/kiHE979h31T+Q1yY95oHJZgSWrJGuunk5RXOOLS+sXqwZAtm Pkd1Afiqt421un5rPbvBWdfe11QCmrkFlYKf35kJvtvtQZ/MqeVg5g2Wk8TgyaRUMRJG orf2BaoFUi/xg/C43G8VZwJDxGBWu+JLnmo+6wtjG3zy2YkP2Jc0NTKNA9ao9G0Ng6WT NG6A== X-Gm-Message-State: AOAM531ItZgYIBrzyZ+UzxpkWkq8jInfI9tcuAWR36gyVct+zBhxY6go K46EJ2f8wN5Cul0XcrzZRHlN9w== X-Google-Smtp-Source: ABdhPJz+VMFC+XfveESzcl1fhZU4kNFuh4neT8NKOj1ob1N95YkY58ueb4yAIvJJy7vbugALukp2fg== X-Received: by 2002:a02:7346:: with SMTP id a6mr5038215jae.299.1644528997801; Thu, 10 Feb 2022 13:36:37 -0800 (PST) Received: from [192.168.1.128] ([71.205.29.0]) by smtp.gmail.com with ESMTPSA id p11sm13281429iov.38.2022.02.10.13.36.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 10 Feb 2022 13:36:37 -0800 (PST) Subject: Re: [PATCH v2] selftests/seccomp: Fix seccomp failure by adding missing headers To: Kees Cook , Sherry Yang Cc: shuah@kernel.org, luto@amacapital.net, wad@chromium.org, christian@brauner.io, ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org, kafai@fb.com, songliubraving@fb.com, yhs@fb.com, john.fastabend@gmail.com, kpsingh@kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, bpf@vger.kernel.org, Shuah Khan References: <20220210203049.67249-1-sherry.yang@oracle.com> <202202101316.E38FEAFBCA@keescook> From: Shuah Khan Message-ID: <2e3d93a2-51ae-cef1-b251-c28ecc386dad@linuxfoundation.org> Date: Thu, 10 Feb 2022 14:36:36 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <202202101316.E38FEAFBCA@keescook> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On 2/10/22 2:16 PM, Kees Cook wrote: > On Thu, Feb 10, 2022 at 12:30:49PM -0800, Sherry Yang wrote: >> seccomp_bpf failed on tests 47 global.user_notification_filter_empty >> and 48 global.user_notification_filter_empty_threaded when it's >> tested on updated kernel but with old kernel headers. Because old >> kernel headers don't have definition of macro __NR_clone3 which is >> required for these two tests. Since under selftests/, we can install >> headers once for all tests (the default INSTALL_HDR_PATH is >> usr/include), fix it by adding usr/include to the list of directories >> to be searched. Use "-isystem" to indicate it's a system directory as >> the real kernel headers directories are. >> >> Signed-off-by: Sherry Yang > > Thanks! > > Reviewed-by: Kees Cook > Thank you. I will queue this up for rc5. thanks, -- Shuah