From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B9C90C624CF for ; Tue, 1 Sep 2026 09:07:10 +0000 (UTC) Received: from kara.freedesktop.org (unknown [131.252.210.166]) by gabe.freedesktop.org (Postfix) with ESMTPS id DF5FC10EC31; Tue, 1 Sep 2026 09:07:09 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="ZLv9z5Oz"; dkim-atps=neutral Received: from kara.freedesktop.org (localhost [127.0.0.1]) by kara.freedesktop.org (Postfix) with ESMTP id 6B2C147D39; Tue, 1 Sep 2026 08:50:08 +0000 (UTC) ARC-Seal: i=1; cv=none; a=rsa-sha256; d=lists.freedesktop.org; s=20240201; t=1788252608; b=MHT6reYy24mRLhzxH9/K3tl/lglFdzOMTN6bAlTFtd0tGGi17hIUk/Q5Dswhff88Rp/la pKW6VyuSZSGrtysazKLXD6hTfFdQygxumxeib/hmcEcw3CooqoP2ZYaV12Vna8n2ngeDvu5 HtUwykLIhzPUURsQShB9M5dlImgiVPjBiY68hC6N6VsET3mh5AWwo2o4QEfA49k+Y2bN0E9 SE1UEmiivGpbFMO1tGyQzP7KN1eoqTV87iETgq6cCydiu9eL914BV0BAdQ2oBGpKubJktSA ilKHlbyXWJLBAE4e/RAPnW34iP6DUBlbqXgnI5ptg2umK4DgXF9yqqsPOP3w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=lists.freedesktop.org; s=20240201; t=1788252608; h=from : sender : reply-to : subject : date : message-id : to : cc : mime-version : content-type : content-transfer-encoding : content-id : content-description : resent-date : resent-from : resent-sender : resent-to : resent-cc : resent-message-id : in-reply-to : references : list-id : list-help : list-unsubscribe : list-subscribe : list-post : list-owner : list-archive; bh=m/wEGTF4f7C70SB4/q9aIKOMg+2fN6lt/IMX6OVr2GE=; b=mf6ZlO9M6+Wx0xa9lsOeQzuvWsLDik4qm3nKlRr44epx3IbrJEF/ubeG1lRZwquJNifQ7 hJBYtpiFG0q/HsJkyeB9rqz/xeObXKwr49m8loPrSJBB+MfQAGDEAOIsdx5zLmMaGJDSYk1 RAzd9M2nw9V9HccyMoTNbJ+uqBUWKiVh4/RcYVf4uWrc/eSw0e6igY7tgdSRpZ+N8AzM5hj M/f1afHfKAJ4EjdthOr8wP/RyiORtoxDEuxQbXIoZYWrWoNYovlxuDyu4exQ5Sxv8tWoNy4 lLhXPpJrX8jhs0tslzykH8UQFC8ZYKIFGuSgVBFXH2Uqc6aQ/KgSyEwZN8Iw== ARC-Authentication-Results: i=1; mail.freedesktop.org; dkim=pass header.d=kernel.org; arc=none (Message is not ARC signed); dmarc=pass (Used From Domain Record) header.from=kernel.org policy.dmarc=quarantine Authentication-Results: mail.freedesktop.org; dkim=pass header.d=kernel.org; arc=none (Message is not ARC signed); dmarc=pass (Used From Domain Record) header.from=kernel.org policy.dmarc=quarantine Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by kara.freedesktop.org (Postfix) with ESMTPS id 8DC0347D28 for ; Tue, 1 Sep 2026 08:50:05 +0000 (UTC) Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by gabe.freedesktop.org (Postfix) with ESMTPS id BA03B10EC15; Tue, 1 Sep 2026 09:07:06 +0000 (UTC) Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id D6D29601DE; Tue, 1 Sep 2026 09:07:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BBE701F000E9; Tue, 1 Sep 2026 09:07:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1788253625; bh=m/wEGTF4f7C70SB4/q9aIKOMg+2fN6lt/IMX6OVr2GE=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=ZLv9z5OzoD0fx0iYaQYmDawsSdPZZbIEG6BC3Nio+WgHgZj2R8fnHzPnvWo4SiKZY /Of7JDUDx8RQZgRNlPu0NMl+oU0rov2ViyfmzazCwUqbQpeZo69AS03Xjy9Nemwvue 1yd5pahrTxqSacJKWqYwwBEhvHuyLxN4szUq6g1IGkgOBQQ2rRzpZlMNZqSA3pMN7y 9oKHA4EG0gWAE+gdrMw9AHbwa86VqFfe4W3IbtjZzYeugQGBgYYg7s5d8PTa6YVPqS ghMwkdjf4ELQY+uSeA09R38BT4sRW+FX7EN5XYlSdHAo2SkFeBA2pRMj6C8CVEc4vT L1yofrhBrittQ== Message-ID: <2e433e8d-a71e-49e4-8dea-659a94c8143f@kernel.org> Date: Tue, 1 Sep 2026 11:07:01 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] drm/nouveau: bound sync and op counts in EXEC and VM_BIND To: Dave Airlie , Junrui Luo References: <20260808-nouveau-fixes-v1-0-c3ebdc17a89c@outlook.com> <20260808-nouveau-fixes-v1-1-c3ebdc17a89c@outlook.com> <55965C34-9026-4EE7-B2F0-1D5D9807D682@outlook.com> From: Danilo Krummrich Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Message-ID-Hash: JFCMBWKYJE3VF2E7P3JIBPTXF3YHNKNZ X-Message-ID-Hash: JFCMBWKYJE3VF2E7P3JIBPTXF3YHNKNZ X-MailFrom: dakr@kernel.org X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation CC: David Airlie , Maarten Lankhorst , Maxime Ripard , Simona Vetter , "dri-devel@lists.freedesktop.org" , "nouveau@lists.freedesktop.org" , "linux-kernel@vger.kernel.org" , Yuhao Jiang , "stable@vger.kernel.org" X-Mailman-Version: 3.3.8 Precedence: list List-Id: Nouveau development list Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 8/11/26 6:05 AM, Dave Airlie wrote: > On Tue, 11 Aug 2026 at 14:00, Junrui Luo wrote: >> >> On Mon, Aug 10, 2026 at 08:43:50AM +1000, David Airlie wrote: >>> Have you run a complete Vulkan CTS with NVK across this with no regressions? >>> >>> I'm weary of those limits being too low, but I think the only app that >>> might push them beyond CTS would be Forza Horizon 5 or 6. >> >> No, I have not. I don't currently have the hardware to run NVK, so I can't >> offer a CTS run or any other regression test for this. >> >> Is there a better guard that avoids a hard limit here, or does this need >> a test before it can go in? > > Looking at xe it also has 1024 limit on number of syncs, but it > doesn't have any limit on number of binds, > > *bind_ops = kvmalloc_objs(struct drm_xe_vm_bind_op, > args->num_binds, > GFP_KERNEL | __GFP_ACCOUNT | > __GFP_RETRY_MAYFAIL | __GFP_NOWARN); > > Maybe nouveau could do the same. SGTM, I'd also be hesitant to put a hard limit on VM_BIND. @Junrui: Can you please resend? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 72E47C61DD3 for ; Tue, 1 Sep 2026 09:07:09 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9EDD510EC15; Tue, 1 Sep 2026 09:07:08 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="ZLv9z5Oz"; dkim-atps=neutral Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by gabe.freedesktop.org (Postfix) with ESMTPS id BA03B10EC15; Tue, 1 Sep 2026 09:07:06 +0000 (UTC) Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id D6D29601DE; Tue, 1 Sep 2026 09:07:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BBE701F000E9; Tue, 1 Sep 2026 09:07:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1788253625; bh=m/wEGTF4f7C70SB4/q9aIKOMg+2fN6lt/IMX6OVr2GE=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=ZLv9z5OzoD0fx0iYaQYmDawsSdPZZbIEG6BC3Nio+WgHgZj2R8fnHzPnvWo4SiKZY /Of7JDUDx8RQZgRNlPu0NMl+oU0rov2ViyfmzazCwUqbQpeZo69AS03Xjy9Nemwvue 1yd5pahrTxqSacJKWqYwwBEhvHuyLxN4szUq6g1IGkgOBQQ2rRzpZlMNZqSA3pMN7y 9oKHA4EG0gWAE+gdrMw9AHbwa86VqFfe4W3IbtjZzYeugQGBgYYg7s5d8PTa6YVPqS ghMwkdjf4ELQY+uSeA09R38BT4sRW+FX7EN5XYlSdHAo2SkFeBA2pRMj6C8CVEc4vT L1yofrhBrittQ== Message-ID: <2e433e8d-a71e-49e4-8dea-659a94c8143f@kernel.org> Date: Tue, 1 Sep 2026 11:07:01 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] drm/nouveau: bound sync and op counts in EXEC and VM_BIND To: Dave Airlie , Junrui Luo Cc: David Airlie , Lyude Paul , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Simona Vetter , "dri-devel@lists.freedesktop.org" , "nouveau@lists.freedesktop.org" , "linux-kernel@vger.kernel.org" , Yuhao Jiang , "stable@vger.kernel.org" References: <20260808-nouveau-fixes-v1-0-c3ebdc17a89c@outlook.com> <20260808-nouveau-fixes-v1-1-c3ebdc17a89c@outlook.com> <55965C34-9026-4EE7-B2F0-1D5D9807D682@outlook.com> From: Danilo Krummrich Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 8/11/26 6:05 AM, Dave Airlie wrote: > On Tue, 11 Aug 2026 at 14:00, Junrui Luo wrote: >> >> On Mon, Aug 10, 2026 at 08:43:50AM +1000, David Airlie wrote: >>> Have you run a complete Vulkan CTS with NVK across this with no regressions? >>> >>> I'm weary of those limits being too low, but I think the only app that >>> might push them beyond CTS would be Forza Horizon 5 or 6. >> >> No, I have not. I don't currently have the hardware to run NVK, so I can't >> offer a CTS run or any other regression test for this. >> >> Is there a better guard that avoids a hard limit here, or does this need >> a test before it can go in? > > Looking at xe it also has 1024 limit on number of syncs, but it > doesn't have any limit on number of binds, > > *bind_ops = kvmalloc_objs(struct drm_xe_vm_bind_op, > args->num_binds, > GFP_KERNEL | __GFP_ACCOUNT | > __GFP_RETRY_MAYFAIL | __GFP_NOWARN); > > Maybe nouveau could do the same. SGTM, I'd also be hesitant to put a hard limit on VM_BIND. @Junrui: Can you please resend?