Re: [PATCH v6 5/9] xen: generate hypercall interface related code

[Juergen Gross <jgross@suse.com>]

[-- Attachment #1.1.1: Type: text/plain, Size: 1346 bytes --]

On 11.07.22 12:18, Jan Beulich wrote:
> On 24.03.2022 15:01, Juergen Gross wrote:
>> --- a/xen/include/Makefile
>> +++ b/xen/include/Makefile
>> @@ -77,6 +77,18 @@ $(obj)/compat/xlat.h: $(addprefix $(obj)/compat/.xlat/,$(xlat-y)) $(obj)/config/
>>   	cat $(filter %.h,$^) >$@.new
>>   	mv -f $@.new $@
>>   
>> +quiet_cmd_genhyp = GEN     $@
>> +define cmd_genhyp
>> +    awk -f $(srctree)/scripts/gen_hypercall.awk <$< >$@
>> +endef
>> +
>> +all: $(obj)/xen/hypercall-defs.h
>> +
>> +$(obj)/xen/hypercall-defs.h: $(obj)/hypercall-defs.i $(srctree)/scripts/gen_hypercall.awk FORCE
>> +	$(call if_changed,genhyp)
>> +
>> +targets += xen/hypercall-defs.h
>> +
>>   ifeq ($(XEN_TARGET_ARCH),$(XEN_COMPILE_ARCH))
>>   
>>   all: $(obj)/headers.chk $(obj)/headers99.chk $(obj)/headers++.chk
>> @@ -132,3 +144,4 @@ all: lib-x86-all
>>   endif
>>   
>>   clean-files := compat config generated headers*.chk xen/lib/x86/cpuid-autogen.h
>> +clean-files += xen/hypercall-defs.h hypercall-defs.i
> 
> I've committed this as-is (with just fuzz suitably resolved), despite
> being uncertain whether xen/hypercall-defs.h - being part of targets -
> actually needs enumerating here (anymore).

Without it being enumerated "make clean" will still remove it. So it is
obviously not needed.

Sending a patch ...


Juergen


[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 3149 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 495 bytes --]