From: "Srivatsa, Anusha" <anusha.srivatsa@intel.com>
To: "De Marchi, Lucas" <lucas.demarchi@intel.com>,
"intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>
Subject: Re: [Intel-gfx] [PATCH] drm/i915/display: fix typo when returning table
Date: Fri, 21 May 2021 16:58:32 +0000 [thread overview]
Message-ID: <2e77cacafd544e2a9553cb30e4dcddaa@intel.com> (raw)
In-Reply-To: <20210521005209.4058702-1-lucas.demarchi@intel.com>
Reviewed-by: Anusha Srivatsa <anusha.srivatsa@intel.com>
> -----Original Message-----
> From: De Marchi, Lucas <lucas.demarchi@intel.com>
> Sent: Thursday, May 20, 2021 5:52 PM
> To: intel-gfx@lists.freedesktop.org
> Cc: Srivatsa, Anusha <anusha.srivatsa@intel.com>
> Subject: [PATCH] drm/i915/display: fix typo when returning table
>
> Fix table returned when port_clock > 270000:
>
> drivers/gpu/drm/i915/display/intel_ddi_buf_trans.c:752:47: error:
> variable 'adlp_dkl_phy_dp_ddi_trans_hbr2_hbr3' is not needed and will not
> be emitted [-Werror,-Wunneeded-internal-declaration]
> static const struct tgl_dkl_phy_ddi_buf_trans
> adlp_dkl_phy_dp_ddi_trans_hbr2_hbr3[] = {
>
> Initial version of the patch had it in a single table, but on second version the
> table got split, but we continued to reference just one of them.
>
> Fixes: ca962882268a ("drm/i915/adl_p: Define and use ADL-P specific DP
> translation tables")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_ddi_buf_trans.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_ddi_buf_trans.c
> b/drivers/gpu/drm/i915/display/intel_ddi_buf_trans.c
> index ce5d5d13b7c1..8bfd00f49f2a 100644
> --- a/drivers/gpu/drm/i915/display/intel_ddi_buf_trans.c
> +++ b/drivers/gpu/drm/i915/display/intel_ddi_buf_trans.c
> @@ -1383,7 +1383,7 @@ adlp_get_dkl_buf_trans_dp(struct intel_encoder
> *encoder, {
> if (crtc_state->port_clock > 270000) {
> *n_entries =
> ARRAY_SIZE(adlp_dkl_phy_dp_ddi_trans_hbr2_hbr3);
> - return adlp_dkl_phy_dp_ddi_trans_hbr;
> + return adlp_dkl_phy_dp_ddi_trans_hbr2_hbr3;
> }
>
> *n_entries = ARRAY_SIZE(adlp_dkl_phy_dp_ddi_trans_hbr);
> --
> 2.31.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2021-05-21 16:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-21 0:52 [Intel-gfx] [PATCH] drm/i915/display: fix typo when returning table Lucas De Marchi
2021-05-21 1:00 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2021-05-21 1:32 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-05-21 16:58 ` Srivatsa, Anusha [this message]
2021-05-22 13:03 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2e77cacafd544e2a9553cb30e4dcddaa@intel.com \
--to=anusha.srivatsa@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=lucas.demarchi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.