Re: [PATCH 0/5] sched_ext: selftest infrastructure fixes

[Tejun Heo <tj@kernel.org>]

Hello, Tao.

The following is a Claude-generated review.

On Fri, Oct 09, 2026 at 09:40:59PM +0800, Tao Cui wrote:
>   1. selftests/sched_ext: Fix reload_loop error-path use-after-free

Looks good. Inside the if (err) block, SCX_FAIL() reads better than
SCX_FAIL_IF(err, ...).

>   2. sched_ext: Add SCX_ECODE_RSN_CGROUP_OFFLINE to user_exit_info.h

Can you name the commit in the description? It's ebeca1f930ea ("sched_ext:
Introduce cgroup sub-sched support").

>   3. selftests/sched_ext: Fail loudly when EXIT_KIND is missing from
>      BTF. EXIT_KIND() resolves scx_exit_kind values through
>      __COMPAT_ENUM_OR_ZERO(), which maps a missing enum to 0 (==
>      SCX_EXIT_NONE), so on kernels whose BTF lacks the enum every
>      EXIT_KIND() comparison is meaningless.

struct scx_exit_info carries enum scx_exit_kind, so any BTF that loads the
skeleton has the enum. What can be missing is an enumerator, and the four
the tests use today exist on every sched_ext kernel. On a kernel missing
one, the comparisons against SCX_EXIT_NONE get the right value from the
fallback, the SCX_EQ()s against UNREG/UNREG_BPF/ERROR fail with a confusing
message, and the only vacuous pass is the error poll in kick.c.

The new EXIT_KIND() is also SCX_KIND_VAL() with a different message. If
you want to keep the patch, maybe define one in terms of the other?

With a return hidden in the macro, the remaining
kind != EXIT_KIND(SCX_EXIT_NONE) sites (allowed_cpus, cgroup_nr_cpus,
cyclic_kick_wait, enq_blocked) jump over their goto cleanup on a miss, and
invalid_one() resolves error_kind after the gated worker is spawned.
Converting those sites to UEI_EXITED() like the polling helpers and
hoisting the lookup above the spawn would close that.

The <unistd.h> include is unused in this patch, and compat.h already pulls
it in.

>   4. selftests/sched_ext: Add SCX_ASSERT_ALIVE and adopt it.

Looks good. Can SCX_ASSERT_ALIVE() print uei.msg too? That's where the
actual error text ends up. UEI_REPORT() already does that.

>   5. selftests/sched_ext: Bound exit waits and report reload_loop
>      failures.

On timeout, exit.c returns with the link and the skel still open. The
scheduler that didn't exit stays attached for the rest of the runner
process, so every later test fails to attach with EBUSY and the real
failure is buried. prog_run and hotplug destroy the link on their timeout
paths. Can exit.c do the same, plus exit__destroy()?

In reload_loop, SCX_FAIL_IF(unexpected_errno, ...) returns before the
printf(), so the ", unexpected errno" arm is dead, and the EBUSY count then
prints on every run. 2048 of 2048 failing is also a weak bar; "at least one
success per thread" would say the same thing more sharply. Would you split
the timed wait and the reload_loop accounting into two patches?

Nits: two stray blank lines after setup(), and the two #defines could be an
enum.

Can you note the base and how the series was tested in the cover?

Thanks.

-- 
tejun