From: Nico Boehr <nrb@linux.ibm.com>
To: Claudio Imbrenda <imbrenda@linux.ibm.com>
Cc: kvm@vger.kernel.org, linux-s390@vger.kernel.org,
frankja@linux.ibm.com, thuth@redhat.com, scgl@linux.ibm.com
Subject: Re: [kvm-unit-tests PATCH v1 2/2] s390x: add migration test for storage keys
Date: Fri, 13 May 2022 14:15:20 +0200 [thread overview]
Message-ID: <2eb27198bb0e987a880a8b218eda4f9436589eaa.camel@linux.ibm.com> (raw)
In-Reply-To: <20220512174107.0500a5e6@p-imbrenda>
On Thu, 2022-05-12 at 17:41 +0200, Claudio Imbrenda wrote:
> > diff --git a/s390x/migration-skey.c b/s390x/migration-skey.c
> > new file mode 100644
> > index 000000000000..6f3053d8ab40
[...]
> > +static void test_migration(void)
> > +{
[...]
> > + /* ensure access key doesn't match storage key and
> > is never zero */
> > + mismatching_key.str.acc = expected_key.str.acc < 15
> > ? expected_key.str.acc + 1 : 1;
>
> mismatching_key.str.acc = (expected_key.str.acc ^ 2) | 1;
As discussed in person: I had something like this before and thought it is
easier to understand with the tertiary operator. So I'd prefer to leave as-is.
next prev parent reply other threads:[~2022-05-13 12:15 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-12 14:01 [kvm-unit-tests PATCH v1 0/2] s390x: add migration test for storage keys Nico Boehr
2022-05-12 14:01 ` [kvm-unit-tests PATCH v1 1/2] lib: s390x: introduce check_pgm_int_code_xfail() Nico Boehr
2022-05-12 15:23 ` Claudio Imbrenda
2022-05-12 14:01 ` [kvm-unit-tests PATCH v1 2/2] s390x: add migration test for storage keys Nico Boehr
2022-05-12 14:43 ` Janosch Frank
2022-05-12 15:41 ` Claudio Imbrenda
2022-05-13 12:15 ` Nico Boehr [this message]
2022-05-13 11:04 ` Janis Schoetterl-Glausch
2022-05-13 12:33 ` Claudio Imbrenda
2022-05-13 12:46 ` Janis Schoetterl-Glausch
2022-05-13 13:04 ` Claudio Imbrenda
2022-05-16 8:45 ` Nico Boehr
2022-05-13 13:02 ` Nico Boehr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2eb27198bb0e987a880a8b218eda4f9436589eaa.camel@linux.ibm.com \
--to=nrb@linux.ibm.com \
--cc=frankja@linux.ibm.com \
--cc=imbrenda@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=scgl@linux.ibm.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.