From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9D70ACAC582 for ; Fri, 12 Sep 2025 03:41:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Type:Content-Transfer-Encoding:Cc: Reply-To:From:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Subject:In-Reply-To:References:To:MIME-Version:Date: Message-ID:Sender:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=AqD0hNG1kFBX7U7Oivlhp9e+XY9jW1ImpmZPr6gc/r8=; b=bK+mxYEV2Tcdq4ikk6VCVJ3HlF IKcxrAXLjjmY8fiXbkBuRMQ4P8O2IBHe7gf5xq+EUCUlr+cAdjXDrolT0Hep96ipkQgIMkKE59vrf l2s7WWiKSrz4o7ZqkTn8YRLrh8FJKWwYhqSkn4Z1+ggXGrdBdB8GFty6VJzp/KNmaN9M=; Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1uwuf9-0003Ip-AY; Fri, 12 Sep 2025 03:41:27 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1uwuf7-0003Ii-Dj for linux-f2fs-devel@lists.sourceforge.net; Fri, 12 Sep 2025 03:41:25 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: From:References:To:Subject:Cc:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=7W028qr31TcrDIG9bbg0IvFcQs//QdCvvv6speZtA4s=; b=mGKIZnXE+ZsqzFHMJJVbzNNhOj XJ82UdtFs99WWFuaHjvKXbc12c1HmEuxhJw43lpALDLd4p7tk+oVPmOIaQ3htwMHA0C/1fZ+qnGva iBjr9Pid77+XE2Q+dwuW9sKNETHGdBgXuyqUCqFtxkKUg1oAURB4kab/9dneJzTLd3Qk=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:References:To: Subject:Cc:MIME-Version:Date:Message-ID:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=7W028qr31TcrDIG9bbg0IvFcQs//QdCvvv6speZtA4s=; b=de1ObshCsYyprVd+II3iDqZqfL eLd88Fz1yCvNSqaB6QHHUzlhJOiw+uxY/XplUoBLQP0WtcN0GUL+GYgCKcz26QNz/EhzFWUoQXBXp v9ih2O4wbZ9L57wPbB1t+5DNR7S4eDH5r4YABPxDF4gTq36VSEHOXLanculLHzg0MHEg=; Received: from sea.source.kernel.org ([172.234.252.31]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1uwuf6-0000KQ-PI for linux-f2fs-devel@lists.sourceforge.net; Fri, 12 Sep 2025 03:41:25 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 4D5AD418D6; Fri, 12 Sep 2025 03:41:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E7CCCC4CEF4; Fri, 12 Sep 2025 03:41:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1757648479; bh=XDwDklRFyhTQ7jpEFuln8g3jtb2GyRw7CB0tY3hlXIE=; h=Date:Cc:Subject:To:References:From:In-Reply-To:From; b=sCNXCSxisFb6QSyP/WoUcT62/cIWYvK/VB/grwR38wDI1Sc/zVAJwMao5k7iLDyCK o1mYGgOSrEZLBsiWQTejzn1KDItxoTx8YcZx6+91tlXzmz5LySQrWydAl8OoahZyKu 7xGsLY7GlBiHAdXzpfZ0WgYM9rjT7KWmOKZv+3C+BuOxIIG5eN68ulQcV5WpNzhdJe yFyGJEqWFfknz3ChDzIoLvivUztP9hiubrZM4nZaC3GW17vmd0yqVhUZIjNstqorS8 Z/MO/ldNHKNJukHUqo0ApITHY/ghRsevMaAfVhrWKnDNL8vLZNINON+CQzXyOotnV7 FDDbAc2SkU++w== Message-ID: <2ecb4f74-cc60-4dd4-8dc3-d4f3ff848e87@kernel.org> Date: Fri, 12 Sep 2025 11:41:22 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: wangzijie References: <20250912033609.3033352-1-wangzijie1@honor.com> Content-Language: en-US In-Reply-To: <20250912033609.3033352-1-wangzijie1@honor.com> X-Headers-End: 1uwuf6-0000KQ-PI Subject: Re: [f2fs-dev] [PATCH 1/2] f2fs: fix wrong extent_info data for precache extents X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Chao Yu via Linux-f2fs-devel Reply-To: Chao Yu Cc: jaegeuk@kernel.org, linux-kernel@vger.kernel.org, feng.han@honor.com, linux-f2fs-devel@lists.sourceforge.net Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net T24gOS8xMi8yMDI1IDExOjM2IEFNLCB3YW5nemlqaWUgd3JvdGU6Cj4+IE9uIDkvMTEvMjAyNSA1 OjA3IFBNLCB3YW5nemlqaWUgd3JvdGU6Cj4+Pj4gT24gOS8xMC8yNSAyMTo1OCwgd2FuZ3ppamll IHdyb3RlOgo+Pj4+PiBXaGVuIHRoZSBkYXRhIGxheW91dCBpcyBsaWtlIHRoaXM6Cj4+Pj4+IGRu b2RlMTogICAgICAgICAgICAgICAgICAgICBkbm9kZTI6Cj4+Pj4+IFswXSAgICAgIEEgICAgICAg ICAgICAgICAgICBbMF0gICAgTkVXX0FERFIKPj4+Pj4gWzFdICAgICAgQSsxICAgICAgICAgICAg ICAgIFsxXSAgICAweDAKPj4+Pj4gLi4uICAgICAgICAgICAgICAgICAgICAgICAgIC4uLi4KPj4+ Pj4gWzEwMTZdICAgQSsxMDE2Cj4+Pj4+IFsxMDE3XSAgIEIgKEIhPUErMTAxNykgICAgICBbMTAx N10gMHgwCj4+Pj4+Cj4+Pj4+IFdlIGNhbiBidWlsZCB0aGlzIGtpbmQgb2YgbGF5b3V0IGJ5IGZv bGxvd2luZyBzdGVwcyh3aXRoIGlfZXh0cmFfaXNpemU6MzYpOgo+Pj4+PiAuL2YyZnNfaW8gd3Jp dGUgMSAwIDE4ODEgcmFuZCBkc3luYyB0ZXN0ZmlsZQo+Pj4+PiAuL2YyZnNfaW8gd3JpdGUgMSAx ODgxIDEgcmFuZCBidWZmZXJlZCB0ZXN0ZmlsZQo+Pj4+PiAuL2YyZnNfaW8gZmFsbG9jYXRlIDAg NzcwODY3MiA0MDk2IHRlc3RmaWxlCj4+Pj4+Cj4+Pj4+IEFuZCB3aGVuIHdlIG1hcCBmaXJzdCBk YXRhIGJsb2NrIGluIGRub2RlMiwgd2Ugd2lsbCBnZXQgd3JvbmcgZXh0ZW50X2luZm8gZGF0YToK Pj4+Pj4gbWFwLT5tX2xlbiA9IDEKPj4+Pj4gb2ZzID0gc3RhcnRfcGdvZnMgLSBtYXAtPm1fbGJs ayA9IDE4ODIgLSAxODgxID0gMQo+Pj4+Pgo+Pj4+PiBlaS5mb2ZzID0gc3RhcnRfcGdvZnMgPSAx ODgyCj4+Pj4+IGVpLmxlbiA9IG1hcC0+bV9sZW4gLSBvZnMgPSAxIC0gMSA9IDAKPj4+Pj4KPj4+ Pj4gRml4IGl0IGJ5IHNraXBwaW5nIHVwZGF0aW5nIHRoaXMga2luZCBvZiBleHRlbnQgaW5mby4K Pj4+Pj4KPj4+Pj4gU2lnbmVkLW9mZi1ieTogd2FuZ3ppamllIDx3YW5nemlqaWUxQGhvbm9yLmNv bT4KPj4+Pj4gLS0tCj4+Pj4+ICAgIGZzL2YyZnMvZGF0YS5jIHwgMyArKysKPj4+Pj4gICAgMSBm aWxlIGNoYW5nZWQsIDMgaW5zZXJ0aW9ucygrKQo+Pj4+Pgo+Pj4+PiBkaWZmIC0tZ2l0IGEvZnMv ZjJmcy9kYXRhLmMgYi9mcy9mMmZzL2RhdGEuYwo+Pj4+PiBpbmRleCA3OTYxZTBkZGYuLmI4YmI3 MTg1MiAxMDA2NDQKPj4+Pj4gLS0tIGEvZnMvZjJmcy9kYXRhLmMKPj4+Pj4gKysrIGIvZnMvZjJm cy9kYXRhLmMKPj4+Pj4gQEAgLTE2NDksNiArMTY0OSw5IEBAIGludCBmMmZzX21hcF9ibG9ja3Mo c3RydWN0IGlub2RlICppbm9kZSwgc3RydWN0IGYyZnNfbWFwX2Jsb2NrcyAqbWFwLCBpbnQgZmxh ZykKPj4+Pj4gICAgCj4+Pj4+ICAgIAkJc3dpdGNoIChmbGFnKSB7Cj4+Pj4+ICAgIAkJY2FzZSBG MkZTX0dFVF9CTE9DS19QUkVDQUNIRToKPj4+Pj4gKwkJCWlmIChfX2lzX3ZhbGlkX2RhdGFfYmxr YWRkcihtYXAtPm1fcGJsaykgJiYKPj4+Pj4gKwkJCQlzdGFydF9wZ29mcyAtIG1hcC0+bV9sYmxr ID09IG1hcC0+bV9sZW4pCj4+Pj4+ICsJCQkJbWFwLT5tX2ZsYWdzICY9IH5GMkZTX01BUF9NQVBQ RUQ7Cj4+Pj4KPj4+PiBJdCBsb29rcyB3ZSBtaXNzZWQgdG8gcmVzZXQgdmFsdWUgZm9yIG1hcCB2 YXJpYWJsZSBpbiBmMmZzX3ByZWNhY2hlX2V4dGVudHMoKSwKPj4+PiB3aGF0IGRvIHlvdSB0aGlu ayBvZiB0aGlzPwo+Pj4+Cj4+Pj4gLS0tCj4+Pj4gICAgZnMvZjJmcy9maWxlLmMgfCA0ICsrKy0K Pj4+PiAgICAxIGZpbGUgY2hhbmdlZCwgMyBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9uKC0pCj4+ Pj4KPj4+PiBkaWZmIC0tZ2l0IGEvZnMvZjJmcy9maWxlLmMgYi9mcy9mMmZzL2ZpbGUuYwo+Pj4+ IGluZGV4IDFhYWU0MzYxZDBhOC4uMmIxNDE1MWQ0MTMwIDEwMDY0NAo+Pj4+IC0tLSBhL2ZzL2Yy ZnMvZmlsZS5jCj4+Pj4gKysrIGIvZnMvZjJmcy9maWxlLmMKPj4+PiBAQCAtMzU5OSw3ICszNTk5 LDcgQEAgc3RhdGljIGludCBmMmZzX2lvY19pb19wcmlvKHN0cnVjdCBmaWxlICpmaWxwLCB1bnNp Z25lZCBsb25nIGFyZykKPj4+PiAgICBpbnQgZjJmc19wcmVjYWNoZV9leHRlbnRzKHN0cnVjdCBp bm9kZSAqaW5vZGUpCj4+Pj4gICAgewo+Pj4+ICAgIAlzdHJ1Y3QgZjJmc19pbm9kZV9pbmZvICpm aSA9IEYyRlNfSShpbm9kZSk7Cj4+Pj4gLQlzdHJ1Y3QgZjJmc19tYXBfYmxvY2tzIG1hcDsKPj4+ PiArCXN0cnVjdCBmMmZzX21hcF9ibG9ja3MgbWFwID0geyAwIH07Cj4+Pj4gICAgCXBnb2ZmX3Qg bV9uZXh0X2V4dGVudDsKPj4+PiAgICAJbG9mZl90IGVuZDsKPj4+PiAgICAJaW50IGVycjsKPj4+ PiBAQCAtMzYxNyw2ICszNjE3LDggQEAgaW50IGYyZnNfcHJlY2FjaGVfZXh0ZW50cyhzdHJ1Y3Qg aW5vZGUgKmlub2RlKQo+Pj4+Cj4+Pj4gICAgCXdoaWxlIChtYXAubV9sYmxrIDwgZW5kKSB7Cj4+ Pj4gICAgCQltYXAubV9sZW4gPSBlbmQgLSBtYXAubV9sYmxrOwo+Pj4+ICsJCW1hcC5tX3BibGsg PSAwOwo+Pj4+ICsJCW1hcC5tX2ZsYWdzID0gMDsKPj4+Pgo+Pj4+ICAgIAkJZjJmc19kb3duX3dy aXRlKCZmaS0+aV9nY19yd3NlbVtXUklURV0pOwo+Pj4+ICAgIAkJZXJyID0gZjJmc19tYXBfYmxv Y2tzKGlub2RlLCAmbWFwLCBGMkZTX0dFVF9CTE9DS19QUkVDQUNIRSk7Cj4+Pj4gLS0gCj4+Pj4g Mi40OS4wCj4+Pj4KPj4+PiBUaGFua3MsCj4+Pj4KPj4+Pj4gICAgCQkJZ290byBzeW5jX291dDsK Pj4+Pj4gICAgCQljYXNlIEYyRlNfR0VUX0JMT0NLX0JNQVA6Cj4+Pj4+ICAgIAkJCW1hcC0+bV9w YmxrID0gMDsKPj4+Cj4+Pgo+Pj4gV2UgaGF2ZSBhbHJlYWR5IHJlc2V0IG1fZmxhZ3MgKG1hcC0+ bV9mbGFncyA9IDApIGluIGYyZnNfbWFwX2Jsb2NrcygpLgo+Pgo+PiBaaWppZToKPj4KPj4gT29w cywgdGhhdCdzIHJpZ2h0LCB0aGFua3MgZm9yIGNvcnJlY3RpbmcgbWUuCj4+Cj4+Pgo+Pj4gSSB0 aGluayB0aGF0IHRoaXMgYnVnIGlzIGNhdXNlZCBieSB3ZSBtaXNzZWQgdG8gcmVzZXQgbV9mbGFn cyB3aGVuIHdlCj4+PiBnb3RvIG5leHRfZG5vZGUgaW4gYmVsb3cgY2FzZe+8mgo+Pj4KPj4+IERh dGEgbGF5b3V0IGlzIHNvbWV0aGluZyBsaWtlIHRoaXM6Cj4+PiBkbm9kZTE6ICAgICAgICAgICAg ICAgICAgICAgZG5vZGUyOgo+Pj4gWzBdICAgICAgQSAgICAgICAgICAgICAgICAgIFswXSAgICBO RVdfQUREUgo+Pj4gWzFdICAgICAgQSsxICAgICAgICAgICAgICAgIFsxXSAgICAweDAKPj4+IC4u Lgo+Pj4gWzEwMTZdICAgQSsxMDE2Cj4+PiBbMTAxN10gICBCIChCIT1BKzEwMTcpICAgICAgWzEw MTddIDB4MAo+Pj4KPj4+IHdlIG1hcCB0aGUgbGFzdCBibG9jayh2YWxpZCBibGthZGRyKSBpbiBk bm9kZTE6Cj4+PiBtYXAtPm1fZmxhZ3MgfD0gRjJGU19NQVBfTUFQUEVEOwo+Pj4gbWFwLT5tX3Bi bGsgPSBibGthZGRyKHZhbGlkIGJsa2FkZHIpOwo+Pj4gbWFwLT5tX2xlbiA9IDE7Cj4+PiB0aGVu IHdlIGdvdG8gbmV4dF9kbm9kZSwgbWVldCB0aGUgZmlyc3QgYmxvY2sgaW4gZG5vZGUyKGhvbGUp LCBnb3RvIHN5bmNfb3V0Ogo+Pj4gbWFwLT5tX2ZsYWdzICYgRjJGU19NQVBfTUFQUEVEID09IHRy dWUsIGFuZCB3ZSBtYWtlIHdyb25nIGJsa2FkZHIvbGVuIGZvciBleHRlbnRfaW5mby4KPj4KPj4g U28sIGNhbiB5b3UgcGxlYXNlIGFkZCBhYm92ZSBleHBsYW5hdGlvbiBpbnRvIGNvbW1pdCBtZXNz YWdlPyB0aGF0Cj4+IHNob3VsZCBiZSBoZWxwZnVsIGZvciB1bmRlcnN0YW5kaW5nIHRoZSBwcm9i bGVtIG1vcmUgY2xlYXJseS4KPj4KPj4gUGxlYXNlIHRha2UgYSBsb29rIGF0IHRoaXMgY2FzZSB3 LyB5b3VyIHBhdGNoOgo+Pgo+PiBta2ZzLmYyZnMgLU8gZXh0cmFfYXR0cixjb21wcmVzc2lvbiAv ZGV2L3ZkYiAtZgo+PiBtb3VudCAvZGV2L3ZkYiAvbW50L2YyZnMgLW8gbW9kZT1sZnMKPj4gY2Qg L21udC9mMmZzCj4+IGYyZnNfaW8gd3JpdGUgMSAwIDE4ODMgcmFuZCBkc3luYyB0ZXN0ZmlsZQo+ PiBmMmZzX2lvIGZhbGxvY2F0ZSAwIDc3MTI3NjggNDA5NiB0ZXN0ZmlsZQo+PiBmMmZzX2lvIHdy aXRlIDEgMTg4MSAxIHJhbmQgYnVmZmVyZWQgdGVzdGZpbGUKPj4geGZzX2lvIHRlc3RmaWxlIC1j ICJmc3luYyIKPj4gY2QgLwo+PiB1bW91bnQgL21udC9mMmZzCj4+IG1vdW50IC9kZXYvdmRiIC9t bnQvZjJmcwo+PiBmMmZzX2lvIHByZWNhY2hlX2V4dGVudHMgL21udC9mMmZzL3Rlc3RmaWxlCj4+ IHVtb3VudCAvbW50L2YyZnMKPj4KPj4gICAgICAgICAgIGYyZnNfaW8tNzMzICAgICBbMDEwXSAu Li4uLiAgICA3OC4xMzQxMzY6IGYyZnNfdXBkYXRlX3JlYWRfZXh0ZW50X3RyZWVfcmFuZ2U6IGRl diA9ICgyNTMsMTYpLCBpbm8gPSA0LCBwZ29mcyA9IDE4ODIsIGxlbiA9IDAsIGJsa2FkZHIgPSAx NzQxMCwgY19sZW4gPSAwCj4+Cj4+IEkgc3VzcGVjdCB3ZSBuZWVkIHRoaXM/Cj4+Cj4+IEBAIC0x Nzg0LDcgKzE3ODEsOCBAQCBpbnQgZjJmc19tYXBfYmxvY2tzKHN0cnVjdCBpbm9kZSAqaW5vZGUs IHN0cnVjdCBmMmZzX21hcF9ibG9ja3MgKm1hcCwgaW50IGZsYWcpCj4+ICAgICAgICAgIH0KPj4K Pj4gICAgICAgICAgaWYgKGZsYWcgPT0gRjJGU19HRVRfQkxPQ0tfUFJFQ0FDSEUpIHsKPj4gLSAg ICAgICAgICAgICAgIGlmIChtYXAtPm1fZmxhZ3MgJiBGMkZTX01BUF9NQVBQRUQpIHsKPj4gKyAg ICAgICAgICAgICAgIGlmICgobWFwLT5tX2ZsYWdzICYgRjJGU19NQVBfTUFQUEVEKSAmJgo+PiAr ICAgICAgICAgICAgICAgICAgICAgICAobWFwLT5tX2xlbiAtIG9mcykpIHsKPj4gICAgICAgICAg ICAgICAgICAgICAgICAgIHVuc2lnbmVkIGludCBvZnMgPSBzdGFydF9wZ29mcyAtIG1hcC0+bV9s YmxrOwo+Pgo+PiAgICAgICAgICAgICAgICAgICAgICAgICAgZjJmc191cGRhdGVfcmVhZF9leHRl bnRfY2FjaGVfcmFuZ2UoJmRuLAo+IAo+IFRoYW5rcyBmb3IgcG9pbnRpbmcgb3V0IHRoaXMuIExl dCBtZSBmaW5kIGEgd2F5IHRvIGNvdmVyIHRoZXNlIGNhc2VzIGFuZCBkbyBtb3JlIHRlc3QuCj4g Cj4+IEJUVywgSSBmaW5kIGFub3RoZXIgYnVnLCBpZiBvbmUgYmxrYWRkciBpcyBhZGpjZW50IHRv IHByZXZpb3VzIGV4dGVudCwKPj4gYnV0IGFuZCBpdCBpcyB2YWxpZCwgd2UgbmVlZCB0byBzZXQg bV9uZXh0X2V4dGVudCB0byBwZ29mcyByYXRoZXIgdGhhbgo+PiBwZ29mcyArIDEuCj4+Cj4+IGRp ZmYgLS1naXQgYS9mcy9mMmZzL2RhdGEuYyBiL2ZzL2YyZnMvZGF0YS5jCj4+IGluZGV4IGNiZjg4 NDE2NDJjNy4uYWM4OGVkNjgwNTljIDEwMDY0NAo+PiAtLS0gYS9mcy9mMmZzL2RhdGEuYwo+PiAr KysgYi9mcy9mMmZzL2RhdGEuYwo+PiBAQCAtMTc4OSw4ICsxNzg5LDExIEBAIGludCBmMmZzX21h cF9ibG9ja3Moc3RydWN0IGlub2RlICppbm9kZSwgc3RydWN0IGYyZnNfbWFwX2Jsb2NrcyAqbWFw LCBpbnQgZmxhZykKPj4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgc3RhcnRfcGdv ZnMsIG1hcC0+bV9wYmxrICsgb2ZzLAo+PiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICBtYXAtPm1fbGVuIC0gb2ZzKTsKPj4gICAgICAgICAgICAgICAgICB9Cj4+IC0gICAgICAgICAg ICAgICBpZiAobWFwLT5tX25leHRfZXh0ZW50KQo+PiAtICAgICAgICAgICAgICAgICAgICAgICAq bWFwLT5tX25leHRfZXh0ZW50ID0gcGdvZnMgKyAxOwo+PiArICAgICAgICAgICAgICAgaWYgKG1h cC0+bV9uZXh0X2V4dGVudCkgewo+PiArICAgICAgICAgICAgICAgICAgICAgICAqbWFwLT5tX25l eHRfZXh0ZW50ID0gcGdvZnM7Cj4+ICsgICAgICAgICAgICAgICAgICAgICAgIGlmICghX19pc192 YWxpZF9kYXRhX2Jsa2FkZHIoYmxrYWRkcikpCj4+ICsgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgKm1hcC0+bV9uZXh0X2V4dGVudCArPSAxOwo+PiArICAgICAgICAgICAgICAgfQo+PiAg ICAgICAgICB9Cj4+ICAgICAgICAgIGYyZnNfcHV0X2Rub2RlKCZkbik7Cj4gCj4gTWF5YmUgaXQg Y2FuIGJlIHRoaXM/Cj4gaWYgKG1hcC0+bV9uZXh0X2V4dGVudCkKPiAJKm1hcC0+bV9uZXh0X2V4 dGVudCA9IGlzX2hvbGUgPyBwZ29mcyArIDEgOiBwZ29mczsKCkl0J3MgYmV0dGVyLCB3aWxsIHVw ZGF0ZSwgdGhhbmsgeW91LiA6KQoKVGhhbmtzLAoKCgoKX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KTGludXgtZjJmcy1kZXZlbCBtYWlsaW5nIGxpc3QKTGlu dXgtZjJmcy1kZXZlbEBsaXN0cy5zb3VyY2Vmb3JnZS5uZXQKaHR0cHM6Ly9saXN0cy5zb3VyY2Vm b3JnZS5uZXQvbGlzdHMvbGlzdGluZm8vbGludXgtZjJmcy1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4E5DE235041 for ; Fri, 12 Sep 2025 03:41:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757648479; cv=none; b=tzFUgrdFb/3FErjPfpPu3B5RFx28cH5SBcVhzXpaOwYj/ZjjPz2yiw0/q8FLN69BFFkP7wtHkeBML4RyZ531VhrzxhVP5L5Fbcr9dJ0S6NRsaVtRLbaOyfV1pkyKf7K/f5vE7X0v7L7nKODm9kDyBxvA7q6g5SS40Sns6SBQVTM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757648479; c=relaxed/simple; bh=XDwDklRFyhTQ7jpEFuln8g3jtb2GyRw7CB0tY3hlXIE=; h=Message-ID:Date:MIME-Version:Cc:Subject:To:References:From: In-Reply-To:Content-Type; b=oJbFm5AnqfPJAl7OvTL1xY4v7B0M/Q8VFx6XUN2q/jQTYoirsV+tPW9VpqHLy4yJBAP86pAXj2EUN4fKriiwRvhJvX9kqh9TSoBKRY/vVv1tfps014xlYcmVSESz5RB0TaDh/jgHrjircDZxKYKyQZdoGlP28TZXBgQ/4in8bGU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=sCNXCSxi; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="sCNXCSxi" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E7CCCC4CEF4; Fri, 12 Sep 2025 03:41:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1757648479; bh=XDwDklRFyhTQ7jpEFuln8g3jtb2GyRw7CB0tY3hlXIE=; h=Date:Cc:Subject:To:References:From:In-Reply-To:From; b=sCNXCSxisFb6QSyP/WoUcT62/cIWYvK/VB/grwR38wDI1Sc/zVAJwMao5k7iLDyCK o1mYGgOSrEZLBsiWQTejzn1KDItxoTx8YcZx6+91tlXzmz5LySQrWydAl8OoahZyKu 7xGsLY7GlBiHAdXzpfZ0WgYM9rjT7KWmOKZv+3C+BuOxIIG5eN68ulQcV5WpNzhdJe yFyGJEqWFfknz3ChDzIoLvivUztP9hiubrZM4nZaC3GW17vmd0yqVhUZIjNstqorS8 Z/MO/ldNHKNJukHUqo0ApITHY/ghRsevMaAfVhrWKnDNL8vLZNINON+CQzXyOotnV7 FDDbAc2SkU++w== Message-ID: <2ecb4f74-cc60-4dd4-8dc3-d4f3ff848e87@kernel.org> Date: Fri, 12 Sep 2025 11:41:22 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: chao@kernel.org, feng.han@honor.com, jaegeuk@kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: Re: [f2fs-dev] [PATCH 1/2] f2fs: fix wrong extent_info data for precache extents To: wangzijie References: <20250912033609.3033352-1-wangzijie1@honor.com> Content-Language: en-US From: Chao Yu In-Reply-To: <20250912033609.3033352-1-wangzijie1@honor.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 9/12/2025 11:36 AM, wangzijie wrote: >> On 9/11/2025 5:07 PM, wangzijie wrote: >>>> On 9/10/25 21:58, wangzijie wrote: >>>>> When the data layout is like this: >>>>> dnode1: dnode2: >>>>> [0] A [0] NEW_ADDR >>>>> [1] A+1 [1] 0x0 >>>>> ... .... >>>>> [1016] A+1016 >>>>> [1017] B (B!=A+1017) [1017] 0x0 >>>>> >>>>> We can build this kind of layout by following steps(with i_extra_isize:36): >>>>> ./f2fs_io write 1 0 1881 rand dsync testfile >>>>> ./f2fs_io write 1 1881 1 rand buffered testfile >>>>> ./f2fs_io fallocate 0 7708672 4096 testfile >>>>> >>>>> And when we map first data block in dnode2, we will get wrong extent_info data: >>>>> map->m_len = 1 >>>>> ofs = start_pgofs - map->m_lblk = 1882 - 1881 = 1 >>>>> >>>>> ei.fofs = start_pgofs = 1882 >>>>> ei.len = map->m_len - ofs = 1 - 1 = 0 >>>>> >>>>> Fix it by skipping updating this kind of extent info. >>>>> >>>>> Signed-off-by: wangzijie >>>>> --- >>>>> fs/f2fs/data.c | 3 +++ >>>>> 1 file changed, 3 insertions(+) >>>>> >>>>> diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c >>>>> index 7961e0ddf..b8bb71852 100644 >>>>> --- a/fs/f2fs/data.c >>>>> +++ b/fs/f2fs/data.c >>>>> @@ -1649,6 +1649,9 @@ int f2fs_map_blocks(struct inode *inode, struct f2fs_map_blocks *map, int flag) >>>>> >>>>> switch (flag) { >>>>> case F2FS_GET_BLOCK_PRECACHE: >>>>> + if (__is_valid_data_blkaddr(map->m_pblk) && >>>>> + start_pgofs - map->m_lblk == map->m_len) >>>>> + map->m_flags &= ~F2FS_MAP_MAPPED; >>>> >>>> It looks we missed to reset value for map variable in f2fs_precache_extents(), >>>> what do you think of this? >>>> >>>> --- >>>> fs/f2fs/file.c | 4 +++- >>>> 1 file changed, 3 insertions(+), 1 deletion(-) >>>> >>>> diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c >>>> index 1aae4361d0a8..2b14151d4130 100644 >>>> --- a/fs/f2fs/file.c >>>> +++ b/fs/f2fs/file.c >>>> @@ -3599,7 +3599,7 @@ static int f2fs_ioc_io_prio(struct file *filp, unsigned long arg) >>>> int f2fs_precache_extents(struct inode *inode) >>>> { >>>> struct f2fs_inode_info *fi = F2FS_I(inode); >>>> - struct f2fs_map_blocks map; >>>> + struct f2fs_map_blocks map = { 0 }; >>>> pgoff_t m_next_extent; >>>> loff_t end; >>>> int err; >>>> @@ -3617,6 +3617,8 @@ int f2fs_precache_extents(struct inode *inode) >>>> >>>> while (map.m_lblk < end) { >>>> map.m_len = end - map.m_lblk; >>>> + map.m_pblk = 0; >>>> + map.m_flags = 0; >>>> >>>> f2fs_down_write(&fi->i_gc_rwsem[WRITE]); >>>> err = f2fs_map_blocks(inode, &map, F2FS_GET_BLOCK_PRECACHE); >>>> -- >>>> 2.49.0 >>>> >>>> Thanks, >>>> >>>>> goto sync_out; >>>>> case F2FS_GET_BLOCK_BMAP: >>>>> map->m_pblk = 0; >>> >>> >>> We have already reset m_flags (map->m_flags = 0) in f2fs_map_blocks(). >> >> Zijie: >> >> Oops, that's right, thanks for correcting me. >> >>> >>> I think that this bug is caused by we missed to reset m_flags when we >>> goto next_dnode in below caseļ¼š >>> >>> Data layout is something like this: >>> dnode1: dnode2: >>> [0] A [0] NEW_ADDR >>> [1] A+1 [1] 0x0 >>> ... >>> [1016] A+1016 >>> [1017] B (B!=A+1017) [1017] 0x0 >>> >>> we map the last block(valid blkaddr) in dnode1: >>> map->m_flags |= F2FS_MAP_MAPPED; >>> map->m_pblk = blkaddr(valid blkaddr); >>> map->m_len = 1; >>> then we goto next_dnode, meet the first block in dnode2(hole), goto sync_out: >>> map->m_flags & F2FS_MAP_MAPPED == true, and we make wrong blkaddr/len for extent_info. >> >> So, can you please add above explanation into commit message? that >> should be helpful for understanding the problem more clearly. >> >> Please take a look at this case w/ your patch: >> >> mkfs.f2fs -O extra_attr,compression /dev/vdb -f >> mount /dev/vdb /mnt/f2fs -o mode=lfs >> cd /mnt/f2fs >> f2fs_io write 1 0 1883 rand dsync testfile >> f2fs_io fallocate 0 7712768 4096 testfile >> f2fs_io write 1 1881 1 rand buffered testfile >> xfs_io testfile -c "fsync" >> cd / >> umount /mnt/f2fs >> mount /dev/vdb /mnt/f2fs >> f2fs_io precache_extents /mnt/f2fs/testfile >> umount /mnt/f2fs >> >> f2fs_io-733 [010] ..... 78.134136: f2fs_update_read_extent_tree_range: dev = (253,16), ino = 4, pgofs = 1882, len = 0, blkaddr = 17410, c_len = 0 >> >> I suspect we need this? >> >> @@ -1784,7 +1781,8 @@ int f2fs_map_blocks(struct inode *inode, struct f2fs_map_blocks *map, int flag) >> } >> >> if (flag == F2FS_GET_BLOCK_PRECACHE) { >> - if (map->m_flags & F2FS_MAP_MAPPED) { >> + if ((map->m_flags & F2FS_MAP_MAPPED) && >> + (map->m_len - ofs)) { >> unsigned int ofs = start_pgofs - map->m_lblk; >> >> f2fs_update_read_extent_cache_range(&dn, > > Thanks for pointing out this. Let me find a way to cover these cases and do more test. > >> BTW, I find another bug, if one blkaddr is adjcent to previous extent, >> but and it is valid, we need to set m_next_extent to pgofs rather than >> pgofs + 1. >> >> diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c >> index cbf8841642c7..ac88ed68059c 100644 >> --- a/fs/f2fs/data.c >> +++ b/fs/f2fs/data.c >> @@ -1789,8 +1789,11 @@ int f2fs_map_blocks(struct inode *inode, struct f2fs_map_blocks *map, int flag) >> start_pgofs, map->m_pblk + ofs, >> map->m_len - ofs); >> } >> - if (map->m_next_extent) >> - *map->m_next_extent = pgofs + 1; >> + if (map->m_next_extent) { >> + *map->m_next_extent = pgofs; >> + if (!__is_valid_data_blkaddr(blkaddr)) >> + *map->m_next_extent += 1; >> + } >> } >> f2fs_put_dnode(&dn); > > Maybe it can be this? > if (map->m_next_extent) > *map->m_next_extent = is_hole ? pgofs + 1 : pgofs; It's better, will update, thank you. :) Thanks,