All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Peng Yu <yupeng0921@gmail.com>
Cc: "Christoph Hellwig" <hch@lst.de>,
	"Sagi Grimberg" <sagi@grimberg.me>,
	"Chaitanya Kulkarni" <kch@nvidia.com>,
	"Johannes Weiner" <hannes@cmpxchg.org>,
	"Michal Koutný" <mkoutny@suse.com>,
	"Josef Bacik" <josef@toxicpanda.com>,
	"Jens Axboe" <axboe@kernel.dk>,
	"Maurizio Lombardi" <mlombard@arkamax.eu>,
	cgroups@vger.kernel.org, linux-block@vger.kernel.org,
	linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 1/2] cgroup: export cgroup_e_css()
Date: Sat, 26 Sep 2026 07:38:12 -1000	[thread overview]
Message-ID: <2edc9a06c00cc96958723d0e09803104@kernel.org> (raw)
In-Reply-To: <20260926063328.257023-2-yupeng0921@gmail.com>

Hello, Peng.

On Fri, Sep 25, 2026 at 11:33:27PM -0700, Peng Yu wrote:
> The nvmet invokes the cgroup_e_css for each bio and under
> the rcu protection.

cgroup_e_css() walks up the hierarchy to find the effective css, and I
don't think we want to do that on every IO. Can you update cgroup core to
track the effective css in each cgroup and make cgroup_e_css() use that
instead?

Thanks.

-- 
tejun


  reply	other threads:[~2026-09-26 17:39 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-26  6:33 [PATCH v5 0/2] nvmet: add cgroup_id to charge namespace I/O to a cgroup Peng Yu
2026-09-26  6:33 ` [PATCH v5 1/2] cgroup: export cgroup_e_css() Peng Yu
2026-09-26 17:38   ` Tejun Heo [this message]
2026-09-26  6:33 ` [PATCH v5 2/2] nvmet: add cgroup_id to charge namespace I/O to a cgroup Peng Yu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2edc9a06c00cc96958723d0e09803104@kernel.org \
    --to=tj@kernel.org \
    --cc=axboe@kernel.dk \
    --cc=cgroups@vger.kernel.org \
    --cc=hannes@cmpxchg.org \
    --cc=hch@lst.de \
    --cc=josef@toxicpanda.com \
    --cc=kch@nvidia.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=mkoutny@suse.com \
    --cc=mlombard@arkamax.eu \
    --cc=sagi@grimberg.me \
    --cc=yupeng0921@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.