From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AFE97C35242 for ; Tue, 11 Feb 2020 21:13:04 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3C2DA20708 for ; Tue, 11 Feb 2020 21:13:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="vcWoj/nV" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3C2DA20708 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 699E283E; Tue, 11 Feb 2020 22:12:12 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 699E283E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1581455582; bh=LHyDNljAHyOIibs8J+g3GlHvcWcShdQQgAxmP6D9p9Y=; h=To:References:From:Date:In-Reply-To:Cc:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=vcWoj/nV6Um3EIjussSdcuGMU3vFY5+gkv19gF8iEcbgmVnVMJXC4fgN3jrBWzmJH iBq6TAD/yIWPGVnMZAppkjixZxfxe/awWjqmlgvR2cSLNs/1NscyRWcgQmjSlHkUQL pDVZWbCMGxuFj4+ixWrPrWRvF5ndYFN+A7a3fqKQ= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id DB19DF8013E; Tue, 11 Feb 2020 22:12:11 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 150C5F80145; Tue, 11 Feb 2020 22:12:10 +0100 (CET) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 8AE66F800F0 for ; Tue, 11 Feb 2020 22:12:05 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 8AE66F800F0 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Feb 2020 13:12:02 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,428,1574150400"; d="scan'208";a="256603823" Received: from lmgarret-mobl2.amr.corp.intel.com (HELO [10.251.152.253]) ([10.251.152.253]) by fmsmga004.fm.intel.com with ESMTP; 11 Feb 2020 13:12:01 -0800 To: "Sridharan, Ranjani" References: <1581322611-25695-1-git-send-email-brent.lu@intel.com> <855c88fb-4438-aefb-ac9b-a9a5a2dc8caa@linux.intel.com> From: Pierre-Louis Bossart Message-ID: <2eeca7fe-aec9-c680-5d61-930de18b952b@linux.intel.com> Date: Tue, 11 Feb 2020 15:12:01 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US Cc: "alsa-devel@alsa-project.org" , Support Opensource , Takashi Iwai , Liam Girdwood , "linux-kernel@vger.kernel.org" , "Chiang, Mac" , Mark Brown , Ranjani Sridharan , Adam Thomson , "Lu, Brent" , "cychiang@google.com" Subject: Re: [alsa-devel] [PATCH] ASoC: da7219: check SRM lock in trigger callback X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" CgpPbiAyLzExLzIwIDI6MzcgUE0sIFNyaWRoYXJhbiwgUmFuamFuaSB3cm90ZToKPiAKPiAgICAg ID4gSSB0aGluayB0aGUgcGF0Y2ggaXMgZm9yIHRob3NlIHN5c3RlbXMgd2hpY2ggZW5hYmxlIEky UyBjbG9ja3MgaW4KPiAgICAgcGNtX3N0YXJ0IGluc3RlYWQKPiAgICAgID4gb2YgcGNtX3ByZXBh cmUuIEl0IGhhcyBubyBlZmZlY3Qgb24gc3lzdGVtcyBhbHJlYWR5IGJlIGFibGUgdG8KPiAgICAg dHVybiBvbiBjbG9ja3MgaW4KPiAgICAgID4gc3VwcGx5IHdpZGdldHMgb3Igc2V0X2JpYXNfbGV2 ZWwoKSBmdW5jdGlvbi4KPiAgICAgID4KPiAgICAgID4gSWYgdGhlIHRyaWdnZXIgdHlwZSBpbiB0 aGUgREFJIGxpbmsgaXMgVFJJR0dFUl9QUkUsIHRoZW4gdGhlCj4gICAgIHRyaWdnZXIgZnVuY3Rp b24gb2YgRkUgcG9ydAo+ICAgICAgPiAoY29tcG9uZW50IG9yIENQVSBEQUkpIHdpbGwgYmUgY2Fs bGVkIGJlZm9yZSBjb2RlYyBkcml2ZXIncwo+ICAgICB0cmlnZ2VyIGZ1bmN0aW9uLiBJbiB0aGlz Cj4gICAgICA+IGNhc2Ugd2Ugd2lsbCBiZSBhYmxlIHRvIHR1cm4gb24gdGhlIGNsb2NrIGluIHRp bWUuIEhvd2V2ZXIsIGlmCj4gICAgIHRoZSB0cmlnZ2VyIHR5cGUgaXMKPiAgICAgID4gVFJJR0dF Ul9QT1NULCB0aGVuIHRoZSBwYXRjaCBkb2VzIG5vdCBoZWxwIGJlY2F1c2UganVzdCBsaWtlIHdo YXQKPiAgICAgeW91IHNhaWQsIGNvZGVjCj4gICAgICA+IGRyaXZlcidzIHRyaWdnZXIgZnVuY3Rp b24gaXMgY2FsbGVkIGZpcnN0Lgo+IAo+ICAgICBJSVJDIHdlIHJlY2VudGx5IGRpZCBhIGNoYW5n ZSB0byBkZWFsIHdpdGggdW5kZXJmbG93cy4gUmFuamFuaSwgY2FuIHlvdQo+ICAgICByZW1pbmQg dXMgd2hhdCB0aGUgaXNzdWUgd2FzPwo+IAo+IEhpIFBpZXJyZSwKPiAKPiBBcmUgeW91IHRhbGtp bmcgYWJvdXQgdGhlIGNoYW5nZSBpbiB0aGlzIGNvbW1pdMKgYWNiZjI3NzQ2ZWNmYTk2Ygo+ICJB U29DOiBwY206IHVwZGF0ZSBGRS9CRSB0cmlnZ2VyIG9yZGVyIGJhc2VkIG9uIHRoZSBjb21tYW5k Ij8KPiAKPiBXZSBtYWRlIHRoaXMgY2hhbmdlIHRvIGhhbmRsZSB4cnVucyBkdXJpbmcgcGF1c2Uv cmVsZWFzZSBwYXJ0aWN1bGFybHkgb24gCj4gdGhlIEludGVsIEhEQSBwbGF0Zm9ybXMuCgp0aGlz IGNoYW5nZSB3YXMganVzdCB0byBtaXJyb3IgdGhlIGJlaGF2aW9yIGJldHdlZW4gc3RhcnQvc3Rv cCwgSSAKdGhvdWdodCB0aGVyZSB3YXMgYSBwYXRjaCB3aGVyZSB3ZSBtb3ZlZCB0byBUUklHR0VS X1BPU1QgYnkgZGVmYXVsdD8KCldoYXQgSSBhbSB0cnlpbmcgdG8gZmlndXJlIG91dCBpZiB3aGV0 aGVyIHVzaW5nIFRSSUdHRVJfUFJFIGlzIG9rIG9yIG5vdCAKZm9yIHRoZSBTT0YgZmlybXdhcmUu CgpUaGFua3MhCi1QaWVycmUKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX18KQWxzYS1kZXZlbCBtYWlsaW5nIGxpc3QKQWxzYS1kZXZlbEBhbHNhLXByb2plY3Qu b3JnCmh0dHBzOi8vbWFpbG1hbi5hbHNhLXByb2plY3Qub3JnL21haWxtYW4vbGlzdGluZm8vYWxz YS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BCC7FC35242 for ; Tue, 11 Feb 2020 21:12:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9C1AA20708 for ; Tue, 11 Feb 2020 21:12:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731102AbgBKVMD (ORCPT ); Tue, 11 Feb 2020 16:12:03 -0500 Received: from mga03.intel.com ([134.134.136.65]:13437 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728078AbgBKVMD (ORCPT ); Tue, 11 Feb 2020 16:12:03 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Feb 2020 13:12:02 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,428,1574150400"; d="scan'208";a="256603823" Received: from lmgarret-mobl2.amr.corp.intel.com (HELO [10.251.152.253]) ([10.251.152.253]) by fmsmga004.fm.intel.com with ESMTP; 11 Feb 2020 13:12:01 -0800 Subject: Re: [alsa-devel] [PATCH] ASoC: da7219: check SRM lock in trigger callback To: "Sridharan, Ranjani" Cc: "Lu, Brent" , Adam Thomson , "alsa-devel@alsa-project.org" , Support Opensource , Liam Girdwood , "linux-kernel@vger.kernel.org" , Takashi Iwai , "Chiang, Mac" , Mark Brown , Ranjani Sridharan , "cychiang@google.com" References: <1581322611-25695-1-git-send-email-brent.lu@intel.com> <855c88fb-4438-aefb-ac9b-a9a5a2dc8caa@linux.intel.com> From: Pierre-Louis Bossart Message-ID: <2eeca7fe-aec9-c680-5d61-930de18b952b@linux.intel.com> Date: Tue, 11 Feb 2020 15:12:01 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/11/20 2:37 PM, Sridharan, Ranjani wrote: > > > I think the patch is for those systems which enable I2S clocks in > pcm_start instead > > of pcm_prepare. It has no effect on systems already be able to > turn on clocks in > > supply widgets or set_bias_level() function. > > > > If the trigger type in the DAI link is TRIGGER_PRE, then the > trigger function of FE port > > (component or CPU DAI) will be called before codec driver's > trigger function. In this > > case we will be able to turn on the clock in time. However, if > the trigger type is > > TRIGGER_POST, then the patch does not help because just like what > you said, codec > > driver's trigger function is called first. > > IIRC we recently did a change to deal with underflows. Ranjani, can you > remind us what the issue was? > > Hi Pierre, > > Are you talking about the change in this commit acbf27746ecfa96b > "ASoC: pcm: update FE/BE trigger order based on the command"? > > We made this change to handle xruns during pause/release particularly on > the Intel HDA platforms. this change was just to mirror the behavior between start/stop, I thought there was a patch where we moved to TRIGGER_POST by default? What I am trying to figure out if whether using TRIGGER_PRE is ok or not for the SOF firmware. Thanks! -Pierre