From: Jacek Anaszewski <jacek.anaszewski@gmail.com>
To: Krzysztof Kozlowski <krzk@kernel.org>,
Pavel Machek <pavel@ucw.cz>, Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Raphael Teysseyre <rteysseyre@gmail.com>,
Baolin Wang <baolin.wang@linaro.org>,
linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH v4 2/5] leds: Add helper for getting default pattern from Device Tree
Date: Thu, 27 Dec 2018 20:29:33 +0100 [thread overview]
Message-ID: <2efcaaa2-61ef-c967-dacc-8aff51c17840@gmail.com> (raw)
In-Reply-To: <CAJKOXPew1Ufq8vOE2=dqh-=zCQpB8H-X+CEK456MqgcEsNi+5A@mail.gmail.com>
On 12/27/18 9:47 AM, Krzysztof Kozlowski wrote:
> On Tue, 18 Dec 2018 at 16:27, Krzysztof Kozlowski <krzk@kernel.org> wrote:
>>
>> Multiple LED triggers might need to access default pattern so add a
>> helper for that.
>>
>> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
>> ---
>> drivers/leds/led-class.c | 42 ++++++++++++++++++++++++++++++++++++++++++
>
> As pointed out by 0day-ci this has to be in leds-core.c.
>
> I'll fix it.
Right, please also remove "classdev" from the new API name.
--
Best regards,
Jacek Anaszewski
next prev parent reply other threads:[~2018-12-27 19:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-18 15:27 [PATCH v4 0/5] leds: trigger: Add pattern initialization from Device Tree Krzysztof Kozlowski
2018-12-18 15:27 ` [PATCH v4 1/5] dt-bindings: leds: " Krzysztof Kozlowski
2018-12-18 15:27 ` [PATCH v4 2/5] leds: Add helper for getting default pattern " Krzysztof Kozlowski
2018-12-27 8:47 ` Krzysztof Kozlowski
2018-12-27 19:29 ` Jacek Anaszewski [this message]
2018-12-18 15:27 ` [PATCH v4 3/5] leds: trigger: pattern: Add pattern initialization " Krzysztof Kozlowski
2018-12-18 15:27 ` [PATCH v4 4/5] leds: trigger: oneshot: Add " Krzysztof Kozlowski
2018-12-18 15:27 ` [PATCH v4 5/5] leds: trigger: timer: " Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2efcaaa2-61ef-c967-dacc-8aff51c17840@gmail.com \
--to=jacek.anaszewski@gmail.com \
--cc=baolin.wang@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
--cc=rteysseyre@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.