From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 41DA2C433F5 for ; Mon, 23 May 2022 21:13:21 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 2650E84250; Mon, 23 May 2022 23:13:16 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="bxiC6ObR"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 87606841AD; Mon, 23 May 2022 23:13:13 +0200 (CEST) Received: from mail-ej1-x631.google.com (mail-ej1-x631.google.com [IPv6:2a00:1450:4864:20::631]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id CB488841A5 for ; Mon, 23 May 2022 23:13:07 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=alpernebiyasak@gmail.com Received: by mail-ej1-x631.google.com with SMTP id ck4so27131044ejb.8 for ; Mon, 23 May 2022 14:13:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:from:subject:to:cc :references:content-language:in-reply-to:content-transfer-encoding; bh=DFED9d0TW1kTUd2fZwuKfQg0ofUYXZslkS/pF4Dv3Hw=; b=bxiC6ObRceglSYQybPChWQ/jzHgp2A0txGD6LJ6Ilm/VD5FF6Ztkjem3eN03XmrvZ1 KtdcJWJ32lqvOQ9XgeBgGklYZbjUyRjfS2oWZmAzEbPIYadtcf/zHfXMA+/yOB7CkNpj lYQqxrBwKGmFsBog96r10jUKpUUR1CKKYsFkESQ2FLSAz5eb86EJLXqzBDLwFBY56zS/ 2AA8uLzTTiiEBFreQ2iOVBTCcCISW32UbZc3WRp/R4NcgbZC1y9BG+WEF29bWQP4UMYM c6LFShBIIqdIPuFLvMM67sCPjkBCK8wC0Lo+TSm1keDjXa/OeI44DepgPhCGdVTbsc/P ZuYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:from :subject:to:cc:references:content-language:in-reply-to :content-transfer-encoding; bh=DFED9d0TW1kTUd2fZwuKfQg0ofUYXZslkS/pF4Dv3Hw=; b=aMdSWEdlJ392SstlLYsHmVLnru1iOmPMPbknFdYXsr9DtVd16ei4euSPhTF59faQqr uw7yrBpoXGOPQxfY3y2mMVI6E/LEdpNjrQ4Kmlp8DjNNOjrlxc2pQbXGTXV3P1mxAbJd THzTtodsiDkWSlcx7fLBO2CUHvft0kTZ1w/CtZ0loHgG/oNIDpWz3kJ5oK90k8ZG/PKq qGu3os8NpUkPLbn7Il7kGREji1fPXA/S50pd5fVo+jd3g2QIfix0cOJRln6vlzon3ceo PFEF2mnScW1BSgc43UATHXnTMEyk/435vtZjvSkD2pZFFlaHUsfThxwdINJvsbdRvfqe /2BQ== X-Gm-Message-State: AOAM531DG5ww6wAod9THBXOBaOi7Rw7OrmfJMIfpiuGgrC1YOIQsNIwn DZUAz9+QYWUYfINpPJhMp8s= X-Google-Smtp-Source: ABdhPJxTkKsE9ouwYdTJ0j1s6ZY4vDSAZeSOIq8oqffOvw2a/t1kjtRMk/nUWMtnnD3MwZGR+e1QyA== X-Received: by 2002:a17:907:a40b:b0:6fe:7c67:2210 with SMTP id sg11-20020a170907a40b00b006fe7c672210mr21280541ejc.341.1653340387137; Mon, 23 May 2022 14:13:07 -0700 (PDT) Received: from [192.168.0.74] ([178.233.178.185]) by smtp.gmail.com with ESMTPSA id r22-20020a170906351600b006f3ef214ddcsm2567998eja.66.2022.05.23.14.13.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 23 May 2022 14:13:06 -0700 (PDT) Message-ID: <2f0e73f4-054d-c5b6-7710-fb7147123450@gmail.com> Date: Tue, 24 May 2022 00:10:24 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 From: Alper Nebi Yasak Subject: Re: [PATCH V4 1/8] spl: guard u_boot_any with X86 To: Tom Rini , "Peng Fan (OSS)" Cc: "sbabic@denx.de" , "festevam@gmail.com" , "ariel.dalessandro@collabora.com" , "michael@amarulasolutions.com" , "tharvey@gateworks.com" , "sjg@chromium.org" , "marek.behun@nic.cz" , "pali@kernel.org" , "sr@denx.de" , Ricardo Salveti , "patrick.delaunay@foss.st.com" , "u-boot@lists.denx.de" References: <20220520141048.20034-1-peng.fan@oss.nxp.com> <20220520141048.20034-2-peng.fan@oss.nxp.com> <20220520152127.GC13239@bill-the-cat> <20220521120518.GI13239@bill-the-cat> <20220523141027.GM13239@bill-the-cat> Content-Language: en-US In-Reply-To: <20220523141027.GM13239@bill-the-cat> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean On 23/05/2022 17:10, Tom Rini wrote: > On Mon, May 23, 2022 at 06:28:44AM +0000, Peng Fan (OSS) wrote: >>> Subject: Re: [PATCH V4 1/8] spl: guard u_boot_any with X86 >>> >>> Why are you mentioning LTO in the commit message? When I read the >>> commit message it sounds like you're saying the problem is that LTO doesn't >>> like how this symbol is handled, but if LTO was disabled, everything would be >>> fine. If it's not LTO-related, please re-word the message instead. >> >> Sorry, I could reword the commit message, but currently I have no better >> idea to address the issue unless use X86 as a guard in the code as this >> patch does. If you agree the code in this patch, I could reword commit msg >> and send v5. > > Well, lets see what Alper says in the other part of the thread. I'd > really like to solve this not work around this. But I'll take > documenting the problem for the person that has X86 && LTO as good > enough for the moment. Alternatively, I think we can decide that all binman symbols are optional, and not raise an error when we can't find a value for them. They are de-facto optional anyway: people can use the non-binman-image build artifacts (which binman doesn't update wrt. symbols), thus the code that uses binman symbols should assume their values can be missing.