From: "David Hildenbrand (Arm)" <david@kernel.org>
To: John Hubbard <jhubbard@nvidia.com>,
Sarthak Sharma <sarthak.sharma@arm.com>,
Mark Brown <broonie@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Lorenzo Stoakes <ljs@kernel.org>,
"Liam R . Howlett" <liam@infradead.org>,
Vlastimil Babka <vbabka@kernel.org>,
Mike Rapoport <rppt@kernel.org>,
Suren Baghdasaryan <surenb@google.com>,
Michal Hocko <mhocko@suse.com>, Shuah Khan <shuah@kernel.org>,
Shuah Khan <skhan@linuxfoundation.org>,
Jason Gunthorpe <jgg@ziepe.ca>, Peter Xu <peterx@redhat.com>,
Leon Romanovsky <leon@kernel.org>, Zi Yan <ziy@nvidia.com>,
Baolin Wang <baolin.wang@linux.alibaba.com>,
Nico Pache <npache@redhat.com>,
Ryan Roberts <ryan.roberts@arm.com>, Dev Jain <dev.jain@arm.com>,
Barry Song <baohua@kernel.org>, Lance Yang <lance.yang@linux.dev>,
Jonathan Corbet <corbet@lwn.net>,
Anshuman Khandual <anshuman.khandual@arm.com>,
linux-mm@kvack.org, linux-kselftest@vger.kernel.org,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 1/5] selftests/mm: make file helpers return errors
Date: Mon, 27 Jul 2026 19:49:04 +0200 [thread overview]
Message-ID: <2f0eded6-5885-485e-baad-01d13080dc76@kernel.org> (raw)
In-Reply-To: <4ad4c2f0-aa6b-435d-b649-a8320a418730@nvidia.com>
On 7/22/26 20:57, John Hubbard wrote:
> On 7/21/26 10:24 PM, Sarthak Sharma wrote:
>> Hi David and Mark!
>>
>> On 7/21/26 8:24 PM, David Hildenbrand (Arm) wrote:
>>>
>>>
>>> Right, and if we want to move this to tools/lib/mm later, maybe we can just not
>>> print anything and instead only return expressive errnos.
>>>
>>
>> Yes, we are not using ksft_* prints here because these functions move to
>> tools/lib/mm later in the series.
>>
>> Printing errors from the helpers was suggested by Mike [1]. I also think
>> this is useful since the diagnostic handling stays at one place, instead
>> of duplicating it in every caller.
>
> This is a common pitfall. In fact, the lower ("leaf") routines, *especially*
> library-like functions that are called by disparate callers, should be
> usually be silent.
Yes, agreed!
--
Cheers,
David
next prev parent reply other threads:[~2026-07-27 17:49 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-16 12:32 [PATCH v5 0/5] selftests/mm: separate GUP microbenchmarking from functional testing Sarthak Sharma
2026-07-16 12:32 ` [PATCH v5 1/5] selftests/mm: make file helpers return errors Sarthak Sharma
2026-07-21 13:39 ` David Hildenbrand (Arm)
2026-07-21 13:48 ` Mark Brown
2026-07-21 14:54 ` David Hildenbrand (Arm)
2026-07-22 5:24 ` Sarthak Sharma
2026-07-22 18:57 ` John Hubbard
2026-07-27 17:49 ` David Hildenbrand (Arm) [this message]
2026-07-16 12:32 ` [PATCH v5 2/5] tools/lib/mm: add shared file helpers Sarthak Sharma
2026-07-16 12:32 ` [PATCH v5 3/5] tools/lib/mm: move hugepage_settings out of selftests Sarthak Sharma
2026-07-16 12:32 ` [PATCH v5 4/5] tools/mm: add a standalone GUP microbenchmark Sarthak Sharma
2026-07-21 13:52 ` David Hildenbrand (Arm)
2026-07-22 4:38 ` Sarthak Sharma
2026-07-27 17:49 ` David Hildenbrand (Arm)
2026-07-24 12:05 ` Dev Jain
2026-07-27 17:51 ` David Hildenbrand (Arm)
2026-07-16 12:32 ` [PATCH v5 5/5] selftests/mm: rewrite gup_test as a standalone harness-based selftest Sarthak Sharma
2026-07-20 12:01 ` [PATCH v5 0/5] selftests/mm: separate GUP microbenchmarking from functional testing Sarthak Sharma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2f0eded6-5885-485e-baad-01d13080dc76@kernel.org \
--to=david@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=anshuman.khandual@arm.com \
--cc=baohua@kernel.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=broonie@kernel.org \
--cc=corbet@lwn.net \
--cc=dev.jain@arm.com \
--cc=jgg@ziepe.ca \
--cc=jhubbard@nvidia.com \
--cc=lance.yang@linux.dev \
--cc=leon@kernel.org \
--cc=liam@infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ljs@kernel.org \
--cc=mhocko@suse.com \
--cc=npache@redhat.com \
--cc=peterx@redhat.com \
--cc=rppt@kernel.org \
--cc=ryan.roberts@arm.com \
--cc=sarthak.sharma@arm.com \
--cc=shuah@kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=surenb@google.com \
--cc=vbabka@kernel.org \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.