All of lore.kernel.org
 help / color / mirror / Atom feed
From: "KOSAKI Motohiro" <m-kosaki@ceres.dti.ne.jp>
To: "Balbir Singh" <balbir@linux.vnet.ibm.com>
Cc: "Andrew Morton" <akpm@linux-foundation.org>,
	"YAMAMOTO Takashi" <yamamoto@valinux.co.jp>,
	"Paul Menage" <menage@google.com>,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	"Pavel Emelianov" <xemul@openvz.org>,
	"KAMEZAWA Hiroyuki" <kamezawa.hiroyu@jp.fujitsu.com>
Subject: Re: [-mm] Make the memory controller more desktop responsive (v2)
Date: Fri, 4 Apr 2008 23:01:45 +0900	[thread overview]
Message-ID: <2f11576a0804040701s5b6267b0w430c29b5010bf841@mail.gmail.com> (raw)
In-Reply-To: <20080404132116.5217.14401.sendpatchset@localhost.localdomain>

Hi

>  @@ -612,7 +611,7 @@ retry:
>         pc->page = page;
>         pc->flags = PAGE_CGROUP_FLAG_ACTIVE;
>         if (ctype == MEM_CGROUP_CHARGE_TYPE_CACHE)
>  -               pc->flags |= PAGE_CGROUP_FLAG_CACHE;
>  +               pc->flags = PAGE_CGROUP_FLAG_CACHE;
>
>         lock_page_cgroup(page);
>         if (page_get_page_cgroup(page)) {

Yes.
in general, cache page create as cold page.
if not, large file copy or streaming file drop all cache easily.

Reviewd-by: KOSAKI

  reply	other threads:[~2008-04-04 14:01 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-04 13:21 [-mm] Make the memory controller more desktop responsive (v2) Balbir Singh
2008-04-04 14:01 ` KOSAKI Motohiro [this message]
2008-04-04 14:02   ` KOSAKI Motohiro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2f11576a0804040701s5b6267b0w430c29b5010bf841@mail.gmail.com \
    --to=m-kosaki@ceres.dti.ne.jp \
    --cc=akpm@linux-foundation.org \
    --cc=balbir@linux.vnet.ibm.com \
    --cc=kamezawa.hiroyu@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=menage@google.com \
    --cc=xemul@openvz.org \
    --cc=yamamoto@valinux.co.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.