From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755105AbYJZNiB (ORCPT ); Sun, 26 Oct 2008 09:38:01 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752918AbYJZNhx (ORCPT ); Sun, 26 Oct 2008 09:37:53 -0400 Received: from wa-out-1112.google.com ([209.85.146.177]:51547 "EHLO wa-out-1112.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752566AbYJZNhw (ORCPT ); Sun, 26 Oct 2008 09:37:52 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version :content-type:content-transfer-encoding:content-disposition :references:x-google-sender-auth; b=UoWKfLPHZZ014hW98M738oryIkE5PFrNcQ1X12vbA4CQICLO1AmKLZAH4ZwRGJYMOl +JnKIKcvUF1Y2nB4L0LxUdqIBg6gbEY4n1OdnGOY+8a2lhUDWKzPLgLOTVaF5v+VmuR9 ZNWmaybbxxM9Fg7gBYBrrNdUrtckozonDNVr8= Message-ID: <2f11576a0810260637q21eaec62q4e2662742541e771@mail.gmail.com> Date: Sun, 26 Oct 2008 22:37:50 +0900 From: "KOSAKI Motohiro" To: "Peter Zijlstra" Subject: Re: [RFC][PATCH] lru_add_drain_all() don't use schedule_on_each_cpu() Cc: "Heiko Carstens" , "Nick Piggin" , linux-kernel@vger.kernel.org, "Hugh Dickins" , "Andrew Morton" , "Linus Torvalds" , "Rik van Riel" , "Lee Schermerhorn" , linux-mm@kvack.org, "Christoph Lameter" , "Gautham Shenoy" , "Oleg Nesterov" , "Rusty Russell" In-Reply-To: <1225019176.32713.5.camel@twins> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <2f11576a0810210851g6e0d86benef5d801871886dd7@mail.gmail.com> <2f11576a0810211018g5166c1byc182f1194cfdd45d@mail.gmail.com> <20081023235425.9C40.KOSAKI.MOTOHIRO@jp.fujitsu.com> <1225019176.32713.5.camel@twins> X-Google-Sender-Auth: eff5a3f8cbcdde55 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Peter, >> @@ -611,4 +613,8 @@ void __init swap_setup(void) >> #ifdef CONFIG_HOTPLUG_CPU >> hotcpu_notifier(cpu_swap_callback, 0); >> #endif >> + >> + vm_wq = create_workqueue("vm_work"); >> + BUG_ON(!vm_wq); >> + >> } > > While I really hate adding yet another per-cpu thread for this, I don't > see another way out atm. Can I ask the reason of your hate? if I don't know it, making improvement patch is very difficult to me. > Oleg, Rusty, ego, you lot were discussing a similar extra per-cpu > workqueue, can we merge these two? From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by rv-out-0708.google.com with SMTP id f25so1447861rvb.26 for ; Sun, 26 Oct 2008 06:37:50 -0700 (PDT) Message-ID: <2f11576a0810260637q21eaec62q4e2662742541e771@mail.gmail.com> Date: Sun, 26 Oct 2008 22:37:50 +0900 From: "KOSAKI Motohiro" Subject: Re: [RFC][PATCH] lru_add_drain_all() don't use schedule_on_each_cpu() In-Reply-To: <1225019176.32713.5.camel@twins> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <2f11576a0810210851g6e0d86benef5d801871886dd7@mail.gmail.com> <2f11576a0810211018g5166c1byc182f1194cfdd45d@mail.gmail.com> <20081023235425.9C40.KOSAKI.MOTOHIRO@jp.fujitsu.com> <1225019176.32713.5.camel@twins> Sender: owner-linux-mm@kvack.org Return-Path: To: Peter Zijlstra Cc: Heiko Carstens , Nick Piggin , linux-kernel@vger.kernel.org, Hugh Dickins , Andrew Morton , Linus Torvalds , Rik van Riel , Lee Schermerhorn , linux-mm@kvack.org, Christoph Lameter , Gautham Shenoy , Oleg Nesterov , Rusty Russell List-ID: Hi Peter, >> @@ -611,4 +613,8 @@ void __init swap_setup(void) >> #ifdef CONFIG_HOTPLUG_CPU >> hotcpu_notifier(cpu_swap_callback, 0); >> #endif >> + >> + vm_wq = create_workqueue("vm_work"); >> + BUG_ON(!vm_wq); >> + >> } > > While I really hate adding yet another per-cpu thread for this, I don't > see another way out atm. Can I ask the reason of your hate? if I don't know it, making improvement patch is very difficult to me. > Oleg, Rusty, ego, you lot were discussing a similar extra per-cpu > workqueue, can we merge these two? -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org