From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-176.mta1.migadu.com (out-176.mta1.migadu.com [95.215.58.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6D59A134CF for ; Mon, 20 Jul 2026 02:35:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784514913; cv=none; b=UKf9227stNXo5V1IwicFw+/sWxw26xFcPffvcP48+lklvMDvDN1v/DMYQh294ou8tWNOdVByM67bV+xttMzfA7Ig9KyZ61uAYFmaapcdZUqiSDBIxJANiWoooxmDlnhaFC6fdmAm8cLoA/hne6iBywjuor+A9CUE7nC+gPn310E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784514913; c=relaxed/simple; bh=Ls31cldxtkwXc9ozMiPZex59cs4XFI5DH1SxSk2oev4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=A+LXyfDXG17Hml9upTlyRAx3dhcVHWInAgKBBmHFRL/LaDEAXLttWtjw0xPxXmZ0jqtfeeH/DQR2vg+NM47CX3mGLOPcv5fNxU49x1semmmdTciH6NSvcbStm9EPU9P837x01RflypPr/O0DJvodFFdeu27RTssi7pmMR2n9Fh0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=TymK8j/3; arc=none smtp.client-ip=95.215.58.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="TymK8j/3" Message-ID: <2f11e175-90c8-4b04-adcc-633c3e7edb54@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1784514910; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Bq4r4xhkrQH++cSZOcH5rqUYb4Fh/bIgoEGtfzQfnnY=; b=TymK8j/3huISra4w/srHkkSLcA8RMDKw2QFkZpHvVL9yAUmlYTqakkoUNohNks5SUGatwU iokVS0rJzvzU6cBkcgBU90HYKgDBz3cwKswtIt6SFsU2VbA4Hsr5196/IYmId+CE90F5Z/ A/+8J7+ehq7hB/dyerbSnSD7m2xeiI4= Date: Mon, 20 Jul 2026 10:34:40 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH v2 3/4] mm: vmscan: drop unused gfp_mask parameter from __node_reclaim() To: Ridong Chen , akpm@linux-foundation.org Cc: hannes@cmpxchg.org, david@kernel.org, mhocko@kernel.org, shakeel.butt@linux.dev, ljs@kernel.org, kasong@tencent.com, baohua@kernel.org, axelrasmussen@google.com, yuanchu@google.com, weixugc@google.com, hezhongkun.hzk@bytedance.com, muchun.song@linux.dev, dave@stgolabs.net, roman.gushchin@linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Ridong Chen References: <20260718095251.82937-1-ridong.chen@linux.dev> <20260718095251.82937-4-ridong.chen@linux.dev> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Qi Zheng In-Reply-To: <20260718095251.82937-4-ridong.chen@linux.dev> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT On 7/18/26 5:52 PM, Ridong Chen wrote: > From: Ridong Chen > > Commit 57972c78e678 ("mm/vmscan: make __node_reclaim() more generic") > moved the scan_control construction out to the callers and passed the > struct in by pointer. After that change every use of the gfp mask inside > __node_reclaim() goes through sc->gfp_mask, leaving the gfp_mask parameter > unused. Just remove the dead parameter and update the callers accordingly. > No functional change. > > Acked-by: Shakeel Butt > Acked-by: Johannes Weiner > Reviewed-by: Muchun Song > Signed-off-by: Ridong Chen > --- > mm/vmscan.c | 9 ++++----- > 1 file changed, 4 insertions(+), 5 deletions(-) > Reviewed-by: Qi Zheng Thanks, Qi